Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/9884
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9884#issuecomment-197581451
**[Test build #2644 has
started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2644/consoleFull)**
for PR 9884 at commit
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/9884#discussion_r56428301
--- Diff: mllib/src/main/scala/org/apache/spark/ml/feature/RFormula.scala
---
@@ -298,4 +412,51 @@ private class VectorAttributeRewriter(
}
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9884#issuecomment-197582121
**[Test build #2644 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2644/consoleFull)**
for PR 9884 at commit
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/9884#discussion_r56428279
--- Diff: mllib/src/main/scala/org/apache/spark/ml/feature/RFormula.scala
---
@@ -169,9 +179,9 @@ class RFormula(override val uid: String) extends
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/9884#discussion_r56428318
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/feature/RFormulaSuite.scala ---
@@ -214,4 +215,41 @@ class RFormulaSuite extends SparkFunSuite with
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9884#issuecomment-197705684
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9884#issuecomment-197695687
**[Test build #53390 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/53390/consoleFull)**
for PR 9884 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9884#issuecomment-197705628
**[Test build #53390 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/53390/consoleFull)**
for PR 9884 at commit
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/9884#discussion_r56428287
--- Diff: mllib/src/main/scala/org/apache/spark/ml/feature/RFormula.scala
---
@@ -247,6 +314,51 @@ private class ColumnPruner(columnsToPrune:
Set[String])
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/9884#discussion_r56428307
--- Diff: mllib/src/main/scala/org/apache/spark/ml/feature/RFormula.scala
---
@@ -298,4 +412,51 @@ private class VectorAttributeRewriter(
}
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/9884#discussion_r56428323
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/feature/RFormulaSuite.scala ---
@@ -214,4 +215,41 @@ class RFormulaSuite extends SparkFunSuite with
Github user jkbradley commented on the pull request:
https://github.com/apache/spark/pull/9884#issuecomment-197587888
I only saw a few issues. Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user yinxusen commented on a diff in the pull request:
https://github.com/apache/spark/pull/9884#discussion_r56454520
--- Diff: mllib/src/main/scala/org/apache/spark/ml/feature/RFormula.scala
---
@@ -189,9 +199,9 @@ class RFormula(override val uid: String) extends
Github user jkbradley commented on the pull request:
https://github.com/apache/spark/pull/9884#issuecomment-197580733
I'll take a look now
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9884#issuecomment-197705682
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user yinxusen commented on a diff in the pull request:
https://github.com/apache/spark/pull/9884#discussion_r56454473
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/feature/RFormulaSuite.scala ---
@@ -214,4 +215,41 @@ class RFormulaSuite extends SparkFunSuite with
Github user jkbradley commented on the pull request:
https://github.com/apache/spark/pull/9884#issuecomment-197982942
LGTM
Merging with master
Thanks @yinxusen !
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9884#issuecomment-169674519
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9884#issuecomment-169887856
**[Test build #48998 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48998/consoleFull)**
for PR 9884 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9884#issuecomment-169887924
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9884#issuecomment-169887925
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user yinxusen commented on the pull request:
https://github.com/apache/spark/pull/9884#issuecomment-169880808
cc @jkbradley I updated the cross validator. Could you make a pass of it?
Thx
---
If your project is set up for it, you can reply to this email and have your
reply
Github user yinxusen commented on the pull request:
https://github.com/apache/spark/pull/9884#issuecomment-169880678
ok to test
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9884#issuecomment-169882263
**[Test build #48998 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48998/consoleFull)**
for PR 9884 at commit
Github user yinxusen commented on the pull request:
https://github.com/apache/spark/pull/9884#issuecomment-163831140
@cafreeman I believe the saved pipeline can be loaded in another spark
context.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9884#issuecomment-159284052
**[Test build #46605 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/46605/consoleFull)**
for PR 9884 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9884#issuecomment-159299193
**[Test build #46605 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/46605/consoleFull)**
for PR 9884 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9884#issuecomment-159299766
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9884#issuecomment-159299759
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9884#issuecomment-158613288
**[Test build #46476 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/46476/consoleFull)**
for PR 9884 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9884#issuecomment-158626876
**[Test build #46479 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/46479/consoleFull)**
for PR 9884 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9884#issuecomment-158616776
**[Test build #46476 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/46476/consoleFull)**
for PR 9884 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9884#issuecomment-158616806
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9884#issuecomment-158616808
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9884#issuecomment-158620275
**[Test build #46479 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/46479/consoleFull)**
for PR 9884 at commit
GitHub user yinxusen opened a pull request:
https://github.com/apache/spark/pull/9884
[SPARK-11891] Model export/import for RFormula and RFormulaModel
https://issues.apache.org/jira/browse/SPARK-11891
The RFormula shares the same problem with
Github user yinxusen commented on the pull request:
https://github.com/apache/spark/pull/9884#issuecomment-158613451
I will update `CrossValidator` after it merging into master.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9884#issuecomment-158627228
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9884#issuecomment-158627226
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
40 matches
Mail list logo
