[GitHub] spark pull request: [SPARK-11912] [ML] ml.feature.PCA minor refact...

2015-11-22 Thread mengxr
Github user mengxr commented on the pull request: https://github.com/apache/spark/pull/9897#issuecomment-158858931 LGTM. Merged into master and branch-1.6. Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your p

[GitHub] spark pull request: [SPARK-11912] [ML] ml.feature.PCA minor refact...

2015-11-22 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/9897 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[GitHub] spark pull request: [SPARK-11912] [ML] ml.feature.PCA minor refact...

2015-11-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9897#issuecomment-158847452 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/4

[GitHub] spark pull request: [SPARK-11912] [ML] ml.feature.PCA minor refact...

2015-11-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9897#issuecomment-158847450 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-11912] [ML] ml.feature.PCA minor refact...

2015-11-22 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9897#issuecomment-158847410 **[Test build #46505 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/46505/consoleFull)** for PR 9897 at commit [`430fb0e`](https://git

[GitHub] spark pull request: [SPARK-11912] [ML] ml.feature.PCA minor refact...

2015-11-22 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9897#issuecomment-158839770 **[Test build #46505 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/46505/consoleFull)** for PR 9897 at commit [`430fb0e`](https://gith

[GitHub] spark pull request: [SPARK-11912] [ML] ml.feature.PCA minor refact...

2015-11-22 Thread yanboliang
GitHub user yanboliang opened a pull request: https://github.com/apache/spark/pull/9897 [SPARK-11912] [ML] ml.feature.PCA minor refactor Like [SPARK-11852](https://issues.apache.org/jira/browse/SPARK-11852), ```k``` is params and we should save it under ```metadata/``` rather than b