[GitHub] spark pull request: [SPARK-12007] [network] Avoid copies in the ne...

2016-02-25 Thread vanzin
Github user vanzin commented on the pull request: https://github.com/apache/spark/pull/9987#issuecomment-189100865 @yaooqinn please don't ask questions on github, especially on old, closed PRs. It's confusing. --- If your project is set up for it, you can reply to this email and

[GitHub] spark pull request: [SPARK-12007] [network] Avoid copies in the ne...

2016-02-25 Thread yaooqinn
Github user yaooqinn commented on the pull request: https://github.com/apache/spark/pull/9987#issuecomment-189095247 @vanzin ```scala 16/02/26 10:35:04 WARN TaskSetManager: Lost task 213.0 in stage 1.0 (TID 16971, SZV141645): FetchFailed(BlockManagerId(118,

[GitHub] spark pull request: [SPARK-12007] [network] Avoid copies in the ne...

2015-11-30 Thread vanzin
Github user vanzin commented on the pull request: https://github.com/apache/spark/pull/9987#issuecomment-160694928 /cc @rxin @zsxwing --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request: [SPARK-12007] [network] Avoid copies in the ne...

2015-11-30 Thread zsxwing
Github user zsxwing commented on a diff in the pull request: https://github.com/apache/spark/pull/9987#discussion_r46184230 --- Diff: network/common/src/main/java/org/apache/spark/network/protocol/AbstractResponseMessage.java --- @@ -17,23 +17,15 @@ package

[GitHub] spark pull request: [SPARK-12007] [network] Avoid copies in the ne...

2015-11-30 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/9987#discussion_r46188209 --- Diff: network/common/src/main/java/org/apache/spark/network/protocol/AbstractResponseMessage.java --- @@ -17,23 +17,15 @@ package

[GitHub] spark pull request: [SPARK-12007] [network] Avoid copies in the ne...

2015-11-30 Thread zsxwing
Github user zsxwing commented on the pull request: https://github.com/apache/spark/pull/9987#issuecomment-160707137 This is really cool. I was thinking to do this this week :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] spark pull request: [SPARK-12007] [network] Avoid copies in the ne...

2015-11-30 Thread zsxwing
Github user zsxwing commented on the pull request: https://github.com/apache/spark/pull/9987#issuecomment-160742818 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] spark pull request: [SPARK-12007] [network] Avoid copies in the ne...

2015-11-30 Thread zsxwing
Github user zsxwing commented on a diff in the pull request: https://github.com/apache/spark/pull/9987#discussion_r46195443 --- Diff: network/common/src/main/java/org/apache/spark/network/protocol/AbstractResponseMessage.java --- @@ -17,23 +17,15 @@ package

[GitHub] spark pull request: [SPARK-12007] [network] Avoid copies in the ne...

2015-11-30 Thread andrewor14
Github user andrewor14 commented on the pull request: https://github.com/apache/spark/pull/9987#issuecomment-160816349 Merging into master 1.6, thanks for fixing this @vanzin. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] spark pull request: [SPARK-12007] [network] Avoid copies in the ne...

2015-11-30 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/9987 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: [SPARK-12007] [network] Avoid copies in the ne...

2015-11-30 Thread vanzin
Github user vanzin commented on the pull request: https://github.com/apache/spark/pull/9987#issuecomment-160804852 > OK, I'd like to merge this into 1.6 as well to further mitigate the scheduler throughput regression. Did you measure the effect this change has on the test?

[GitHub] spark pull request: [SPARK-12007] [network] Avoid copies in the ne...

2015-11-30 Thread andrewor14
Github user andrewor14 commented on the pull request: https://github.com/apache/spark/pull/9987#issuecomment-160804478 OK, I'd like to merge this into 1.6 as well to further mitigate the scheduler throughput regression. --- If your project is set up for it, you can reply to this

[GitHub] spark pull request: [SPARK-12007] [network] Avoid copies in the ne...

2015-11-30 Thread andrewor14
Github user andrewor14 commented on the pull request: https://github.com/apache/spark/pull/9987#issuecomment-160805500 I think @zsxwing did some local benchmarks and saw like a 10% improvement --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] spark pull request: [SPARK-12007] [network] Avoid copies in the ne...

2015-11-28 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9987#issuecomment-160362548 **[Test build #46846 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/46846/consoleFull)** for PR 9987 at commit

[GitHub] spark pull request: [SPARK-12007] [network] Avoid copies in the ne...

2015-11-28 Thread vanzin
Github user vanzin commented on the pull request: https://github.com/apache/spark/pull/9987#issuecomment-160349267 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request: [SPARK-12007] [network] Avoid copies in the ne...

2015-11-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9987#issuecomment-160371728 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-12007] [network] Avoid copies in the ne...

2015-11-28 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9987#issuecomment-160351498 **[Test build #46844 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/46844/consoleFull)** for PR 9987 at commit

[GitHub] spark pull request: [SPARK-12007] [network] Avoid copies in the ne...

2015-11-28 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9987#issuecomment-160360588 **[Test build #46844 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/46844/consoleFull)** for PR 9987 at commit

[GitHub] spark pull request: [SPARK-12007] [network] Avoid copies in the ne...

2015-11-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9987#issuecomment-160360654 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-12007] [network] Avoid copies in the ne...

2015-11-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9987#issuecomment-160360652 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-12007] [network] Avoid copies in the ne...

2015-11-28 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9987#issuecomment-160371706 **[Test build #46846 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/46846/consoleFull)** for PR 9987 at commit

[GitHub] spark pull request: [SPARK-12007] [network] Avoid copies in the ne...

2015-11-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9987#issuecomment-160371727 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-12007] [network] Avoid copies in the ne...

2015-11-25 Thread vanzin
GitHub user vanzin opened a pull request: https://github.com/apache/spark/pull/9987 [SPARK-12007] [network] Avoid copies in the network lib's RPC layer. This change seems large, but most of it is just replacing `byte[]` with `ByteBuffer` and `new byte[]` with

[GitHub] spark pull request: [SPARK-12007] [network] Avoid copies in the ne...

2015-11-25 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9987#issuecomment-159781840 **[Test build #46729 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/46729/consoleFull)** for PR 9987 at commit

[GitHub] spark pull request: [SPARK-12007] [network] Avoid copies in the ne...

2015-11-25 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9987#issuecomment-159816190 **[Test build #46729 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/46729/consoleFull)** for PR 9987 at commit

[GitHub] spark pull request: [SPARK-12007] [network] Avoid copies in the ne...

2015-11-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9987#issuecomment-159816212 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-12007] [network] Avoid copies in the ne...

2015-11-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9987#issuecomment-159816209 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your