[GitHub] spark pull request: [SPARK-12152][PROJECT-INFRA] Speed up Scalasty...

2015-12-06 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/10151 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: [SPARK-12152][PROJECT-INFRA] Speed up Scalasty...

2015-12-06 Thread JoshRosen
Github user JoshRosen commented on the pull request: https://github.com/apache/spark/pull/10151#issuecomment-162386145 We can handle retention of the output in a followup, since it'd probably be best to also do it for Java, Python, and R style checks. Therefore, I'm going to merge

[GitHub] spark pull request: [SPARK-12152][PROJECT-INFRA] Speed up Scalasty...

2015-12-04 Thread JoshRosen
GitHub user JoshRosen opened a pull request: https://github.com/apache/spark/pull/10151 [SPARK-12152][PROJECT-INFRA] Speed up Scalastyle checks by only invoking SBT once Currently, `dev/scalastyle` invokes SBT four times, but these invocations can be replaced with a single

[GitHub] spark pull request: [SPARK-12152][PROJECT-INFRA] Speed up Scalasty...

2015-12-04 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10151#issuecomment-162107088 **[Test build #47209 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/47209/consoleFull)** for PR 10151 at commit

[GitHub] spark pull request: [SPARK-12152][PROJECT-INFRA] Speed up Scalasty...

2015-12-04 Thread vanzin
Github user vanzin commented on the pull request: https://github.com/apache/spark/pull/10151#issuecomment-162108352 I have code in #6502 to keep the scalastyle.txt file around (so we can look at warnings). Both changes will conflict in any case, but it would be nice to have the

[GitHub] spark pull request: [SPARK-12152][PROJECT-INFRA] Speed up Scalasty...

2015-12-04 Thread vanzin
Github user vanzin commented on the pull request: https://github.com/apache/spark/pull/10151#issuecomment-162111961 Either way. It just seems nice to keep the whole output around when it's so cheap to do it. --- If your project is set up for it, you can reply to this email and have

[GitHub] spark pull request: [SPARK-12152][PROJECT-INFRA] Speed up Scalasty...

2015-12-04 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10151#issuecomment-162117523 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-12152][PROJECT-INFRA] Speed up Scalasty...

2015-12-04 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10151#issuecomment-162117524 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-12152][PROJECT-INFRA] Speed up Scalasty...

2015-12-04 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10151#issuecomment-162117481 **[Test build #47209 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/47209/consoleFull)** for PR 10151 at commit

[GitHub] spark pull request: [SPARK-12152][PROJECT-INFRA] Speed up Scalasty...

2015-12-04 Thread JoshRosen
Github user JoshRosen commented on the pull request: https://github.com/apache/spark/pull/10151#issuecomment-162111075 @vanzin, what about just running `sbt/scalastyle` by hand if you want to inspect the log output? --- If your project is set up for it, you can reply to this email