Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/11855
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is ena
Github user jkbradley commented on the pull request:
https://github.com/apache/spark/pull/11855#issuecomment-200656539
I'll go ahead and merge this with master.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your proj
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11855#issuecomment-200621881
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11855#issuecomment-200621876
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11855#issuecomment-200621594
**[Test build #53988 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/53988/consoleFull)**
for PR 11855 at commit
[`7bc7e6d`](https://g
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11855#issuecomment-200607290
**[Test build #53988 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/53988/consoleFull)**
for PR 11855 at commit
[`7bc7e6d`](https://gi
Github user jkbradley commented on the pull request:
https://github.com/apache/spark/pull/11855#issuecomment-200607002
I just rebased to fix the merge conflicts. The only change other than
rebasing is in the last commit. @sethah Thank you for reviewing!
---
If your project is set u
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/11855#discussion_r57263476
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/tree/impl/RandomForest.scala ---
@@ -1025,7 +1048,9 @@ private[ml] object RandomForest extends Logging {
Github user sethah commented on the pull request:
https://github.com/apache/spark/pull/11855#issuecomment-200518240
You can remove `InformationGainStats` companion object altogether now, I
believe. It is not used after this PR. This LGTM other than that.
---
If your project is set up
Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/11855#discussion_r57218161
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/tree/impl/RandomForest.scala ---
@@ -1025,7 +1048,9 @@ private[ml] object RandomForest extends Logging {
Github user jkbradley commented on the pull request:
https://github.com/apache/spark/pull/11855#issuecomment-200473537
@sethah Let me know when you think this is ready---thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as w
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11855#issuecomment-200069171
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11855#issuecomment-200069172
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11855#issuecomment-200069056
**[Test build #53830 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/53830/consoleFull)**
for PR 11855 at commit
[`f82cda9`](https://g
Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/11855#discussion_r57079588
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/tree/impl/RandomForest.scala ---
@@ -1047,6 +1076,12 @@ private[ml] object RandomForest extends Logging {
Github user jkbradley commented on the pull request:
https://github.com/apache/spark/pull/11855#issuecomment-200054197
@sethah Thanks a lot for reviewing this patch! I think I addressed
everything.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11855#issuecomment-200054242
**[Test build #53830 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/53830/consoleFull)**
for PR 11855 at commit
[`f82cda9`](https://gi
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/11855#discussion_r57078137
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/tree/impl/RandomForest.scala ---
@@ -1047,6 +1076,12 @@ private[ml] object RandomForest extends Logging
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/11855#discussion_r57077853
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/tree/impl/RandomForest.scala ---
@@ -1025,7 +1052,9 @@ private[ml] object RandomForest extends Logging {
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/11855#discussion_r57077278
--- Diff:
mllib/src/test/scala/org/apache/spark/mllib/tree/DecisionTreeSuite.scala ---
@@ -563,18 +136,10 @@ class DecisionTreeSuite extends SparkFunSuite
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/11855#discussion_r57075903
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/tree/impl/RandomForestSuite.scala ---
@@ -33,6 +39,406 @@ class RandomForestSuite extends SparkFunSuite
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/11855#discussion_r57075802
--- Diff:
mllib/src/test/scala/org/apache/spark/mllib/tree/DecisionTreeSuite.scala ---
@@ -852,10 +399,7 @@ class DecisionTreeSuite extends SparkFunSuite w
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/11855#discussion_r57075598
--- Diff:
mllib/src/test/scala/org/apache/spark/mllib/tree/DecisionTreeSuite.scala ---
@@ -539,18 +120,10 @@ class DecisionTreeSuite extends SparkFunSuite
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/11855#discussion_r57075513
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/tree/impl/RandomForestSuite.scala ---
@@ -33,6 +39,406 @@ class RandomForestSuite extends SparkFunSuite
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/11855#discussion_r57075419
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/tree/impl/RandomForestSuite.scala ---
@@ -33,6 +39,406 @@ class RandomForestSuite extends SparkFunSuite
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/11855#discussion_r57073751
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/tree/impl/RandomForestSuite.scala ---
@@ -33,6 +39,406 @@ class RandomForestSuite extends SparkFunSuite
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/11855#discussion_r57073360
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/tree/RandomForest.scala ---
@@ -443,84 +272,4 @@ object RandomForest extends Serializable with Loggin
Github user sethah commented on the pull request:
https://github.com/apache/spark/pull/11855#issuecomment-199421771
@jkbradley I made a pass. Mostly minor things on test behavior and the new
memory changes.
It feels good to delete this much code! :+1:
---
If your project i
Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/11855#discussion_r56874894
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/tree/impl/RandomForest.scala ---
@@ -1047,6 +1076,12 @@ private[ml] object RandomForest extends Logging {
Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/11855#discussion_r56869033
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/tree/impl/RandomForest.scala ---
@@ -1025,7 +1052,9 @@ private[ml] object RandomForest extends Logging {
Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/11855#discussion_r56866777
--- Diff:
mllib/src/test/scala/org/apache/spark/mllib/tree/DecisionTreeSuite.scala ---
@@ -563,18 +136,10 @@ class DecisionTreeSuite extends SparkFunSuite wit
Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/11855#discussion_r56865956
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/tree/impl/RandomForestSuite.scala ---
@@ -33,6 +39,406 @@ class RandomForestSuite extends SparkFunSuite wit
Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/11855#discussion_r56863232
--- Diff:
mllib/src/test/scala/org/apache/spark/mllib/tree/DecisionTreeSuite.scala ---
@@ -852,10 +399,7 @@ class DecisionTreeSuite extends SparkFunSuite with
Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/11855#discussion_r56861596
--- Diff:
mllib/src/test/scala/org/apache/spark/mllib/tree/DecisionTreeSuite.scala ---
@@ -539,18 +120,10 @@ class DecisionTreeSuite extends SparkFunSuite wit
Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/11855#discussion_r56857278
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/tree/impl/RandomForestSuite.scala ---
@@ -33,6 +39,406 @@ class RandomForestSuite extends SparkFunSuite wit
Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/11855#discussion_r56855438
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/tree/impl/RandomForestSuite.scala ---
@@ -33,6 +39,406 @@ class RandomForestSuite extends SparkFunSuite wit
Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/11855#discussion_r56855217
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/tree/impl/RandomForestSuite.scala ---
@@ -33,6 +39,406 @@ class RandomForestSuite extends SparkFunSuite wit
Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/11855#discussion_r56844348
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/tree/RandomForest.scala ---
@@ -443,84 +272,4 @@ object RandomForest extends Serializable with Logging {
Github user sethah commented on the pull request:
https://github.com/apache/spark/pull/11855#issuecomment-199343599
This is not related to your changes, but I noticed that the return type in
the comment
[here](https://github.com/apache/spark/blob/master/mllib/src/main/scala/org/apache
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11855#issuecomment-199098590
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11855#issuecomment-199098591
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11855#issuecomment-199098548
**[Test build #53649 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/53649/consoleFull)**
for PR 11855 at commit
[`bf6bcae`](https://g
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11855#issuecomment-199090613
**[Test build #53649 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/53649/consoleFull)**
for PR 11855 at commit
[`bf6bcae`](https://gi
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11855#issuecomment-199087386
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11855#issuecomment-199087371
**[Test build #53644 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/53644/consoleFull)**
for PR 11855 at commit
[`d6433da`](https://g
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11855#issuecomment-199087381
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11855#issuecomment-199086954
**[Test build #53644 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/53644/consoleFull)**
for PR 11855 at commit
[`d6433da`](https://gi
Github user jkbradley commented on the pull request:
https://github.com/apache/spark/pull/11855#issuecomment-199086732
CC: @sethah @MLnick @yanboliang @yinxusen I'm CCing people who have looked
at trees recently. This is a long PR, but I hope the notes make it easy to
review. Thanks
GitHub user jkbradley opened a pull request:
https://github.com/apache/spark/pull/11855
[SPARK-12183][ML][MLLIB] Remove mllib tree implementation, and wrap
spark.ml one
Primary change:
* Removed spark.mllib.tree.DecisionTree implementation of tree and forest
learning.
* spa
49 matches
Mail list logo
