[GitHub] spark pull request: [SPARK-12188] [SQL] Code refactoring and comme...

2015-12-08 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/10184 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: [SPARK-12188] [SQL] Code refactoring and comme...

2015-12-08 Thread marmbrus
Github user marmbrus commented on a diff in the pull request: https://github.com/apache/spark/pull/10184#discussion_r46992054 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala --- @@ -429,18 +432,18 @@ class Dataset[T] private[sql]( /** *

[GitHub] spark pull request: [SPARK-12188] [SQL] Code refactoring and comme...

2015-12-08 Thread marmbrus
Github user marmbrus commented on the pull request: https://github.com/apache/spark/pull/10184#issuecomment-162969383 Thanks, I'm going to merge this to master and 1.6. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] spark pull request: [SPARK-12188] [SQL] Code refactoring and comme...

2015-12-08 Thread marmbrus
Github user marmbrus commented on a diff in the pull request: https://github.com/apache/spark/pull/10184#discussion_r46991908 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala --- @@ -67,15 +67,21 @@ class Dataset[T] private[sql]( tEncoder: Encoder[T])

[GitHub] spark pull request: [SPARK-12188] [SQL] Code refactoring and comme...

2015-12-08 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/10184#discussion_r47046420 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala --- @@ -429,18 +432,18 @@ class Dataset[T] private[sql]( /** *

[GitHub] spark pull request: [SPARK-12188] [SQL] Code refactoring and comme...

2015-12-08 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/10184#discussion_r47046431 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala --- @@ -67,15 +67,21 @@ class Dataset[T] private[sql]( tEncoder: Encoder[T])

[GitHub] spark pull request: [SPARK-12188] [SQL] Code refactoring and comme...

2015-12-08 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/10184#discussion_r47046739 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala --- @@ -67,15 +67,21 @@ class Dataset[T] private[sql]( tEncoder: Encoder[T])

[GitHub] spark pull request: [SPARK-12188] [SQL] Code refactoring and comme...

2015-12-08 Thread marmbrus
Github user marmbrus commented on a diff in the pull request: https://github.com/apache/spark/pull/10184#discussion_r47046675 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala --- @@ -67,15 +67,21 @@ class Dataset[T] private[sql]( tEncoder: Encoder[T])

[GitHub] spark pull request: [SPARK-12188] [SQL] Code refactoring and comme...

2015-12-07 Thread gatorsmile
GitHub user gatorsmile opened a pull request: https://github.com/apache/spark/pull/10184 [SPARK-12188] [SQL] Code refactoring and comment correction in Dataset APIs This PR contains the following updates: - Created a new private variable `boundTEncoder` that can be shared

[GitHub] spark pull request: [SPARK-12188] [SQL] Code refactoring and comme...

2015-12-07 Thread marmbrus
Github user marmbrus commented on the pull request: https://github.com/apache/spark/pull/10184#issuecomment-162738003 ok to test --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark pull request: [SPARK-12188] [SQL] Code refactoring and comme...

2015-12-07 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10184#issuecomment-162739073 **[Test build #47298 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/47298/consoleFull)** for PR 10184 at commit

[GitHub] spark pull request: [SPARK-12188] [SQL] Code refactoring and comme...

2015-12-07 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10184#issuecomment-162739762 **[Test build #47300 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/47300/consoleFull)** for PR 10184 at commit

[GitHub] spark pull request: [SPARK-12188] [SQL] Code refactoring and comme...

2015-12-07 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10184#issuecomment-162752577 **[Test build #47300 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/47300/consoleFull)** for PR 10184 at commit

[GitHub] spark pull request: [SPARK-12188] [SQL] Code refactoring and comme...

2015-12-07 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10184#issuecomment-162752660 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-12188] [SQL] Code refactoring and comme...

2015-12-07 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10184#issuecomment-162752661 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-12188] [SQL] Code refactoring and comme...

2015-12-07 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10184#issuecomment-162752001 **[Test build #47298 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/47298/consoleFull)** for PR 10184 at commit

[GitHub] spark pull request: [SPARK-12188] [SQL] Code refactoring and comme...

2015-12-07 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10184#issuecomment-162752145 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-12188] [SQL] Code refactoring and comme...

2015-12-07 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10184#issuecomment-162752149 Test PASSed. Refer to this link for build results (access rights to CI server needed):