[GitHub] spark pull request: [SPARK-12267][Core]Store the remote RpcEnv add...

Github user zsxwing commented on the pull request: https://github.com/apache/spark/pull/10261#issuecomment-164229994 > Akka doesn't have this problem as far as I understand the code; also because the akka rpc backend never runs in "client mode" (that's a netty rpc-only thing).

[GitHub] spark pull request: [SPARK-12267][Core]Store the remote RpcEnv add...

Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/10261 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: [SPARK-12267][Core]Store the remote RpcEnv add...

Github user zsxwing commented on the pull request: https://github.com/apache/spark/pull/10261#issuecomment-164231271 @vanzin I created [SPARK-12308](https://issues.apache.org/jira/browse/SPARK-12308) to remind us of your approach --- If your project is set up for it, you can reply

[GitHub] spark pull request: [SPARK-12267][Core]Store the remote RpcEnv add...

Github user vanzin commented on the pull request: https://github.com/apache/spark/pull/10261#issuecomment-164177066 Akka doesn't have this problem as far as I understand the code; also because the akka rpc backend never runs in "client mode" (that's a netty rpc-only thing). --- If

[GitHub] spark pull request: [SPARK-12267][Core]Store the remote RpcEnv add...

Github user vanzin commented on the pull request: https://github.com/apache/spark/pull/10261#issuecomment-164177137 BTW I'm fine with this change for 1.6; we can revisit this later to avoid having to keep extra state in the RPC layer. --- If your project is set up for it, you can

[GitHub] spark pull request: [SPARK-12267][Core]Store the remote RpcEnv add...

Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10261#issuecomment-164059104 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-12267][Core]Store the remote RpcEnv add...

Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10261#issuecomment-164059097 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-12267][Core]Store the remote RpcEnv add...

Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10261#issuecomment-164058531 **[Test build #47588 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/47588/consoleFull)** for PR 10261 at commit

[GitHub] spark pull request: [SPARK-12267][Core]Store the remote RpcEnv add...

Github user zsxwing commented on the pull request: https://github.com/apache/spark/pull/10261#issuecomment-164110300 I see. However, for 1.6, we still need to support Akka RPC. Is it possible to get the client address from `ActorRef`? --- If your project is set up for it, you can

[GitHub] spark pull request: [SPARK-12267][Core]Store the remote RpcEnv add...

Github user vanzin commented on the pull request: https://github.com/apache/spark/pull/10261#issuecomment-164107825 > I saw your following comment...But I don't get it. That's because we took opposite approaches. Your PR's approach is "if this connection says the sender

[GitHub] spark pull request: [SPARK-12267][Core]Store the remote RpcEnv add...

Github user zsxwing commented on the pull request: https://github.com/apache/spark/pull/10261#issuecomment-164037328 @vanzin I saw your following comment in

[GitHub] spark pull request: [SPARK-12267][Core]Store the remote RpcEnv add...

Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10261#issuecomment-164036553 **[Test build #47588 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/47588/consoleFull)** for PR 10261 at commit

[GitHub] spark pull request: [SPARK-12267][Core]Store the remote RpcEnv add...

Github user zsxwing commented on the pull request: https://github.com/apache/spark/pull/10261#issuecomment-163817812 Cool. I will close this PR. On Thu, Dec 10, 2015 at 6:28 PM Marcelo Vanzin wrote: > So, I don't think this is gonna

[GitHub] spark pull request: [SPARK-12267][Core]Store the remote RpcEnv add...

Github user zsxwing commented on a diff in the pull request: https://github.com/apache/spark/pull/10261#discussion_r47314731 --- Diff: core/src/main/scala/org/apache/spark/rpc/netty/NettyRpcEnv.scala --- @@ -580,6 +583,12 @@ private[netty] class NettyRpcHandler( //

[GitHub] spark pull request: [SPARK-12267][Core]Store the remote RpcEnv add...

Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10261#issuecomment-163816221 **[Test build #47561 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/47561/consoleFull)** for PR 10261 at commit

[GitHub] spark pull request: [SPARK-12267][Core]Store the remote RpcEnv add...

Github user vanzin commented on the pull request: https://github.com/apache/spark/pull/10261#issuecomment-163816892 So, I don't think this is gonna work, and that's why my change is taking longer than I hoped to finish... while this might fix the immediate problem listed in the bug,

[GitHub] spark pull request: [SPARK-12267][Core]Store the remote RpcEnv add...

Github user zsxwing commented on the pull request: https://github.com/apache/spark/pull/10261#issuecomment-163810210 CC @vanzin could you take a look? Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-12267][Core]Store the remote RpcEnv add...

GitHub user zsxwing opened a pull request: https://github.com/apache/spark/pull/10261 [SPARK-12267][Core]Store the remote RpcEnv address to send the correct disconnetion message You can merge this pull request into a Git repository by running: $ git pull

[GitHub] spark pull request: [SPARK-12267][Core]Store the remote RpcEnv add...

Github user marmbrus commented on the pull request: https://github.com/apache/spark/pull/10261#issuecomment-163819194 hey guys, I know this is still in flight, but we are pretty behind on the release. I'm going to cut RC2 and we can always make a judgement call about doing an RC3

[GitHub] spark pull request: [SPARK-12267][Core]Store the remote RpcEnv add...

Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10261#issuecomment-163855910 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-12267][Core]Store the remote RpcEnv add...

Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10261#issuecomment-163855821 **[Test build #47561 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/47561/consoleFull)** for PR 10261 at commit

[GitHub] spark pull request: [SPARK-12267][Core]Store the remote RpcEnv add...

Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10261#issuecomment-163855911 Test FAILed. Refer to this link for build results (access rights to CI server needed):