Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/10314#discussion_r48992838
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/SQLConf.scala ---
@@ -214,7 +256,7 @@ private[spark] object SQLConf {
doc = "When true,
Github user marmbrus commented on the pull request:
https://github.com/apache/spark/pull/10314#issuecomment-169417153
I think just `long` is fine for now. The title still has spelling errors
and is really long. I would say:
`[SPARK-12317][SQL] Support units (m,k,g) in
Github user kevinyu98 commented on the pull request:
https://github.com/apache/spark/pull/10314#issuecomment-169238048
@viirya @yhuai @srowen @marmbrus @concretevitamin:
SHUFFLE_TARGET_POSTSHUFFLE_INPUT_SIZE was added by spark-9850, PR#9276, I am
including Yin ,
Michael set the
Github user viirya commented on the pull request:
https://github.com/apache/spark/pull/10314#issuecomment-169213838
I have the same question as @marmbrus, do we need two methods for int and
long? Looks like they are very similar.
---
If your project is set up for it, you can reply
Github user kevinyu98 commented on the pull request:
https://github.com/apache/spark/pull/10314#issuecomment-169220626
Hello @viirya : Good Point. I just test it, -1 and -1g will have different
behavior. It will take -1, and throw IllegalArgumentException for -1g. Thanks.
---
If
Github user viirya commented on the pull request:
https://github.com/apache/spark/pull/10314#issuecomment-169214001
Besides, -1 and -1g will be the same or different behavior?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user kevinyu98 commented on the pull request:
https://github.com/apache/spark/pull/10314#issuecomment-169173265
Hello @srowen @marmbrus @viirya : I have made the code changes, and change
the title based on the comments. Can you help review the codes? Thanks.
---
If your
