Github user ajbozarth commented on the pull request:
https://github.com/apache/spark/pull/10405#issuecomment-166391481
@srowen I thought the same thing so I looked into git history and git blame
and found that this is how `updateTaskAccumulatorValues` has always worked,
it's original
Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/10405#issuecomment-166436867
OK, merging into master 1.6, thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/10405
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/10405#issuecomment-166258397
Maybe a dumb question, but is it right that calling
`updateTaskAccumulatorValues` is meaningless if there are no `taskMetrics`?
that is, should the call not happen at
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10405#issuecomment-166170888
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10405#issuecomment-166170840
**[Test build #48089 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48089/consoleFull)**
for PR 10405 at commit
GitHub user ajbozarth opened a pull request:
https://github.com/apache/spark/pull/10405
[SPARK-12339] [WebUI] Added a null check that was removed in SPARK-11206
Updates made in SPARK-11206 missed an edge case which cause's a
NullPointerException when a task is killed. In some cases
Github user ajbozarth commented on the pull request:
https://github.com/apache/spark/pull/10405#issuecomment-166165475
FYI the line in JobProgressListener.onTaskEnd that initializes the null
value is 387.
---
If your project is set up for it, you can reply to this email and have
Github user ajbozarth commented on the pull request:
https://github.com/apache/spark/pull/10405#issuecomment-166165392
Looping in those involved with SPARK-11206: @carsonwang @JoshRosen @vanzin
---
If your project is set up for it, you can reply to this email and have your
reply
Github user carsonwang commented on the pull request:
https://github.com/apache/spark/pull/10405#issuecomment-166184298
Thanks for catching this. I think the null check here is necessary, and it
seems the code that really pass a null taskMetrcis is from the `TaskSetManager`
line 796
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10405#issuecomment-166165926
**[Test build #48089 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48089/consoleFull)**
for PR 10405 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10405#issuecomment-166170887
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
12 matches
Mail list logo
