[GitHub] spark pull request: [SPARK-12409][SPARK-12387][SPARK-12391][SQL] R...

2016-01-01 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/10470#issuecomment-168294357 Thanks - I've merged this. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-12409][SPARK-12387][SPARK-12391][SQL] R...

2016-01-01 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/10470 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: [SPARK-12409][SPARK-12387][SPARK-12391][SQL] R...

2015-12-31 Thread viirya
Github user viirya commented on the pull request: https://github.com/apache/spark/pull/10470#issuecomment-168290999 ping @rxin --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark pull request: [SPARK-12409][SPARK-12387][SPARK-12391][SQL] R...

2015-12-30 Thread viirya
Github user viirya commented on the pull request: https://github.com/apache/spark/pull/10470#issuecomment-168112310 @rxin Rebased. Wait for passing tests. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-12409][SPARK-12387][SPARK-12391][SQL] R...

2015-12-30 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10470#issuecomment-168121072 **[Test build #48534 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48534/consoleFull)** for PR 10470 at commit

[GitHub] spark pull request: [SPARK-12409][SPARK-12387][SPARK-12391][SQL] R...

2015-12-30 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10470#issuecomment-168112759 **[Test build #48534 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48534/consoleFull)** for PR 10470 at commit

[GitHub] spark pull request: [SPARK-12409][SPARK-12387][SPARK-12391][SQL] R...

2015-12-30 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10470#issuecomment-168121315 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-12409][SPARK-12387][SPARK-12391][SQL] R...

2015-12-30 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10470#issuecomment-168121319 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-12409][SPARK-12387][SPARK-12391][SQL] R...

2015-12-30 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/10470#issuecomment-168078143 @viirya I've merged https://github.com/apache/spark/pull/10468 now. --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] spark pull request: [SPARK-12409][SPARK-12387][SPARK-12391][SQL] R...

2015-12-29 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/10470#discussion_r48566768 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JDBCRDD.scala --- @@ -295,25 +318,17 @@ private[sql] class JDBCRDD(

[GitHub] spark pull request: [SPARK-12409][SPARK-12387][SPARK-12391][SQL] R...

2015-12-29 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/10470#discussion_r48566796 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JDBCRDD.scala --- @@ -295,25 +318,17 @@ private[sql] class JDBCRDD(

[GitHub] spark pull request: [SPARK-12409][SPARK-12387][SPARK-12391][SQL] R...

2015-12-29 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/10470#discussion_r48566823 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/jdbc/JDBCSuite.scala --- @@ -186,8 +187,26 @@ class JDBCSuite extends SparkFunSuite

[GitHub] spark pull request: [SPARK-12409][SPARK-12387][SPARK-12391][SQL] R...

2015-12-29 Thread maropu
Github user maropu commented on a diff in the pull request: https://github.com/apache/spark/pull/10470#discussion_r48585861 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JDBCRDD.scala --- @@ -182,18 +183,40 @@ private[sql] object JDBCRDD

[GitHub] spark pull request: [SPARK-12409][SPARK-12387][SPARK-12391][SQL] R...

2015-12-29 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/10470#discussion_r48586131 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JDBCRDD.scala --- @@ -182,18 +183,40 @@ private[sql] object JDBCRDD

[GitHub] spark pull request: [SPARK-12409][SPARK-12387][SPARK-12391][SQL] R...

2015-12-29 Thread maropu
Github user maropu commented on a diff in the pull request: https://github.com/apache/spark/pull/10470#discussion_r48585283 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JDBCRDD.scala --- @@ -295,25 +318,17 @@ private[sql] class JDBCRDD(

[GitHub] spark pull request: [SPARK-12409][SPARK-12387][SPARK-12391][SQL] R...

2015-12-29 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/10470#discussion_r48586148 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JDBCRDD.scala --- @@ -295,25 +318,17 @@ private[sql] class JDBCRDD(

[GitHub] spark pull request: [SPARK-12409][SPARK-12387][SPARK-12391][SQL] R...

2015-12-29 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/10470#discussion_r48586143 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JDBCRDD.scala --- @@ -295,25 +318,17 @@ private[sql] class JDBCRDD(

[GitHub] spark pull request: [SPARK-12409][SPARK-12387][SPARK-12391][SQL] R...

2015-12-29 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/10470#discussion_r48586155 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/jdbc/JDBCSuite.scala --- @@ -186,8 +187,26 @@ class JDBCSuite extends SparkFunSuite

[GitHub] spark pull request: [SPARK-12409][SPARK-12387][SPARK-12391][SQL] R...

2015-12-29 Thread maropu
Github user maropu commented on a diff in the pull request: https://github.com/apache/spark/pull/10470#discussion_r48586488 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JDBCRDD.scala --- @@ -182,18 +183,40 @@ private[sql] object JDBCRDD

[GitHub] spark pull request: [SPARK-12409][SPARK-12387][SPARK-12391][SQL] R...

2015-12-29 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10470#issuecomment-167943198 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-12409][SPARK-12387][SPARK-12391][SQL] R...

2015-12-29 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10470#issuecomment-167943199 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-12409][SPARK-12387][SPARK-12391][SQL] R...

2015-12-29 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10470#issuecomment-167943160 **[Test build #48449 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48449/consoleFull)** for PR 10470 at commit

[GitHub] spark pull request: [SPARK-12409][SPARK-12387][SPARK-12391][SQL] R...

2015-12-29 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/10470#discussion_r48588506 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JDBCRDD.scala --- @@ -182,18 +183,40 @@ private[sql] object JDBCRDD

[GitHub] spark pull request: [SPARK-12409][SPARK-12387][SPARK-12391][SQL] R...

2015-12-29 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/10470#discussion_r48585579 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JDBCRDD.scala --- @@ -182,18 +183,40 @@ private[sql] object JDBCRDD

[GitHub] spark pull request: [SPARK-12409][SPARK-12387][SPARK-12391][SQL] R...

2015-12-29 Thread maropu
Github user maropu commented on a diff in the pull request: https://github.com/apache/spark/pull/10470#discussion_r48586764 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JDBCRDD.scala --- @@ -182,18 +183,40 @@ private[sql] object JDBCRDD

[GitHub] spark pull request: [SPARK-12409][SPARK-12387][SPARK-12391][SQL] R...

2015-12-29 Thread maropu
Github user maropu commented on the pull request: https://github.com/apache/spark/pull/10470#issuecomment-167932027 @rxin Okay and I did. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request: [SPARK-12409][SPARK-12387][SPARK-12391][SQL] R...

2015-12-29 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10470#issuecomment-167934264 **[Test build #48449 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48449/consoleFull)** for PR 10470 at commit

[GitHub] spark pull request: [SPARK-12409][SPARK-12387][SPARK-12391][SQL] R...

2015-12-29 Thread maropu
Github user maropu commented on a diff in the pull request: https://github.com/apache/spark/pull/10470#discussion_r48588333 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JDBCRDD.scala --- @@ -182,18 +183,40 @@ private[sql] object JDBCRDD

[GitHub] spark pull request: [SPARK-12409][SPARK-12387][SPARK-12391][SQL] R...

2015-12-29 Thread maropu
Github user maropu commented on a diff in the pull request: https://github.com/apache/spark/pull/10470#discussion_r48585459 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JDBCRDD.scala --- @@ -182,18 +183,40 @@ private[sql] object JDBCRDD

[GitHub] spark pull request: [SPARK-12409][SPARK-12387][SPARK-12391][SQL] R...

2015-12-29 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/10470#discussion_r48586845 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JDBCRDD.scala --- @@ -182,18 +183,40 @@ private[sql] object JDBCRDD

[GitHub] spark pull request: [SPARK-12409][SPARK-12387][SPARK-12391][SQL] R...

2015-12-29 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/10470#discussion_r48527331 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JDBCRDD.scala --- @@ -184,16 +185,38 @@ private[sql] object JDBCRDD

[GitHub] spark pull request: [SPARK-12409][SPARK-12387][SPARK-12391][SQL] R...

2015-12-29 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10470#issuecomment-167750063 **[Test build #48408 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48408/consoleFull)** for PR 10470 at commit

[GitHub] spark pull request: [SPARK-12409][SPARK-12387][SPARK-12391][SQL] R...

2015-12-29 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/10470#discussion_r48525943 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JDBCRDD.scala --- @@ -184,16 +185,38 @@ private[sql] object JDBCRDD

[GitHub] spark pull request: [SPARK-12409][SPARK-12387][SPARK-12391][SQL] R...

2015-12-29 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10470#issuecomment-167761842 **[Test build #48408 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48408/consoleFull)** for PR 10470 at commit

[GitHub] spark pull request: [SPARK-12409][SPARK-12387][SPARK-12391][SQL] R...

2015-12-29 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10470#issuecomment-167761907 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-12409][SPARK-12387][SPARK-12391][SQL] R...

2015-12-29 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10470#issuecomment-167761905 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-12409][SPARK-12387][SPARK-12391][SQL] R...

2015-12-28 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/10470#issuecomment-167738141 @maropu can you review this change? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] spark pull request: [SPARK-12409][SPARK-12387][SPARK-12391][SQL] R...

2015-12-28 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/10470#discussion_r48524499 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JDBCRDD.scala --- @@ -184,16 +185,38 @@ private[sql] object JDBCRDD extends

[GitHub] spark pull request: [SPARK-12409][SPARK-12387][SPARK-12391][SQL] R...

2015-12-24 Thread viirya
GitHub user viirya opened a pull request: https://github.com/apache/spark/pull/10470 [SPARK-12409][SPARK-12387][SPARK-12391][SQL] Refactor filter pushdown for JDBCRDD and add few filters This patch refactors the filter pushdown for JDBCRDD and also adds few filters. Added

[GitHub] spark pull request: [SPARK-12409][SPARK-12387][SPARK-12391][SQL] R...

2015-12-24 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10470#issuecomment-167078592 **[Test build #48302 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48302/consoleFull)** for PR 10470 at commit

[GitHub] spark pull request: [SPARK-12409][SPARK-12387][SPARK-12391][SQL] R...

2015-12-24 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10470#issuecomment-167093974 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-12409][SPARK-12387][SPARK-12391][SQL] R...

2015-12-24 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10470#issuecomment-167096779 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-12409][SPARK-12387][SPARK-12391][SQL] R...

2015-12-24 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10470#issuecomment-167096711 **[Test build #48303 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48303/consoleFull)** for PR 10470 at commit

[GitHub] spark pull request: [SPARK-12409][SPARK-12387][SPARK-12391][SQL] R...

2015-12-24 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10470#issuecomment-167093975 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-12409][SPARK-12387][SPARK-12391][SQL] R...

2015-12-24 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10470#issuecomment-167093907 **[Test build #48302 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48302/consoleFull)** for PR 10470 at commit

[GitHub] spark pull request: [SPARK-12409][SPARK-12387][SPARK-12391][SQL] R...

2015-12-24 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10470#issuecomment-167079490 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-12409][SPARK-12387][SPARK-12391][SQL] R...

2015-12-24 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10470#issuecomment-167079488 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-12409][SPARK-12387][SPARK-12391][SQL] R...

2015-12-24 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10470#issuecomment-167081200 **[Test build #48303 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48303/consoleFull)** for PR 10470 at commit

[GitHub] spark pull request: [SPARK-12409][SPARK-12387][SPARK-12391][SQL] R...

2015-12-24 Thread viirya
Github user viirya commented on the pull request: https://github.com/apache/spark/pull/10470#issuecomment-167079820 retest this please. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request: [SPARK-12409][SPARK-12387][SPARK-12391][SQL] R...

2015-12-24 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10470#issuecomment-167096777 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your