Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/10399
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is ena
Github user marmbrus commented on the pull request:
https://github.com/apache/spark/pull/10399#issuecomment-201433854
Thanks, merging to master.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not hav
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10399#issuecomment-201115171
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10399#issuecomment-201115174
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10399#issuecomment-201114615
**[Test build #54128 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54128/consoleFull)**
for PR 10399 at commit
[`ea36aeb`](https://g
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/10399#discussion_r57414237
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/encoders/RowEncoder.scala
---
@@ -137,6 +137,15 @@ object RowEncoder {
Creat
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10399#issuecomment-201087622
**[Test build #54128 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54128/consoleFull)**
for PR 10399 at commit
[`ea36aeb`](https://gi
Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/10399#discussion_r57371475
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/encoders/RowEncoder.scala
---
@@ -137,6 +137,15 @@ object RowEncoder {
Cre
Github user viirya commented on the pull request:
https://github.com/apache/spark/pull/10399#issuecomment-200662936
ping @marmbrus please let me know if this is ok for you now, thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on Git
Github user cloud-fan commented on the pull request:
https://github.com/apache/spark/pull/10399#issuecomment-200192093
cc @marmbrus for final sign off.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10399#issuecomment-200191181
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10399#issuecomment-200191182
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10399#issuecomment-200191047
**[Test build #53885 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/53885/consoleFull)**
for PR 10399 at commit
[`de22b50`](https://g
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10399#issuecomment-200159474
**[Test build #53885 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/53885/consoleFull)**
for PR 10399 at commit
[`de22b50`](https://gi
Github user viirya commented on the pull request:
https://github.com/apache/spark/pull/10399#issuecomment-200156611
retest this please.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this fe
Github user viirya commented on the pull request:
https://github.com/apache/spark/pull/10399#issuecomment-200156524
the test is passed locally.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10399#issuecomment-200154514
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10399#issuecomment-200154511
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10399#issuecomment-200154143
**[Test build #53844 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/53844/consoleFull)**
for PR 10399 at commit
[`9781676`](https://g
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10399#issuecomment-200143355
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10399#issuecomment-200143359
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10399#issuecomment-200143221
**[Test build #53859 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/53859/consoleFull)**
for PR 10399 at commit
[`de22b50`](https://g
Github user viirya commented on the pull request:
https://github.com/apache/spark/pull/10399#issuecomment-200134726
@cloud-fan @marmbrus @rxin Thanks for reviewing this!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user cloud-fan commented on the pull request:
https://github.com/apache/spark/pull/10399#issuecomment-200121599
LGTM pending tests
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10399#issuecomment-200099751
**[Test build #53859 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/53859/consoleFull)**
for PR 10399 at commit
[`de22b50`](https://gi
Github user cloud-fan commented on the pull request:
https://github.com/apache/spark/pull/10399#issuecomment-200086536
LGTM except one document comment, thanks for working on it!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/10399#discussion_r57090633
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/encoders/RowEncoder.scala
---
@@ -137,6 +137,22 @@ object RowEncoder {
Cr
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10399#issuecomment-200080402
**[Test build #53844 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/53844/consoleFull)**
for PR 10399 at commit
[`9781676`](https://gi
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/10399#discussion_r57087767
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/types/Decimal.scala ---
@@ -376,6 +376,17 @@ object Decimal {
def apply(value: String)
Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/10399#discussion_r57087306
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/types/Decimal.scala ---
@@ -376,6 +376,17 @@ object Decimal {
def apply(value: Strin
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/10399#discussion_r57086648
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/types/Decimal.scala ---
@@ -376,6 +376,17 @@ object Decimal {
def apply(value: String)
Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/10399#discussion_r57026144
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/encoders/RowEncoder.scala
---
@@ -137,6 +137,22 @@ object RowEncoder {
Cre
Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/10399#discussion_r57026000
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/types/Decimal.scala ---
@@ -376,6 +376,17 @@ object Decimal {
def apply(value: Strin
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10399#issuecomment-199904445
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10399#issuecomment-199904449
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10399#issuecomment-199903777
**[Test build #53779 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/53779/consoleFull)**
for PR 10399 at commit
[`e4a153c`](https://g
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/10399#discussion_r57005024
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/types/Decimal.scala ---
@@ -376,6 +376,17 @@ object Decimal {
def apply(value: Stri
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10399#issuecomment-199861159
**[Test build #53779 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/53779/consoleFull)**
for PR 10399 at commit
[`e4a153c`](https://gi
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/10399#discussion_r57004672
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/encoders/RowEncoder.scala
---
@@ -137,6 +137,22 @@ object RowEncoder {
Cr
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/10399#discussion_r57003322
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/encoders/RowEncoder.scala
---
@@ -142,7 +142,9 @@ object RowEncoder {
case Calen
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/10399#discussion_r57003139
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/encoders/RowEncoder.scala
---
@@ -142,7 +142,9 @@ object RowEncoder {
case Calen
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/10399#discussion_r57001947
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/encoders/RowEncoder.scala
---
@@ -142,7 +142,9 @@ object RowEncoder {
case Ca
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10399#issuecomment-199851462
**[Test build #53772 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/53772/consoleFull)**
for PR 10399 at commit
[`e1ac393`](https://g
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10399#issuecomment-199851529
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10399#issuecomment-199851534
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10399#issuecomment-199833153
**[Test build #53772 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/53772/consoleFull)**
for PR 10399 at commit
[`e1ac393`](https://gi
Github user viirya commented on the pull request:
https://github.com/apache/spark/pull/10399#issuecomment-199744291
@cloud-fan Sounds reasonable. Let me try it. Thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If y
Github user cloud-fan commented on the pull request:
https://github.com/apache/spark/pull/10399#issuecomment-199727758
> We can't bind `DecimalType` to two different types
Agree, but we can work around it by using `Object` as the external type for
`DecimalType`, and add comments to
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10399#issuecomment-199721386
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10399#issuecomment-199721379
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10399#issuecomment-199720821
**[Test build #53760 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/53760/consoleFull)**
for PR 10399 at commit
[`5e41f6d`](https://g
Github user viirya commented on the pull request:
https://github.com/apache/spark/pull/10399#issuecomment-199706699
I did originally have the same idea. However, it can't. Because for each
field in a external row, `Invoke(inputObject, method,
externalDataTypeFor(f.dataType)` will be c
Github user cloud-fan commented on the pull request:
https://github.com/apache/spark/pull/10399#issuecomment-199705190
Maybe I missed something, can't we simply add a `Decimal.apply(d: Decimal):
Decimal = d` to fix it?
---
If your project is set up for it, you can reply to this email
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10399#issuecomment-199694015
**[Test build #53760 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/53760/consoleFull)**
for PR 10399 at commit
[`5e41f6d`](https://gi
Github user viirya commented on the pull request:
https://github.com/apache/spark/pull/10399#issuecomment-199693170
Because `externalDataTypeFor` is already binded `DecimalType` to
`java.math.BigDecimal`. Changing `RowEncoder.extractorsFor` can't make
RowEncoder support Decimal in ext
Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/10399#issuecomment-199662498
That's fine. We just want to support the inbound.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user viirya commented on the pull request:
https://github.com/apache/spark/pull/10399#issuecomment-199659351
@cloud-fan @rxin Yeah, but when we do construction, we will generate a Java
BigDecimal back to external row. Because `constructorFor` is binded DecimalType
to that exter
Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/10399#issuecomment-199637564
Yea that's a good idea.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user cloud-fan commented on the pull request:
https://github.com/apache/spark/pull/10399#issuecomment-199627097
Should we also handle `Decimal` inside external row? i.e. improve
`RowEncoder.extractorsFor` to accept `Decimal` also.
---
If your project is set up for it, you can
Github user viirya commented on the pull request:
https://github.com/apache/spark/pull/10399#issuecomment-199622408
@rxin tests passed. Anymore change I should make to this?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10399#issuecomment-199603691
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10399#issuecomment-199603689
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10399#issuecomment-199603543
**[Test build #53733 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/53733/consoleFull)**
for PR 10399 at commit
[`c29c04d`](https://g
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10399#issuecomment-199569588
**[Test build #53733 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/53733/consoleFull)**
for PR 10399 at commit
[`c29c04d`](https://gi
GitHub user viirya reopened a pull request:
https://github.com/apache/spark/pull/10399
[SPARK-12443][SQL] encoderFor should support Decimal
JIRA: https://issues.apache.org/jira/browse/SPARK-12443
`constructorFor` will call `dataTypeFor` to determine if a type is
`ObjectType
Github user viirya commented on the pull request:
https://github.com/apache/spark/pull/10399#issuecomment-199567539
@rxin ok.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enab
Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/10399#issuecomment-199441347
Can you re-open this and bring it up-to-date?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your proj
Github user viirya closed the pull request at:
https://github.com/apache/spark/pull/10399
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is ena
Github user viirya commented on the pull request:
https://github.com/apache/spark/pull/10399#issuecomment-191033904
Let me close this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this fea
Github user marmbrus commented on the pull request:
https://github.com/apache/spark/pull/10399#issuecomment-171500755
I don't think we should make it easier to use decimal until we review its
API. It was intended to be internal.
---
If your project is set up for it, you can reply to
Github user viirya commented on the pull request:
https://github.com/apache/spark/pull/10399#issuecomment-171169128
ping @rxin @JoshRosen
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user viirya commented on the pull request:
https://github.com/apache/spark/pull/10399#issuecomment-170608133
@rxin @JoshRosen Please see if this patch is ok for you. Thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub a
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10399#issuecomment-170594661
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10399#issuecomment-170594658
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10399#issuecomment-170594041
**[Test build #49145 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/49145/consoleFull)**
for PR 10399 at commit
[`ed90585`](https://g
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10399#issuecomment-170562802
**[Test build #49145 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/49145/consoleFull)**
for PR 10399 at commit
[`ed90585`](https://gi
Github user viirya commented on the pull request:
https://github.com/apache/spark/pull/10399#issuecomment-170558313
retest this please.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this fe
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10399#issuecomment-170543092
**[Test build #49123 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/49123/consoleFull)**
for PR 10399 at commit
[`ed90585`](https://g
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10399#issuecomment-170543249
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10399#issuecomment-170543254
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10399#issuecomment-170472667
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10399#issuecomment-170472668
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10399#issuecomment-170472621
**[Test build #49110 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/49110/consoleFull)**
for PR 10399 at commit
[`ed90585`](https://g
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10399#issuecomment-170471822
**[Test build #49123 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/49123/consoleFull)**
for PR 10399 at commit
[`ed90585`](https://gi
Github user JoshRosen commented on the pull request:
https://github.com/apache/spark/pull/10399#issuecomment-170468918
Jenkins, retest this please.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10399#issuecomment-170461972
**[Test build #49110 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/49110/consoleFull)**
for PR 10399 at commit
[`ed90585`](https://gi
Github user viirya commented on the pull request:
https://github.com/apache/spark/pull/10399#issuecomment-170461453
ping @rxin
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
en
Github user viirya commented on the pull request:
https://github.com/apache/spark/pull/10399#issuecomment-167702564
@rxin Could you check this? Thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user cloud-fan commented on the pull request:
https://github.com/apache/spark/pull/10399#issuecomment-166469934
Unfortunately, `Decimal` is not private and we may leak it to users
already. cc @rxin
---
If your project is set up for it, you can reply to this email and have you
Github user marmbrus commented on the pull request:
https://github.com/apache/spark/pull/10399#issuecomment-166403849
Decimal is a private class. We should not expose it to users until we have
audited the API.
---
If your project is set up for it, you can reply to this email and hav
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10399#issuecomment-166249728
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10399#issuecomment-166249726
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10399#issuecomment-166249431
**[Test build #48102 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48102/consoleFull)**
for PR 10399 at commit
[`2875a5f`](https://g
Github user cloud-fan commented on the pull request:
https://github.com/apache/spark/pull/10399#issuecomment-166232236
LGTM, pending tests.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have thi
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10399#issuecomment-166228900
**[Test build #48102 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48102/consoleFull)**
for PR 10399 at commit
[`2875a5f`](https://gi
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/10399#discussion_r48114340
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/ScalaReflectionRelationSuite.scala
---
@@ -138,4 +144,16 @@ class ScalaReflectionRelationSuite exte
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/10399#discussion_r48114262
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/ScalaReflection.scala
---
@@ -61,6 +61,7 @@ object ScalaReflection extends ScalaReflec
Github user viirya commented on the pull request:
https://github.com/apache/spark/pull/10399#issuecomment-166181467
cc @cloud-fan @marmbrus @davies
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10399#issuecomment-166129568
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10399#issuecomment-166129529
**[Test build #48073 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48073/consoleFull)**
for PR 10399 at commit
[`6afb1a4`](https://g
1 - 100 of 103 matches
Mail list logo
