[GitHub] spark pull request: [SPARK-12453][Streaming] Remove explicit depen...

2016-01-05 Thread srowen
Github user srowen commented on the pull request: https://github.com/apache/spark/pull/10492#issuecomment-169166570 Merged to master/1.6/1.5. I'll keep an eye on the 1.5 build to make sure that cherry pick still worked OK. --- If your project is set up for it, you can reply to this e

[GitHub] spark pull request: [SPARK-12453][Streaming] Remove explicit depen...

2016-01-05 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/10492 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is ena

[GitHub] spark pull request: [SPARK-12453][Streaming] Remove explicit depen...

2016-01-05 Thread BrianLondon
Github user BrianLondon commented on the pull request: https://github.com/apache/spark/pull/10492#issuecomment-169164791 Sounds good to me. Once done, I'll rebase 12269 and reopen that discussion. --- If your project is set up for it, you can reply to this email and have your reply a

[GitHub] spark pull request: [SPARK-12453][Streaming] Remove explicit depen...

2016-01-05 Thread srowen
Github user srowen commented on the pull request: https://github.com/apache/spark/pull/10492#issuecomment-168958835 Given the discussion here, I'm pretty confident in this change and would like to go ahead and merge it. It will also unblock further fixes in 12269. --- If your project

[GitHub] spark pull request: [SPARK-12453][Streaming] Remove explicit depen...

2016-01-04 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10492#issuecomment-168752808 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/

[GitHub] spark pull request: [SPARK-12453][Streaming] Remove explicit depen...

2016-01-04 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10492#issuecomment-168752806 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] spark pull request: [SPARK-12453][Streaming] Remove explicit depen...

2016-01-04 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10492#issuecomment-168752644 **[Test build #48668 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48668/consoleFull)** for PR 10492 at commit [`137bafd`](https://g

[GitHub] spark pull request: [SPARK-12453][Streaming] Remove explicit depen...

2016-01-04 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10492#issuecomment-168742194 **[Test build #48668 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48668/consoleFull)** for PR 10492 at commit [`137bafd`](https://gi

[GitHub] spark pull request: [SPARK-12453][Streaming] Remove explicit depen...

2016-01-04 Thread JoshRosen
Github user JoshRosen commented on the pull request: https://github.com/apache/spark/pull/10492#issuecomment-168738742 Jenkins, retest this please. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-12453][Streaming] Remove explicit depen...

2016-01-04 Thread BrianLondon
Github user BrianLondon commented on the pull request: https://github.com/apache/spark/pull/10492#issuecomment-168704102 @srowen space removed. Thanks. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] spark pull request: [SPARK-12453][Streaming] Remove explicit depen...

2016-01-02 Thread srowen
Github user srowen commented on the pull request: https://github.com/apache/spark/pull/10492#issuecomment-168381598 @JoshRosen are you OK with the reasoning above? @BrianLondon sorry but the style checker doesn't like the white space on the blank line you added to trigger tests :(.

[GitHub] spark pull request: [SPARK-12453][Streaming] Remove explicit depen...

2015-12-30 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10492#issuecomment-168075091 **[Test build #2270 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2270/consoleFull)** for PR 10492 at commit [`8e80f5e`](https://

[GitHub] spark pull request: [SPARK-12453][Streaming] Remove explicit depen...

2015-12-30 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10492#issuecomment-168073660 **[Test build #2270 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2270/consoleFull)** for PR 10492 at commit [`8e80f5e`](https://g

[GitHub] spark pull request: [SPARK-12453][Streaming] Remove explicit depen...

2015-12-28 Thread srowen
Github user srowen commented on the pull request: https://github.com/apache/spark/pull/10492#issuecomment-167543175 @JoshRosen it's not the scope that's an issue but the version. Not specifying it lets the SDK version required by the Kinesis client come in at whatever it needs to be.

[GitHub] spark pull request: [SPARK-12453][Streaming] Remove explicit depen...

2015-12-27 Thread JoshRosen
Github user JoshRosen commented on the pull request: https://github.com/apache/spark/pull/10492#issuecomment-167486919 Instead of just omitting the dependency, what about marking it as provided? --- If your project is set up for it, you can reply to this email and have your reply appe

[GitHub] spark pull request: [SPARK-12453][Streaming] Remove explicit depen...

2015-12-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10492#issuecomment-167480578 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your p

[GitHub] spark pull request: [SPARK-12453][Streaming] Remove explicit depen...

2015-12-27 Thread BrianLondon
GitHub user BrianLondon opened a pull request: https://github.com/apache/spark/pull/10492 [SPARK-12453][Streaming] Remove explicit dependency on aws-java-sdk Successfully ran kinesis demo on a live, aws hosted kinesis stream against master and 1.6 branches. For reasons I don't enti