Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10427#issuecomment-181786940
**[Test build #50968 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50968/consoleFull)**
for PR 10427 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10427#issuecomment-181786010
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10427#issuecomment-181786009
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10427#issuecomment-181817385
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10427#issuecomment-181817384
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10427#issuecomment-181817281
**[Test build #50968 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50968/consoleFull)**
for PR 10427 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10427#issuecomment-181904428
**[Test build #50976 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50976/consoleFull)**
for PR 10427 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10427#issuecomment-181937545
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10427#issuecomment-181937547
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10427#issuecomment-181937219
**[Test build #50976 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50976/consoleFull)**
for PR 10427 at commit
Github user maropu commented on the pull request:
https://github.com/apache/spark/pull/10427#issuecomment-182160420
@yhuai okay, ready to commit.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user yhuai commented on the pull request:
https://github.com/apache/spark/pull/10427#issuecomment-182162950
LGTM. Merging to master.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/10427
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/10427#discussion_r52120299
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JDBCRelation.scala
---
@@ -90,6 +90,11 @@ private[sql] case class
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10427#issuecomment-181050301
**[Test build #50904 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50904/consoleFull)**
for PR 10427 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10427#issuecomment-181070297
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10427#issuecomment-181070296
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10427#issuecomment-181070255
**[Test build #50904 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50904/consoleFull)**
for PR 10427 at commit
Github user yhuai commented on the pull request:
https://github.com/apache/spark/pull/10427#issuecomment-181151008
Thank you for the update! Overall looks good. There are two lines of
unnecessary changes. Let's remove them and we can merge it once it passes
jenkins.
---
If your
Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/10427#discussion_r52128728
--- Diff: sql/core/src/test/scala/org/apache/spark/sql/jdbc/JDBCSuite.scala
---
@@ -210,6 +218,24 @@ class JDBCSuite extends SparkFunSuite
val df2 =
Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/10427#discussion_r52128717
--- Diff: sql/core/src/test/scala/org/apache/spark/sql/jdbc/JDBCSuite.scala
---
@@ -210,6 +218,24 @@ class JDBCSuite extends SparkFunSuite
val df2 =
Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/10427#discussion_r52110498
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JDBCRelation.scala
---
@@ -90,6 +90,11 @@ private[sql] case class
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10427#issuecomment-180388822
**[Test build #50818 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50818/consoleFull)**
for PR 10427 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10427#issuecomment-180389108
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10427#issuecomment-180389106
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/10427#discussion_r51994731
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JDBCRelation.scala
---
@@ -90,6 +90,11 @@ private[sql] case class
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10427#issuecomment-180359628
**[Test build #50818 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50818/consoleFull)**
for PR 10427 at commit
Github user maropu commented on the pull request:
https://github.com/apache/spark/pull/10427#issuecomment-180354486
@yhuai fixed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user maropu commented on the pull request:
https://github.com/apache/spark/pull/10427#issuecomment-180237461
@yhuai ping
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user maropu commented on the pull request:
https://github.com/apache/spark/pull/10427#issuecomment-178372154
@yhuai ping
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user maropu commented on the pull request:
https://github.com/apache/spark/pull/10427#issuecomment-175997712
@yhuai ping
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user maropu commented on the pull request:
https://github.com/apache/spark/pull/10427#issuecomment-173552368
@yhuai ping
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10427#issuecomment-171631018
**[Test build #49397 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/49397/consoleFull)**
for PR 10427 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10427#issuecomment-171651804
**[Test build #49397 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/49397/consoleFull)**
for PR 10427 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10427#issuecomment-171652041
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10427#issuecomment-171652043
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user maropu commented on the pull request:
https://github.com/apache/spark/pull/10427#issuecomment-171544801
@yhuai ping
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user maropu commented on the pull request:
https://github.com/apache/spark/pull/10427#issuecomment-168651319
@yuhai Oh... my bad :(( Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user maropu commented on the pull request:
https://github.com/apache/spark/pull/10427#issuecomment-168618638
@yuhai Could you review it?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user yuhai commented on the pull request:
https://github.com/apache/spark/pull/10427#issuecomment-168620757
Hi Takeshi,
You should cc wrong address. :)
@yhuai
Thanks,
Hai
---
If your project is set up for it, you can reply to this email and have
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10427#issuecomment-168881340
**[Test build #48705 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48705/consoleFull)**
for PR 10427 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10427#issuecomment-168865004
**[Test build #48705 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48705/consoleFull)**
for PR 10427 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10427#issuecomment-168881503
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10427#issuecomment-168881502
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10427#issuecomment-168714566
**[Test build #48666 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48666/consoleFull)**
for PR 10427 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10427#issuecomment-168715759
**[Test build #48666 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48666/consoleFull)**
for PR 10427 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10427#issuecomment-168715769
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10427#issuecomment-168715766
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10427#issuecomment-167071998
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10427#issuecomment-167072000
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10427#issuecomment-167071782
**[Test build #48293 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48293/consoleFull)**
for PR 10427 at commit
Github user HyukjinKwon commented on the pull request:
https://github.com/apache/spark/pull/10427#issuecomment-167017518
Let me leave a comment. I tested some cases with this PR and looks
generally working fine. But I would like to mention one thing that I am pretty
sure you guys
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/10427#discussion_r48391917
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JDBCRelation.scala
---
@@ -90,6 +90,11 @@ private[sql] case class
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10427#issuecomment-167026635
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user HyukjinKwon commented on the pull request:
https://github.com/apache/spark/pull/10427#issuecomment-167033198
retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10427#issuecomment-167035311
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user maropu commented on the pull request:
https://github.com/apache/spark/pull/10427#issuecomment-167039229
@HyukjinKwon ISTM the root problem is that catalyst cannot fill required
columns on-the-fly for data sources. `unhandleFilters` is little related to the
problem.
---
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10427#issuecomment-167026636
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10427#issuecomment-167035310
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user maropu commented on the pull request:
https://github.com/apache/spark/pull/10427#issuecomment-167039831
If this patch merged, the comment below is not suitable for `JDBCRelation`.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10427#issuecomment-167025712
**[Test build #48277 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48277/consoleFull)**
for PR 10427 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10427#issuecomment-167037407
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10427#issuecomment-167037408
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10427#issuecomment-167037362
**[Test build #48277 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48277/consoleFull)**
for PR 10427 at commit
Github user HyukjinKwon commented on the pull request:
https://github.com/apache/spark/pull/10427#issuecomment-167040023
And you are right I think the comments I said is not related with this PR.
Let's wait for their comments!
---
If your project is set up for it, you can reply to
Github user HyukjinKwon commented on the pull request:
https://github.com/apache/spark/pull/10427#issuecomment-167039644
@maropu I believe it is a Parquet stuff. AFAIK, the columns in filters
should be set to `requestedSchema` for Parquet. But
Github user maropu commented on the pull request:
https://github.com/apache/spark/pull/10427#issuecomment-167042101
Adding a special handing for Parquet is better? I think that required
columns for push-down filters should be passed to each data sources, and this
is a more natural
Github user HyukjinKwon commented on the pull request:
https://github.com/apache/spark/pull/10427#issuecomment-167044200
@maropu I agree that can be another way! but I just think an interface
should be inclusive not exclusive. Handing in `ParquetRelation` might mean
other datasources
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10427#issuecomment-167051327
**[Test build #48290 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48290/consoleFull)**
for PR 10427 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10427#issuecomment-167063911
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10427#issuecomment-167063910
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10427#issuecomment-167046672
**[Test build #48287 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48287/consoleFull)**
for PR 10427 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10427#issuecomment-167060472
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10427#issuecomment-167060473
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10427#issuecomment-167060381
**[Test build #48287 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48287/consoleFull)**
for PR 10427 at commit
Github user maropu commented on the pull request:
https://github.com/apache/spark/pull/10427#issuecomment-167045790
@HyukjinKwon Anyway, I added a test by reflecting this discussion. thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10427#issuecomment-167060213
**[Test build #48293 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48293/consoleFull)**
for PR 10427 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10427#issuecomment-167063848
**[Test build #48290 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48290/consoleFull)**
for PR 10427 at commit
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/10427#discussion_r48261569
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JDBCRelation.scala
---
@@ -90,6 +90,21 @@ private[sql] case class
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10427#issuecomment-166645536
**[Test build #48201 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48201/consoleFull)**
for PR 10427 at commit
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/10427#discussion_r48313071
--- Diff: sql/core/src/test/scala/org/apache/spark/sql/jdbc/JDBCSuite.scala
---
@@ -180,14 +181,23 @@ class JDBCSuite extends SparkFunSuite
}
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/10427#discussion_r48242420
--- Diff: sql/core/src/test/scala/org/apache/spark/sql/jdbc/JDBCSuite.scala
---
@@ -176,14 +178,23 @@ class JDBCSuite extends SparkFunSuite with
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/10427#discussion_r48242446
--- Diff: sql/core/src/test/scala/org/apache/spark/sql/jdbc/JDBCSuite.scala
---
@@ -176,14 +178,23 @@ class JDBCSuite extends SparkFunSuite with
Github user HyukjinKwon commented on the pull request:
https://github.com/apache/spark/pull/10427#issuecomment-166588013
@liancheng would you tell me what you think on
[this](https://github.com/apache/spark/pull/10427#discussion_r48231701)? I made
some commits locally and want to be
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/10427#discussion_r48231102
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JDBCRelation.scala
---
@@ -90,6 +90,19 @@ private[sql] case class
Github user HyukjinKwon commented on the pull request:
https://github.com/apache/spark/pull/10427#issuecomment-166568408
cc @liancheng @yhuai
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/10427#discussion_r48243182
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JDBCRelation.scala
---
@@ -90,6 +90,21 @@ private[sql] case class
Github user HyukjinKwon commented on the pull request:
https://github.com/apache/spark/pull/10427#issuecomment-166570264
cc @liancheng @yhuai
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/10427#discussion_r48237984
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JDBCRelation.scala
---
@@ -90,6 +90,19 @@ private[sql] case class
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/10427#discussion_r48242522
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JDBCRelation.scala
---
@@ -90,6 +90,19 @@ private[sql] case class
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/10427#discussion_r48242480
--- Diff: sql/core/src/test/scala/org/apache/spark/sql/jdbc/JDBCSuite.scala
---
@@ -176,14 +178,23 @@ class JDBCSuite extends SparkFunSuite with
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/10427#discussion_r48242805
--- Diff: sql/core/src/test/scala/org/apache/spark/sql/jdbc/JDBCSuite.scala
---
@@ -180,14 +181,23 @@ class JDBCSuite extends SparkFunSuite
}
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10427#issuecomment-166581827
**[Test build #48188 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48188/consoleFull)**
for PR 10427 at commit
Github user HyukjinKwon commented on the pull request:
https://github.com/apache/spark/pull/10427#issuecomment-166587134
@liancheng Would you tell me what you think on
[this](https://github.com/apache/spark/pull/10427#discussion_r48231701)? I made
some commits locally but want to be
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/10427#discussion_r48236730
--- Diff: sql/core/src/test/scala/org/apache/spark/sql/jdbc/JDBCSuite.scala
---
@@ -176,14 +178,23 @@ class JDBCSuite extends SparkFunSuite with
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10427#issuecomment-166579538
**[Test build #48187 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48187/consoleFull)**
for PR 10427 at commit
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/10427#discussion_r48243987
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JDBCRelation.scala
---
@@ -90,6 +90,19 @@ private[sql] case class
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/10427#discussion_r48229951
--- Diff: sql/core/src/test/scala/org/apache/spark/sql/jdbc/JDBCSuite.scala
---
@@ -176,14 +178,23 @@ class JDBCSuite extends SparkFunSuite with
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/10427#discussion_r48230062
--- Diff: sql/core/src/test/scala/org/apache/spark/sql/jdbc/JDBCSuite.scala
---
@@ -176,14 +178,23 @@ class JDBCSuite extends SparkFunSuite with
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/10427#discussion_r48231701
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JDBCRelation.scala
---
@@ -90,6 +90,19 @@ private[sql] case class
1 - 100 of 127 matches
Mail list logo
