[GitHub] spark pull request: [SPARK-12480][SQL] add Hash expression that ca...

2016-01-05 Thread tedyu
Github user tedyu commented on a diff in the pull request: https://github.com/apache/spark/pull/10435#discussion_r48869485 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/functions.scala --- @@ -1863,6 +1863,17 @@ object functions extends LegacyFunctions { */

[GitHub] spark pull request: [SPARK-12480][SQL] add Hash expression that ca...

2016-01-04 Thread nongli
Github user nongli commented on the pull request: https://github.com/apache/spark/pull/10435#issuecomment-168801707 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] spark pull request: [SPARK-12480][SQL] add Hash expression that ca...

2016-01-04 Thread nongli
Github user nongli commented on a diff in the pull request: https://github.com/apache/spark/pull/10435#discussion_r48778819 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/misc.scala --- @@ -177,3 +179,44 @@ case class Crc32(child: Expression)

[GitHub] spark pull request: [SPARK-12480][SQL] add Hash expression that ca...

2016-01-04 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10435#issuecomment-168614902 **[Test build #48644 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48644/consoleFull)** for PR 10435 at commit

[GitHub] spark pull request: [SPARK-12480][SQL] add Hash expression that ca...

2016-01-04 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10435#issuecomment-168614906 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-12480][SQL] add Hash expression that ca...

2016-01-04 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10435#issuecomment-168614909 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-12480][SQL] add Hash expression that ca...

2016-01-04 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10435#issuecomment-168652917 **[Test build #48656 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48656/consoleFull)** for PR 10435 at commit

[GitHub] spark pull request: [SPARK-12480][SQL] add Hash expression that ca...

2016-01-04 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10435#issuecomment-168614140 **[Test build #48644 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48644/consoleFull)** for PR 10435 at commit

[GitHub] spark pull request: [SPARK-12480][SQL] add Hash expression that ca...

2016-01-04 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/10435#discussion_r48808255 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/functions.scala --- @@ -1863,6 +1863,17 @@ object functions extends LegacyFunctions { */

[GitHub] spark pull request: [SPARK-12480][SQL] add Hash expression that ca...

2016-01-04 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/10435#issuecomment-168877190 I've merged this. You can address the API comment in the next pull request. Thanks. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] spark pull request: [SPARK-12480][SQL] add Hash expression that ca...

2016-01-04 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/10435#discussion_r48808153 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/functions.scala --- @@ -1863,6 +1863,17 @@ object functions extends LegacyFunctions { */

[GitHub] spark pull request: [SPARK-12480][SQL] add Hash expression that ca...

2016-01-04 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10435#issuecomment-168856535 **[Test build #48699 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48699/consoleFull)** for PR 10435 at commit

[GitHub] spark pull request: [SPARK-12480][SQL] add Hash expression that ca...

2016-01-04 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10435#issuecomment-168876234 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-12480][SQL] add Hash expression that ca...

2016-01-04 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10435#issuecomment-168876055 **[Test build #48699 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48699/consoleFull)** for PR 10435 at commit

[GitHub] spark pull request: [SPARK-12480][SQL] add Hash expression that ca...

2016-01-04 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10435#issuecomment-168876233 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-12480][SQL] add Hash expression that ca...

2016-01-04 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/10435 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: [SPARK-12480][SQL] add Hash expression that ca...

2016-01-04 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10435#issuecomment-168674438 **[Test build #48656 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48656/consoleFull)** for PR 10435 at commit

[GitHub] spark pull request: [SPARK-12480][SQL] add Hash expression that ca...

2016-01-04 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10435#issuecomment-168674649 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-12480][SQL] add Hash expression that ca...

2016-01-04 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10435#issuecomment-168674651 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-12480][SQL] add Hash expression that ca...

2016-01-04 Thread cloud-fan
Github user cloud-fan commented on the pull request: https://github.com/apache/spark/pull/10435#issuecomment-168700418 I think we should open another PR to use this hash expression in `Exchange`, as it will break a lof of tests and make it harder to review. --- If your project is

[GitHub] spark pull request: [SPARK-12480][SQL] add Hash expression that ca...

2016-01-03 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/10435#discussion_r48705398 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/FunctionRegistry.scala --- @@ -278,6 +278,7 @@ object FunctionRegistry {

[GitHub] spark pull request: [SPARK-12480][SQL] add Hash expression that ca...

2016-01-03 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/10435#discussion_r48703350 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/FunctionRegistry.scala --- @@ -278,6 +278,7 @@ object FunctionRegistry {

[GitHub] spark pull request: [SPARK-12480][SQL] add Hash expression that ca...

2016-01-03 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/10435#discussion_r48705356 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/FunctionRegistry.scala --- @@ -278,6 +278,7 @@ object FunctionRegistry {

[GitHub] spark pull request: [SPARK-12480][SQL] add Hash expression that ca...

2016-01-01 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/10435#discussion_r48676826 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/FunctionRegistry.scala --- @@ -278,6 +278,7 @@ object FunctionRegistry {

[GitHub] spark pull request: [SPARK-12480][SQL] add Hash expression that ca...

2015-12-30 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10435#issuecomment-168125552 **[Test build #48542 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48542/consoleFull)** for PR 10435 at commit

[GitHub] spark pull request: [SPARK-12480][SQL] add Hash expression that ca...

2015-12-30 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10435#issuecomment-168134147 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-12480][SQL] add Hash expression that ca...

2015-12-30 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10435#issuecomment-168134146 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-12480][SQL] add Hash expression that ca...

2015-12-30 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10435#issuecomment-168123375 **[Test build #48540 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48540/consoleFull)** for PR 10435 at commit

[GitHub] spark pull request: [SPARK-12480][SQL] add Hash expression that ca...

2015-12-30 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/10435#discussion_r48646962 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/FunctionRegistry.scala --- @@ -278,6 +278,7 @@ object FunctionRegistry {

[GitHub] spark pull request: [SPARK-12480][SQL] add Hash expression that ca...

2015-12-30 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/10435#discussion_r48646170 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/FunctionRegistry.scala --- @@ -278,6 +278,7 @@ object FunctionRegistry {

[GitHub] spark pull request: [SPARK-12480][SQL] add Hash expression that ca...

2015-12-30 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10435#issuecomment-168128676 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-12480][SQL] add Hash expression that ca...

2015-12-30 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10435#issuecomment-168128648 **[Test build #48540 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48540/consoleFull)** for PR 10435 at commit

[GitHub] spark pull request: [SPARK-12480][SQL] add Hash expression that ca...

2015-12-30 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10435#issuecomment-168128675 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-12480][SQL] add Hash expression that ca...

2015-12-30 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/10435#discussion_r48646183 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/misc.scala --- @@ -177,3 +179,44 @@ case class Crc32(child: Expression)

[GitHub] spark pull request: [SPARK-12480][SQL] add Hash expression that ca...

2015-12-30 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/10435#discussion_r48646861 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/FunctionRegistry.scala --- @@ -278,6 +278,7 @@ object FunctionRegistry {

[GitHub] spark pull request: [SPARK-12480][SQL] add Hash expression that ca...

2015-12-30 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/10435#issuecomment-168047956 On the contrary I think we should consider not using hash code on an object, and always use hash code expression for two reasons: 1. We still need a hash function

[GitHub] spark pull request: [SPARK-12480][SQL] add Hash expression that ca...

2015-12-30 Thread nongli
Github user nongli commented on the pull request: https://github.com/apache/spark/pull/10435#issuecomment-168072275 It makes sense to still have a Hash expression (called more specifically, Mumur3Hash) that does what this patch originally intended. I think this will be a useful

[GitHub] spark pull request: [SPARK-12480][SQL] add Hash expression that ca...

2015-12-30 Thread cloud-fan
GitHub user cloud-fan reopened a pull request: https://github.com/apache/spark/pull/10435 [SPARK-12480][SQL] add Hash expression that can calculate hash value for a group of expressions The hash algorithm is based on

[GitHub] spark pull request: [SPARK-12480][SQL] add Hash expression that ca...

2015-12-30 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10435#issuecomment-168134068 **[Test build #48542 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48542/consoleFull)** for PR 10435 at commit

[GitHub] spark pull request: [SPARK-12480][SQL] add Hash expression that ca...

2015-12-30 Thread cloud-fan
Github user cloud-fan commented on the pull request: https://github.com/apache/spark/pull/10435#issuecomment-168017519 Closing, will open another PR to use `UnsafeRow.hashCode` for shuffle and fix tests. --- If your project is set up for it, you can reply to this email and have your

[GitHub] spark pull request: [SPARK-12480][SQL] add Hash expression that ca...

2015-12-30 Thread cloud-fan
Github user cloud-fan closed the pull request at: https://github.com/apache/spark/pull/10435 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: [SPARK-12480][SQL] add Hash expression that ca...

2015-12-29 Thread yhuai
Github user yhuai commented on a diff in the pull request: https://github.com/apache/spark/pull/10435#discussion_r48554681 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/misc.scala --- @@ -176,3 +179,223 @@ case class Crc32(child: Expression)

[GitHub] spark pull request: [SPARK-12480][SQL] add Hash expression that ca...

2015-12-29 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10435#issuecomment-167918200 **[Test build #48442 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48442/consoleFull)** for PR 10435 at commit

[GitHub] spark pull request: [SPARK-12480][SQL] add Hash expression that ca...

2015-12-29 Thread nongli
Github user nongli commented on a diff in the pull request: https://github.com/apache/spark/pull/10435#discussion_r48588221 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/misc.scala --- @@ -176,3 +179,229 @@ case class Crc32(child: Expression)

[GitHub] spark pull request: [SPARK-12480][SQL] add Hash expression that ca...

2015-12-29 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/10435#discussion_r48589312 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/misc.scala --- @@ -176,3 +179,229 @@ case class Crc32(child: Expression)

[GitHub] spark pull request: [SPARK-12480][SQL] add Hash expression that ca...

2015-12-29 Thread nongli
Github user nongli commented on a diff in the pull request: https://github.com/apache/spark/pull/10435#discussion_r48587902 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/misc.scala --- @@ -176,3 +179,229 @@ case class Crc32(child: Expression)

[GitHub] spark pull request: [SPARK-12480][SQL] add Hash expression that ca...

2015-12-29 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10435#issuecomment-167932291 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-12480][SQL] add Hash expression that ca...

2015-12-29 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10435#issuecomment-167932253 **[Test build #48442 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48442/consoleFull)** for PR 10435 at commit

[GitHub] spark pull request: [SPARK-12480][SQL] add Hash expression that ca...

2015-12-29 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10435#issuecomment-167932288 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-12480][SQL] add Hash expression that ca...

2015-12-29 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10435#issuecomment-167747465 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-12480][SQL] add Hash expression that ca...

2015-12-29 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10435#issuecomment-167747467 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-12480][SQL] add Hash expression that ca...

2015-12-29 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10435#issuecomment-167747137 **[Test build #48404 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48404/consoleFull)** for PR 10435 at commit

[GitHub] spark pull request: [SPARK-12480][SQL] add Hash expression that ca...

2015-12-29 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/10435#discussion_r48527967 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/misc.scala --- @@ -176,3 +179,223 @@ case class Crc32(child: Expression)

[GitHub] spark pull request: [SPARK-12480][SQL] add Hash expression that ca...

2015-12-29 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/10435#discussion_r48528123 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/misc.scala --- @@ -176,3 +179,223 @@ case class Crc32(child: Expression)

[GitHub] spark pull request: [SPARK-12480][SQL] add Hash expression that ca...

2015-12-29 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/10435#discussion_r48537829 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/misc.scala --- @@ -176,3 +179,223 @@ case class Crc32(child: Expression)

[GitHub] spark pull request: [SPARK-12480][SQL] add Hash expression that ca...

2015-12-28 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10435#issuecomment-167698232 **[Test build #48388 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48388/consoleFull)** for PR 10435 at commit

[GitHub] spark pull request: [SPARK-12480][SQL] add Hash expression that ca...

2015-12-28 Thread cloud-fan
Github user cloud-fan commented on the pull request: https://github.com/apache/spark/pull/10435#issuecomment-167583523 need some help about the R test, I can't see the expected result through the error log... --- If your project is set up for it, you can reply to this email and have

[GitHub] spark pull request: [SPARK-12480][SQL] add Hash expression that ca...

2015-12-28 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/10435#discussion_r48482588 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/misc.scala --- @@ -176,3 +178,221 @@ case class Crc32(child: Expression)

[GitHub] spark pull request: [SPARK-12480][SQL] add Hash expression that ca...

2015-12-28 Thread yhuai
Github user yhuai commented on the pull request: https://github.com/apache/spark/pull/10435#issuecomment-167614804 I see ``` 1. Failure (at test_sparkSQL.R#1160): group by, agg functions -- 30 not equal to collect(max(gd))[1, 2] 30 - 19 == 11

[GitHub] spark pull request: [SPARK-12480][SQL] add Hash expression that ca...

2015-12-28 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/10435#discussion_r48500689 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/misc.scala --- @@ -176,3 +178,221 @@ case class Crc32(child: Expression)

[GitHub] spark pull request: [SPARK-12480][SQL] add Hash expression that ca...

2015-12-28 Thread marmbrus
Github user marmbrus commented on a diff in the pull request: https://github.com/apache/spark/pull/10435#discussion_r48500881 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/misc.scala --- @@ -176,3 +178,221 @@ case class Crc32(child: Expression)

[GitHub] spark pull request: [SPARK-12480][SQL] add Hash expression that ca...

2015-12-28 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/10435#discussion_r48502287 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/misc.scala --- @@ -176,3 +178,221 @@ case class Crc32(child: Expression)

[GitHub] spark pull request: [SPARK-12480][SQL] add Hash expression that ca...

2015-12-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10435#issuecomment-167710232 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-12480][SQL] add Hash expression that ca...

2015-12-28 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10435#issuecomment-167710215 **[Test build #48388 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48388/consoleFull)** for PR 10435 at commit

[GitHub] spark pull request: [SPARK-12480][SQL] add Hash expression that ca...

2015-12-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10435#issuecomment-167710233 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-12480][SQL] add Hash expression that ca...

2015-12-28 Thread viirya
Github user viirya commented on the pull request: https://github.com/apache/spark/pull/10435#issuecomment-167713829 Actually I have already created a pr #9883 for this long time ago... --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] spark pull request: [SPARK-12480][SQL] add Hash expression that ca...

2015-12-28 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10435#issuecomment-167727788 **[Test build #48399 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48399/consoleFull)** for PR 10435 at commit

[GitHub] spark pull request: [SPARK-12480][SQL] add Hash expression that ca...

2015-12-28 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/10435#discussion_r48516214 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/misc.scala --- @@ -176,3 +178,221 @@ case class Crc32(child: Expression)

[GitHub] spark pull request: [SPARK-12480][SQL] add Hash expression that ca...

2015-12-28 Thread marmbrus
Github user marmbrus commented on a diff in the pull request: https://github.com/apache/spark/pull/10435#discussion_r48516332 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/misc.scala --- @@ -176,3 +178,221 @@ case class Crc32(child: Expression)

[GitHub] spark pull request: [SPARK-12480][SQL] add Hash expression that ca...

2015-12-28 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10435#issuecomment-167737270 **[Test build #48404 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48404/consoleFull)** for PR 10435 at commit

[GitHub] spark pull request: [SPARK-12480][SQL] add Hash expression that ca...

2015-12-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10435#issuecomment-167730354 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-12480][SQL] add Hash expression that ca...

2015-12-28 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10435#issuecomment-167730331 **[Test build #48399 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48399/consoleFull)** for PR 10435 at commit

[GitHub] spark pull request: [SPARK-12480][SQL] add Hash expression that ca...

2015-12-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10435#issuecomment-167730352 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-12480][SQL] add Hash expression that ca...

2015-12-27 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10435#issuecomment-167399420 **[Test build #48352 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48352/consoleFull)** for PR 10435 at commit

[GitHub] spark pull request: [SPARK-12480][SQL] add Hash expression that ca...

2015-12-27 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10435#issuecomment-167403074 **[Test build #48352 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48352/consoleFull)** for PR 10435 at commit

[GitHub] spark pull request: [SPARK-12480][SQL] add Hash expression that ca...

2015-12-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10435#issuecomment-167403091 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-12480][SQL] add Hash expression that ca...

2015-12-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10435#issuecomment-167403090 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-12480][SQL] add Hash expression that ca...

2015-12-27 Thread cloud-fan
Github user cloud-fan commented on the pull request: https://github.com/apache/spark/pull/10435#issuecomment-167395236 retest this please. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-12480][SQL] add Hash expression that ca...

2015-12-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10435#issuecomment-167396600 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-12480][SQL] add Hash expression that ca...

2015-12-27 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10435#issuecomment-167396598 **[Test build #48349 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48349/consoleFull)** for PR 10435 at commit

[GitHub] spark pull request: [SPARK-12480][SQL] add Hash expression that ca...

2015-12-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10435#issuecomment-167396601 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-12480][SQL] add Hash expression that ca...

2015-12-27 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10435#issuecomment-167396554 **[Test build #48349 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48349/consoleFull)** for PR 10435 at commit

[GitHub] spark pull request: [SPARK-12480][SQL] add Hash expression that ca...

2015-12-27 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10435#issuecomment-167396643 **[Test build #48350 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48350/consoleFull)** for PR 10435 at commit

[GitHub] spark pull request: [SPARK-12480][SQL] add Hash expression that ca...

2015-12-27 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10435#issuecomment-167396684 **[Test build #48350 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48350/consoleFull)** for PR 10435 at commit

[GitHub] spark pull request: [SPARK-12480][SQL] add Hash expression that ca...

2015-12-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10435#issuecomment-167396686 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-12480][SQL] add Hash expression that ca...

2015-12-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10435#issuecomment-167396685 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-12480][SQL] add Hash expression that ca...

2015-12-27 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10435#issuecomment-167447980 **[Test build #48356 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48356/consoleFull)** for PR 10435 at commit

[GitHub] spark pull request: [SPARK-12480][SQL] add Hash expression that ca...

2015-12-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10435#issuecomment-167452745 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-12480][SQL] add Hash expression that ca...

2015-12-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10435#issuecomment-167452744 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-12480][SQL] add Hash expression that ca...

2015-12-27 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10435#issuecomment-167452730 **[Test build #48356 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48356/consoleFull)** for PR 10435 at commit

[GitHub] spark pull request: [SPARK-12480][SQL] add Hash expression that ca...

2015-12-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10435#issuecomment-167338506 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-12480][SQL] add Hash expression that ca...

2015-12-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10435#issuecomment-167338507 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-12480][SQL] add Hash expression that ca...

2015-12-26 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10435#issuecomment-167338499 **[Test build #48346 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48346/consoleFull)** for PR 10435 at commit

[GitHub] spark pull request: [SPARK-12480][SQL] add Hash expression that ca...

2015-12-26 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10435#issuecomment-167328998 **[Test build #48346 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48346/consoleFull)** for PR 10435 at commit

[GitHub] spark pull request: [SPARK-12480][SQL] add Hash expression that ca...

2015-12-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10435#issuecomment-167329447 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-12480][SQL] add Hash expression that ca...

2015-12-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10435#issuecomment-167329445 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-12480][SQL] add Hash expression that ca...

2015-12-25 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10435#issuecomment-167246248 **[Test build #48325 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48325/consoleFull)** for PR 10435 at commit

[GitHub] spark pull request: [SPARK-12480][SQL] add Hash expression that ca...

2015-12-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10435#issuecomment-167251759 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-12480][SQL] add Hash expression that ca...

2015-12-25 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10435#issuecomment-167251754 **[Test build #48325 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48325/consoleFull)** for PR 10435 at commit

[GitHub] spark pull request: [SPARK-12480][SQL] add Hash expression that ca...

2015-12-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10435#issuecomment-167251758 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

  1   2   >