[GitHub] spark pull request: [SPARK-12495][SQL] use true as default value f...

2015-12-30 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/10443 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: [SPARK-12495][SQL] use true as default value f...

2015-12-30 Thread marmbrus
Github user marmbrus commented on the pull request: https://github.com/apache/spark/pull/10443#issuecomment-168055742 Thanks, merging to master. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-12495][SQL] use true as default value f...

2015-12-28 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10443#issuecomment-167697369 **[Test build #48389 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48389/consoleFull)** for PR 10443 at commit

[GitHub] spark pull request: [SPARK-12495][SQL] use true as default value f...

2015-12-28 Thread marmbrus
Github user marmbrus commented on a diff in the pull request: https://github.com/apache/spark/pull/10443#discussion_r48501675 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/objects.scala --- @@ -241,7 +241,7 @@ case class NewInstance(

[GitHub] spark pull request: [SPARK-12495][SQL] use true as default value f...

2015-12-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10443#issuecomment-167710193 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-12495][SQL] use true as default value f...

2015-12-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10443#issuecomment-167710195 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-12495][SQL] use true as default value f...

2015-12-28 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10443#issuecomment-167710116 **[Test build #48389 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48389/consoleFull)** for PR 10443 at commit

[GitHub] spark pull request: [SPARK-12495][SQL] use true as default value f...

2015-12-23 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/10443#discussion_r48346325 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/objects.scala --- @@ -241,7 +241,7 @@ case class NewInstance(

[GitHub] spark pull request: [SPARK-12495][SQL] use true as default value f...

2015-12-23 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/10443#discussion_r48344118 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/objects.scala --- @@ -231,7 +231,7 @@ case class NewInstance(

[GitHub] spark pull request: [SPARK-12495][SQL] use true as default value f...

2015-12-23 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10443#issuecomment-166916883 **[Test build #48242 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48242/consoleFull)** for PR 10443 at commit

[GitHub] spark pull request: [SPARK-12495][SQL] use true as default value f...

2015-12-23 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10443#issuecomment-166896497 **[Test build #48242 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48242/consoleFull)** for PR 10443 at commit

[GitHub] spark pull request: [SPARK-12495][SQL] use true as default value f...

2015-12-23 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/10443#discussion_r48346034 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/objects.scala --- @@ -231,7 +231,7 @@ case class NewInstance(

[GitHub] spark pull request: [SPARK-12495][SQL] use true as default value f...

2015-12-23 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/10443#discussion_r48350913 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/objects.scala --- @@ -241,7 +241,7 @@ case class NewInstance(

[GitHub] spark pull request: [SPARK-12495][SQL] use true as default value f...

2015-12-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10443#issuecomment-166917017 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-12495][SQL] use true as default value f...

2015-12-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10443#issuecomment-166917016 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-12495][SQL] use true as default value f...

2015-12-23 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10443#issuecomment-166843689 **[Test build #48233 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48233/consoleFull)** for PR 10443 at commit

[GitHub] spark pull request: [SPARK-12495][SQL] use true as default value f...

2015-12-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10443#issuecomment-166843816 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-12495][SQL] use true as default value f...

2015-12-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10443#issuecomment-166843817 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-12495][SQL] use true as default value f...

2015-12-23 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10443#issuecomment-166831471 **[Test build #48233 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48233/consoleFull)** for PR 10443 at commit

[GitHub] spark pull request: [SPARK-12495][SQL] use true as default value f...

2015-12-22 Thread cloud-fan
Github user cloud-fan commented on the pull request: https://github.com/apache/spark/pull/10443#issuecomment-166829974 cc @marmbrus @viirya --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-12495][SQL] use true as default value f...

2015-12-22 Thread cloud-fan
GitHub user cloud-fan opened a pull request: https://github.com/apache/spark/pull/10443 [SPARK-12495][SQL] use true as default value for propagateNull in NewInstance Most of cases we should propagate null when call `NewInstance`, and so far there is only one case we should stop