Github user sureshthalamati commented on the pull request:
https://github.com/apache/spark/pull/10452#issuecomment-170095510
Thanks for merging this to 2.0, Michael , I will create PR against 1.6
branch.
---
If your project is set up for it, you can reply to this email and have your
Github user marmbrus commented on the pull request:
https://github.com/apache/spark/pull/10452#issuecomment-169401454
We typically only merge critical bug fixes into release branches, but this
is small enough that I would consider it if its important to you.
---
If your project is
Github user maver1ck commented on the pull request:
https://github.com/apache/spark/pull/10452#issuecomment-169409283
For me this is critical security issue.
So I'd like to have it in 1.6 branch
(I'm sure that 1.6.1 will be available earlier than 2.0.0)
---
If your project
Github user marmbrus commented on the pull request:
https://github.com/apache/spark/pull/10452#issuecomment-169411013
Okay, we can back port it. I'm a little curious about your use case, as
this seems mostly cosmetic to me. If users can run Spark jobs they have access
to the JVM
Github user maver1ck commented on the pull request:
https://github.com/apache/spark/pull/10452#issuecomment-169420636
It's not the explain but SQL Tab on Spark web console.
As far as I understand information there are taken from the same source.
Am I right ?
PS. I'm
Github user marmbrus commented on the pull request:
https://github.com/apache/spark/pull/10452#issuecomment-169423769
Ah, that is a good point. I'm not exactly sure, but would be interested to
find out. I'll backport this. I mostly wanted to make sure you weren't
expecting more
Github user marmbrus commented on the pull request:
https://github.com/apache/spark/pull/10452#issuecomment-169424065
This doesn't patch cleanly. @sureshthalamati (or someone) can you open a
PR against branch-1.6.
---
If your project is set up for it, you can reply to this email
Github user maver1ck commented on the pull request:
https://github.com/apache/spark/pull/10452#issuecomment-169395482
@marmbrus
What about merging it to 1.6 branch ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well.
Github user sureshthalamati commented on the pull request:
https://github.com/apache/spark/pull/10452#issuecomment-169136996
Retest this please.
Tests passed in my branch. Test Failure in the builds does not seem to be
related to my changes.
---
If your project is set up
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10452#issuecomment-169145624
**[Test build #48792 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48792/consoleFull)**
for PR 10452 at commit
Github user marmbrus commented on the pull request:
https://github.com/apache/spark/pull/10452#issuecomment-169144753
test this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10452#issuecomment-169167587
**[Test build #48792 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48792/consoleFull)**
for PR 10452 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10452#issuecomment-169167869
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10452#issuecomment-169167867
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user marmbrus commented on the pull request:
https://github.com/apache/spark/pull/10452#issuecomment-169192724
Thanks, merging to master.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/10452
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10452#issuecomment-168497026
**[Test build #2303 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2303/consoleFull)**
for PR 10452 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10452#issuecomment-168491856
**[Test build #2303 has
started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2303/consoleFull)**
for PR 10452 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10452#issuecomment-168271940
**[Test build #2283 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2283/consoleFull)**
for PR 10452 at commit
Github user sureshthalamati commented on the pull request:
https://github.com/apache/spark/pull/10452#issuecomment-168260505
Thanks, Michael. Updated the PR. Please review.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10452#issuecomment-168259705
**[Test build #2283 has
started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2283/consoleFull)**
for PR 10452 at commit
Github user marmbrus commented on the pull request:
https://github.com/apache/spark/pull/10452#issuecomment-167605425
Yes
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user sureshthalamati commented on the pull request:
https://github.com/apache/spark/pull/10452#issuecomment-167167658
Thank you very much for reviewing the patch Michael , Sean.
@Michael : I agree with you long unnecessary strings in the plan output is
annoying. If
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/10452#discussion_r48405336
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JDBCRelation.scala
---
@@ -19,6 +19,7 @@ package
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/10452#discussion_r48405368
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/jdbc/DB2Dialect.scala ---
@@ -29,4 +29,8 @@ private object DB2Dialect extends JdbcDialect {
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/10452#discussion_r48405397
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/jdbc/JdbcDialects.scala ---
@@ -108,6 +108,19 @@ abstract class JdbcDialect extends Serializable {
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/10452#discussion_r48405431
--- Diff: sql/core/src/test/scala/org/apache/spark/sql/jdbc/JDBCSuite.scala
---
@@ -517,4 +519,65 @@ class JDBCSuite extends SparkFunSuite
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10452#issuecomment-166970399
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
GitHub user sureshthalamati opened a pull request:
https://github.com/apache/spark/pull/10452
[SPARK-12504][SQL] Masking credentials in the sql plan explain output for
JDBC data sources.
This fix masks JDBC credentials in the explain output. URL patterns to
specify credential
Github user marmbrus commented on the pull request:
https://github.com/apache/spark/pull/10452#issuecomment-167015712
What about taking the whitelist approach and only include the dbtable (with
possible truncation) in the `toString`. Its not great when these are too long
as they
30 matches
Mail list logo
