Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/10583#discussion_r48940817
--- Diff:
sql/catalyst/src/main/java/org/apache/spark/sql/catalyst/parser/ParseUtils.java
---
@@ -0,0 +1,163 @@
+/**
+ * Licensed to the Apache
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10583#issuecomment-169305716
**[Test build #48853 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48853/consoleFull)**
for PR 10583 at commit
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/10583#discussion_r48940364
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/CatalystQl.scala ---
@@ -0,0 +1,969 @@
+/*
+ * Licensed to the Apache
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/10583#discussion_r48951342
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/SQLConf.scala ---
@@ -451,6 +452,19 @@ private[spark] object SQLConf {
doc = "When true,
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/10583#discussion_r48951594
--- Diff: dev/deps/spark-deps-hadoop-2.2 ---
@@ -5,8 +5,7 @@ activation-1.1.jar
akka-actor_2.10-2.3.11.jar
akka-remote_2.10-2.3.11.jar
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/10583#discussion_r48951642
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/CatalystQl.scala ---
@@ -0,0 +1,961 @@
+/*
+ * Licensed to the Apache
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10583#issuecomment-169326184
**[Test build #48853 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48853/consoleFull)**
for PR 10583 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10583#issuecomment-169326444
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10583#issuecomment-169326441
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user marmbrus commented on the pull request:
https://github.com/apache/spark/pull/10583#issuecomment-169404802
Regarding the questions about `LATERAL VIEW`. Ideally I think we will
support one query language that has a super-set of the features that were
previously present in
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/10583#discussion_r48988457
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/CatalystQl.scala ---
@@ -0,0 +1,961 @@
+/*
+ * Licensed to the Apache Software
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/10583#discussion_r48995383
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/CatalystQl.scala ---
@@ -0,0 +1,961 @@
+/*
+ * Licensed to the Apache
Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/10583#issuecomment-169425486
Due to the size of the patch, I'm going to merge this in now. @hvanhovell
can address more comments as follow-up prs.
---
If your project is set up for it, you can
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/10583
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10583#issuecomment-168932606
**[Test build #48747 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48747/consoleFull)**
for PR 10583 at commit
Github user hvanhovell commented on the pull request:
https://github.com/apache/spark/pull/10583#issuecomment-168929936
retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10583#issuecomment-168931844
**[Test build #2322 has
started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2322/consoleFull)**
for PR 10583 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10583#issuecomment-168955204
**[Test build #2322 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2322/consoleFull)**
for PR 10583 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10583#issuecomment-168965051
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10583#issuecomment-168965050
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10583#issuecomment-168964867
**[Test build #48747 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48747/consoleFull)**
for PR 10583 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10583#issuecomment-169049675
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10583#issuecomment-169049668
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10583#issuecomment-169049383
**[Test build #48771 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48771/consoleFull)**
for PR 10583 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10583#issuecomment-169007832
**[Test build #48766 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48766/consoleFull)**
for PR 10583 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10583#issuecomment-169007990
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10583#issuecomment-169007994
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10583#issuecomment-169012694
**[Test build #48771 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48771/consoleFull)**
for PR 10583 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10583#issuecomment-169094038
**[Test build #48780 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48780/consoleFull)**
for PR 10583 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10583#issuecomment-169122642
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10583#issuecomment-169122639
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user hvanhovell commented on the pull request:
https://github.com/apache/spark/pull/10583#issuecomment-169126939
retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10583#issuecomment-169129174
**[Test build #48789 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48789/consoleFull)**
for PR 10583 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10583#issuecomment-169122427
**[Test build #48780 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48780/consoleFull)**
for PR 10583 at commit
Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/10583#issuecomment-169208476
BTW given the size of the pull request, I think we can also merge it
provided that it has no structural problems, and then review feedback in
follow-up prs.
---
If
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/10583#discussion_r48922609
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/SQLConf.scala ---
@@ -451,6 +452,19 @@ private[spark] object SQLConf {
doc = "When true, we
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/10583#discussion_r48923332
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/CatalystQl.scala ---
@@ -0,0 +1,969 @@
+/*
+ * Licensed to the Apache Software
Github user cloud-fan commented on the pull request:
https://github.com/apache/spark/pull/10583#issuecomment-169204037
Does case-sensitivity config still work with the new parser?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/10583#discussion_r48923378
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/CatalystQl.scala ---
@@ -0,0 +1,969 @@
+/*
+ * Licensed to the Apache Software
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/10583#discussion_r48934251
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/CatalystQl.scala ---
@@ -0,0 +1,969 @@
+/*
+ * Licensed to the Apache
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/10583#discussion_r48934317
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/SQLConf.scala ---
@@ -451,6 +452,19 @@ private[spark] object SQLConf {
doc = "When true,
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/10583#discussion_r48919353
--- Diff:
sql/catalyst/src/main/java/org/apache/spark/sql/catalyst/parser/ParseUtils.java
---
@@ -0,0 +1,163 @@
+/**
+ * Licensed to the Apache
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/10583#discussion_r48919450
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -587,6 +586,13 @@ class Analyzer(
case
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/10583#discussion_r48919389
--- Diff:
sql/catalyst/src/main/java/org/apache/spark/sql/catalyst/parser/ParseUtils.java
---
@@ -0,0 +1,163 @@
+/**
+ * Licensed to the Apache
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/10583#discussion_r48919495
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/unresolved.scala
---
@@ -129,23 +129,39 @@ object UnresolvedAttribute {
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10583#issuecomment-169165991
**[Test build #48789 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48789/consoleFull)**
for PR 10583 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10583#issuecomment-169166339
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10583#issuecomment-169166337
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/10583#issuecomment-169169980
Can you update the pull request description? It still says WIP.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user hvanhovell commented on the pull request:
https://github.com/apache/spark/pull/10583#issuecomment-169171058
Done.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10583#issuecomment-168984129
**[Test build #48766 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48766/consoleFull)**
for PR 10583 at commit
Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/10583#issuecomment-169196055
cc @cloud-fan can you take a look at this? Thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/10583#discussion_r48921238
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -587,6 +586,13 @@ class Analyzer(
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10583#issuecomment-168866570
**[Test build #48709 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48709/consoleFull)**
for PR 10583 at commit
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/10583#discussion_r48805244
--- Diff:
sql/catalyst/src/main/java/org/apache/spark/sql/parser/ParseUtils.java ---
@@ -0,0 +1,163 @@
+/**
+ * Licensed to the Apache Software
Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/10583#discussion_r48805084
--- Diff:
sql/catalyst/src/main/java/org/apache/spark/sql/parser/ParseUtils.java ---
@@ -0,0 +1,163 @@
+/**
+ * Licensed to the Apache Software
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10583#issuecomment-168906958
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10583#issuecomment-168906918
**[Test build #48709 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48709/consoleFull)**
for PR 10583 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10583#issuecomment-168906957
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
59 matches
Mail list logo
