Github user gatorsmile commented on the pull request:
https://github.com/apache/spark/pull/10577#issuecomment-173473258
Really appreciate your reviews!!! : )
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user gatorsmile commented on the pull request:
https://github.com/apache/spark/pull/10577#issuecomment-173293382
The latest merge is for resolving the conflicts.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10577#issuecomment-17298
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10577#issuecomment-173332908
**[Test build #49792 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/49792/consoleFull)**
for PR 10577 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10577#issuecomment-17301
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user gatorsmile commented on the pull request:
https://github.com/apache/spark/pull/10577#issuecomment-173362144
@rxin @marmbrus , could you please review the latest changes? Thank you!
---
If your project is set up for it, you can reply to this email and have your
reply
Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/10577#issuecomment-173391875
Thanks - I'm going to merge this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/10577
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user cloud-fan commented on the pull request:
https://github.com/apache/spark/pull/10577#issuecomment-173384017
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10577#issuecomment-173300904
**[Test build #49792 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/49792/consoleFull)**
for PR 10577 at commit
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/10577#discussion_r50175266
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/HiveTypeCoercion.scala
---
@@ -219,34 +222,62 @@ object HiveTypeCoercion {
Github user cloud-fan commented on the pull request:
https://github.com/apache/spark/pull/10577#issuecomment-172940341
LGTM except one minor comment
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/10577#discussion_r50150694
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/HiveTypeCoercion.scala
---
@@ -219,34 +222,62 @@ object HiveTypeCoercion {
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10577#issuecomment-173021608
**[Test build #49722 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/49722/consoleFull)**
for PR 10577 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10577#issuecomment-173036085
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10577#issuecomment-173036081
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user gatorsmile commented on the pull request:
https://github.com/apache/spark/pull/10577#issuecomment-173073042
The test failure was caused by a PR, which has been reverted.
retest this please.
---
If your project is set up for it, you can reply to this email and
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10577#issuecomment-173035940
**[Test build #49722 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/49722/consoleFull)**
for PR 10577 at commit
Github user gatorsmile commented on the pull request:
https://github.com/apache/spark/pull/10577#issuecomment-173093961
retest this please.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10577#issuecomment-173094840
**[Test build #49760 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/49760/consoleFull)**
for PR 10577 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10577#issuecomment-173116680
**[Test build #49760 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/49760/consoleFull)**
for PR 10577 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10577#issuecomment-173116859
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10577#issuecomment-173116857
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/10577#discussion_r50055366
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/HiveTypeCoercion.scala
---
@@ -27,6 +30,7 @@ import org.apache.spark.sql.types._
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/10577#discussion_r50059783
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/HiveTypeCoercion.scala
---
@@ -27,6 +30,7 @@ import
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10577#issuecomment-172696176
**[Test build #49634 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/49634/consoleFull)**
for PR 10577 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10577#issuecomment-172709381
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user gatorsmile commented on the pull request:
https://github.com/apache/spark/pull/10577#issuecomment-172678732
@rxin Thank you for your trust! I am not sure if my new changes follow the
same way you did. It is a little bit different if we have more than two
children. Please
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10577#issuecomment-172680219
**[Test build #49634 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/49634/consoleFull)**
for PR 10577 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10577#issuecomment-172691276
**[Test build #49644 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/49644/consoleFull)**
for PR 10577 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10577#issuecomment-172696361
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10577#issuecomment-172696362
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10577#issuecomment-172708908
**[Test build #49644 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/49644/consoleFull)**
for PR 10577 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10577#issuecomment-172709376
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user gatorsmile commented on the pull request:
https://github.com/apache/spark/pull/10577#issuecomment-172453483
@rxin @marmbrus Could you check if this fix is OK? Thank you!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10577#issuecomment-172176512
**[Test build #49525 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/49525/consoleFull)**
for PR 10577 at commit
Github user gatorsmile commented on the pull request:
https://github.com/apache/spark/pull/10577#issuecomment-172173700
Sorry, just replied the kind of `hidden` comment. See the answer just after
the comment. : )
Will first update the codes to address your latest two
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10577#issuecomment-172182176
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10577#issuecomment-172182177
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10577#issuecomment-172234334
**[Test build #49528 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/49528/consoleFull)**
for PR 10577 at commit
Github user gatorsmile commented on the pull request:
https://github.com/apache/spark/pull/10577#issuecomment-172217405
retest this please.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user cloud-fan commented on the pull request:
https://github.com/apache/spark/pull/10577#issuecomment-172240480
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/10577#discussion_r49934992
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/CatalystQl.scala ---
@@ -393,8 +393,8 @@
Github user gatorsmile commented on the pull request:
https://github.com/apache/spark/pull/10577#issuecomment-172293472
Thank you! @cloud-fan Have a good long weekend!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10577#issuecomment-172218228
**[Test build #49528 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/49528/consoleFull)**
for PR 10577 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10577#issuecomment-172234459
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10577#issuecomment-172234454
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/10577#discussion_r49912654
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/planning/patterns.scala
---
@@ -170,17 +173,28 @@ object ExtractFiltersAndInnerJoins
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/10577#discussion_r49912748
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/HiveTypeCoercion.scala
---
@@ -200,41 +203,70 @@ object HiveTypeCoercion {
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/10577#discussion_r49912939
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/SQLBuilder.scala ---
@@ -129,10 +129,13 @@ class SQLBuilder(logicalPlan: LogicalPlan,
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/10577#discussion_r49912958
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/basicOperators.scala
---
@@ -123,6 +115,40 @@ case class Except(left:
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/10577#discussion_r49912966
--- Diff: sql/core/src/test/scala/org/apache/spark/sql/DataFrameSuite.scala
---
@@ -98,6 +98,20 @@ class DataFrameSuite extends QueryTest with
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10577#issuecomment-172113839
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10577#issuecomment-172113840
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10577#issuecomment-172114207
**[Test build #49492 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/49492/consoleFull)**
for PR 10577 at commit
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/10577#discussion_r49915485
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/SQLBuilder.scala ---
@@ -129,12 +129,16 @@ class SQLBuilder(logicalPlan: LogicalPlan,
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10577#issuecomment-172134262
**[Test build #49492 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/49492/consoleFull)**
for PR 10577 at commit
Github user cloud-fan commented on the pull request:
https://github.com/apache/spark/pull/10577#issuecomment-172122102
a kind of hidden comment:
https://github.com/apache/spark/pull/10577/files#r49784836
---
If your project is set up for it, you can reply to this email and have your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10577#issuecomment-172134415
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10577#issuecomment-172134417
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/10577#discussion_r49915364
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/planning/patterns.scala
---
@@ -170,17 +173,28 @@ object ExtractFiltersAndInnerJoins
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/10577#discussion_r49915984
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/SQLBuilder.scala ---
@@ -129,12 +129,16 @@ class SQLBuilder(logicalPlan: LogicalPlan,
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/10577#discussion_r49915065
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/HiveTypeCoercion.scala
---
@@ -200,41 +203,62 @@ object HiveTypeCoercion {
Github user gatorsmile commented on the pull request:
https://github.com/apache/spark/pull/10577#issuecomment-171913477
@cloud-fan Really THANK YOU for your review! Will do the changes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10577#issuecomment-171575054
**[Test build #49391 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/49391/consoleFull)**
for PR 10577 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10577#issuecomment-171575322
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10577#issuecomment-171575320
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/10577#discussion_r49798629
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/planning/patterns.scala
---
@@ -170,17 +173,28 @@ object ExtractFiltersAndInnerJoins
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/10577#discussion_r49799520
--- Diff: sql/core/src/test/scala/org/apache/spark/sql/DataFrameSuite.scala
---
@@ -98,6 +98,20 @@ class DataFrameSuite extends QueryTest with
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/10577#discussion_r49798849
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/planning/patterns.scala
---
@@ -170,17 +173,28 @@ object ExtractFiltersAndInnerJoins
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/10577#discussion_r49798994
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/basicOperators.scala
---
@@ -123,6 +115,40 @@ case class Except(left:
Github user cloud-fan commented on the pull request:
https://github.com/apache/spark/pull/10577#issuecomment-171810333
LGTM except some minor comments, thanks for working on it!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/10577#discussion_r49799631
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/SQLBuilder.scala ---
@@ -129,10 +129,13 @@ class SQLBuilder(logicalPlan: LogicalPlan,
Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/10577#discussion_r49789952
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -1171,6 +1172,15 @@ object EliminateSubQueries extends
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/10577#discussion_r49784836
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/CatalystQl.scala ---
@@ -393,8 +393,8 @@
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/10577#discussion_r49784995
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -1171,6 +1172,15 @@ object EliminateSubQueries extends
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/10577#discussion_r49790507
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/HiveTypeCoercion.scala
---
@@ -200,41 +203,70 @@ object HiveTypeCoercion {
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/10577#discussion_r49629259
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/basicOperators.scala
---
@@ -123,6 +115,39 @@ case class Except(left:
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/10577#discussion_r49629751
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/basicOperators.scala
---
@@ -123,6 +115,39 @@ case class Except(left:
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/10577#discussion_r49630147
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/SetOperationPushDownSuite.scala
---
@@ -30,42 +30,67 @@ class
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/10577#discussion_r49631656
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/planning/patterns.scala
---
@@ -170,17 +173,27 @@ object ExtractFiltersAndInnerJoins
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/10577#discussion_r49635574
--- Diff: sql/core/src/test/scala/org/apache/spark/sql/DataFrameSuite.scala
---
@@ -98,6 +98,20 @@ class DataFrameSuite extends QueryTest with
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/10577#discussion_r49630735
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/planning/patterns.scala
---
@@ -170,17 +173,27 @@ object ExtractFiltersAndInnerJoins
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/10577#discussion_r49629931
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/planning/patterns.scala
---
@@ -170,17 +173,27 @@ object ExtractFiltersAndInnerJoins
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/10577#discussion_r49630313
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/SetOperationPushDownSuite.scala
---
@@ -30,42 +30,67 @@ class
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/10577#discussion_r49630582
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/planning/patterns.scala
---
@@ -170,17 +173,27 @@ object ExtractFiltersAndInnerJoins
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/10577#discussion_r49630546
--- Diff: sql/core/src/test/scala/org/apache/spark/sql/DataFrameSuite.scala
---
@@ -98,6 +98,20 @@ class DataFrameSuite extends QueryTest with
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/10577#discussion_r49630650
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/SetOperationPushDownSuite.scala
---
@@ -30,42 +30,67 @@ class
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/10577#discussion_r49635154
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/planning/patterns.scala
---
@@ -170,17 +173,27 @@ object ExtractFiltersAndInnerJoins
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/10577#discussion_r49632415
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/planning/patterns.scala
---
@@ -170,17 +173,27 @@ object ExtractFiltersAndInnerJoins
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/10577#discussion_r49635884
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/basicOperators.scala
---
@@ -123,6 +115,39 @@ case class Except(left:
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/10577#discussion_r49631075
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/basicOperators.scala
---
@@ -123,6 +115,39 @@ case class Except(left:
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/10577#discussion_r49694420
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/basicOperators.scala
---
@@ -123,6 +115,39 @@ case class Except(left:
Github user gatorsmile commented on the pull request:
https://github.com/apache/spark/pull/10577#issuecomment-171560242
In this update, the major changes include
- Added a new analyzer rule `EliminateUnions` for remove the union with a
single child.
- Rewrote the function
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10577#issuecomment-171560133
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10577#issuecomment-171560132
Build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10577#issuecomment-171560553
**[Test build #49391 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/49391/consoleFull)**
for PR 10577 at commit
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/10577#discussion_r49551487
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/basicOperators.scala
---
@@ -123,6 +115,39 @@ case class Except(left:
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/10577#discussion_r49551474
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/CheckAnalysis.scala
---
@@ -189,6 +189,15 @@ trait CheckAnalysis {
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/10577#discussion_r49551543
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/HiveTypeCoercion.scala
---
@@ -200,41 +200,60 @@ object HiveTypeCoercion {
1 - 100 of 191 matches
Mail list logo
