Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/11050#discussion_r55914872
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/namedExpressions.scala
---
@@ -174,7 +184,8 @@ case class Alias(child:
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/11050#discussion_r55914448
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/namedExpressions.scala
---
@@ -174,7 +184,8 @@ case class Alias(child:
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/11050#discussion_r55914401
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/namedExpressions.scala
---
@@ -174,7 +184,8 @@ case class Alias(child:
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/11050
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user liancheng commented on the pull request:
https://github.com/apache/spark/pull/11050#issuecomment-182673514
LGTM, merging to master. Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11050#issuecomment-181443489
**[Test build #50926 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50926/consoleFull)**
for PR 11050 at commit
Github user gatorsmile commented on the pull request:
https://github.com/apache/spark/pull/11050#issuecomment-181436878
retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11050#issuecomment-181501876
**[Test build #50926 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50926/consoleFull)**
for PR 11050 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11050#issuecomment-181502535
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11050#issuecomment-181502533
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11050#issuecomment-181237467
**[Test build #50908 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50908/consoleFull)**
for PR 11050 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11050#issuecomment-181237630
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11050#issuecomment-181237627
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user gatorsmile commented on the pull request:
https://github.com/apache/spark/pull/11050#issuecomment-180972695
retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11050#issuecomment-180974601
**[Test build #50893 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50893/consoleFull)**
for PR 11050 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11050#issuecomment-180992952
**[Test build #50893 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50893/consoleFull)**
for PR 11050 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11050#issuecomment-180992987
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11050#issuecomment-180992986
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user liancheng commented on the pull request:
https://github.com/apache/spark/pull/11050#issuecomment-181175638
retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11050#issuecomment-181178930
**[Test build #50908 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50908/consoleFull)**
for PR 11050 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11050#issuecomment-180882339
**[Test build #50882 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50882/consoleFull)**
for PR 11050 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11050#issuecomment-180894832
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user gatorsmile commented on the pull request:
https://github.com/apache/spark/pull/11050#issuecomment-180879283
retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11050#issuecomment-180894828
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11050#issuecomment-180894176
**[Test build #50882 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50882/consoleFull)**
for PR 11050 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11050#issuecomment-180846515
**[Test build #50875 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50875/consoleFull)**
for PR 11050 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11050#issuecomment-180846748
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11050#issuecomment-180846758
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11050#issuecomment-180828144
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11050#issuecomment-180828145
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11050#issuecomment-180827424
**[Test build #50875 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50875/consoleFull)**
for PR 11050 at commit
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/11050#discussion_r52096964
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/namedExpressions.scala
---
@@ -114,16 +117,21 @@ abstract class
Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/11050#discussion_r52088011
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/namedExpressions.scala
---
@@ -114,16 +117,21 @@ abstract class Attribute
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/11050#discussion_r51977520
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/namedExpressions.scala
---
@@ -114,16 +117,21 @@ abstract class Attribute
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/11050#discussion_r51977612
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/namedExpressions.scala
---
@@ -114,16 +117,21 @@ abstract class Attribute
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/11050#discussion_r51977660
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/namedExpressions.scala
---
@@ -197,7 +209,8 @@ case class
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/11050#discussion_r51980394
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/namedExpressions.scala
---
@@ -114,16 +117,21 @@ abstract class
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/11050#discussion_r51977477
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -413,9 +413,11 @@ class Analyzer(
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11050#issuecomment-179273624
**[Test build #50662 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50662/consoleFull)**
for PR 11050 at commit
GitHub user gatorsmile opened a pull request:
https://github.com/apache/spark/pull/11050
[SPARK-12725] [SQL] Resolving Name Conflicts in SQL Generation by Adding a
flag `isGenerated` to Alias and AttributeReference
Some analysis rules generate auxiliary attribute references with
Github user marmbrus commented on the pull request:
https://github.com/apache/spark/pull/11050#issuecomment-179531337
Yeah, that test looks great.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user gatorsmile commented on the pull request:
https://github.com/apache/spark/pull/11050#issuecomment-179528336
I guess the PR you mentioned is https://github.com/apache/spark/pull/8231
I think we should disallow users to accidentally use the internally
generated
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11050#issuecomment-179531114
**[Test build #50704 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50704/consoleFull)**
for PR 11050 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11050#issuecomment-179565159
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11050#issuecomment-179565153
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11050#issuecomment-179558925
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11050#issuecomment-179558924
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11050#issuecomment-179558494
**[Test build #50695 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50695/consoleFull)**
for PR 11050 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11050#issuecomment-179564713
**[Test build #50704 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50704/consoleFull)**
for PR 11050 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11050#issuecomment-179333787
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11050#issuecomment-179333780
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11050#issuecomment-179332729
**[Test build #50662 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50662/consoleFull)**
for PR 11050 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11050#issuecomment-179522483
**[Test build #50695 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50695/consoleFull)**
for PR 11050 at commit
Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/11050#discussion_r51761300
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/namedExpressions.scala
---
@@ -195,7 +202,8 @@ case class
Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/11050#discussion_r51761274
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/namedExpressions.scala
---
@@ -116,11 +116,15 @@ abstract class Attribute
Github user marmbrus commented on the pull request:
https://github.com/apache/spark/pull/11050#issuecomment-179382231
We should also modify the `resolve` function to filter out attributes where
`isGenerated = true`. There have been bugs in the past where this creates
ambiguity and
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/11050#discussion_r51761850
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/namedExpressions.scala
---
@@ -116,11 +116,15 @@ abstract class
Github user gatorsmile commented on the pull request:
https://github.com/apache/spark/pull/11050#issuecomment-179388873
@marmbrus Do you still remember the JIRA number or the case? If so, I can
add it into the test cases and verify if the fix works well.
In this PR,
Github user marmbrus commented on the pull request:
https://github.com/apache/spark/pull/11050#issuecomment-179391285
I'd have to search for it as it was a while ago, you should be able to
trigger it by forcing the analyzer to generate a column while referencing a
column with the
Github user gatorsmile commented on the pull request:
https://github.com/apache/spark/pull/11050#issuecomment-179393445
@marmbrus : ) Now I understand it. Will do it. Thank you!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
60 matches
Mail list logo
