Github user JoshRosen commented on the pull request:
https://github.com/apache/spark/pull/10672#issuecomment-170452044
I've opened https://github.com/apache/spark/pull/10693 to hotfix the
exclusions. In the 1.5 and 1.6 backport branches, I've re-scoped the changes to
only exclude `org
Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/10672#discussion_r49293105
--- Diff: pom.xml ---
@@ -606,6 +606,12 @@
${akka.group}
akka-remote_${scala.binary.version}
${akka.version}
+
Github user JoshRosen commented on the pull request:
https://github.com/apache/spark/pull/10672#issuecomment-170444677
I discovered that the now-removed `netty.io:netty` dependency places its
classes under the `org.jboss.netty` namespace, so I guess there's not a
conflict between `net
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/10672
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is ena
Github user JoshRosen commented on the pull request:
https://github.com/apache/spark/pull/10672#issuecomment-170426398
Thanks for reviewing. I'm going to merge this into master and will open
separate PRs to test the backports, which might possibly require a different
set of exclusion
Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/10672#issuecomment-170320786
LGTM.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled a
Github user JoshRosen commented on the pull request:
https://github.com/apache/spark/pull/10672#issuecomment-170320650
Actually, I might choose to handle those separately in a followup next week
in order to have more time to think through a few additional cases, including
the exclusio
Github user JoshRosen commented on the pull request:
https://github.com/apache/spark/pull/10672#issuecomment-170320386
I've opened two pull requests to backport the `dev/test-dependencies` infra
to branch-1.5 and 1.6, which should allow me to backport this change as well.
I ag
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10672#issuecomment-170224808
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10672#issuecomment-170224807
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10672#issuecomment-170224800
**[Test build #49041 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/49041/consoleFull)**
for PR 10672 at commit
[`798441a`](https://g
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/10672#issuecomment-170220723
LGTM. Other candidates for banning: the servlet API jars in all its
packagings
---
If your project is set up for it, you can reply to this email and have your
reply app
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10672#issuecomment-170201685
**[Test build #49041 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/49041/consoleFull)**
for PR 10672 at commit
[`798441a`](https://gi
Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/10672#discussion_r49261090
--- Diff: dev/test-dependencies.sh ---
@@ -70,19 +70,10 @@ $MVN -q versions:set -DnewVersion=$TEMP_VERSION
-DgenerateBackupPoms=false > /de
# Generate
Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/10672#discussion_r49261085
--- Diff: dev/test-dependencies.sh ---
@@ -70,19 +70,10 @@ $MVN -q versions:set -DnewVersion=$TEMP_VERSION
-DgenerateBackupPoms=false > /de
# Generate
Github user JoshRosen commented on the pull request:
https://github.com/apache/spark/pull/10672#issuecomment-170201532
I'd like to backport the `dev/test-dependencies` infrastructure as far back
as `branch-1.5` so that we can merge a similar fix there as well. After this
fix gets in,
GitHub user JoshRosen opened a pull request:
https://github.com/apache/spark/pull/10672
[SPARK-12734][BUILD] Fix Netty exclusion and use Maven Enforcer to prevent
future bugs
Netty classes are published under artifacts with different names, so our
build needs to exclude the `io.net
17 matches
Mail list logo
