Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/11815
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is ena
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11815#issuecomment-199182997
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11815#issuecomment-199183000
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11815#issuecomment-199182820
**[Test build #53662 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/53662/consoleFull)**
for PR 11815 at commit
[`46e3f69`](https://g
Github user cloud-fan commented on the pull request:
https://github.com/apache/spark/pull/11815#issuecomment-199161987
LGTM, pending tests.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have thi
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11815#issuecomment-199155092
**[Test build #53662 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/53662/consoleFull)**
for PR 11815 at commit
[`46e3f69`](https://gi
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11815#issuecomment-199147853
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11815#issuecomment-199147855
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11815#issuecomment-199147735
**[Test build #53656 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/53656/consoleFull)**
for PR 11815 at commit
[`d52e1c7`](https://g
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/11815#discussion_r56785821
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala ---
@@ -435,6 +435,11 @@ object SQLConf {
defaultValue = Some(true)
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/11815#discussion_r56785791
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -618,13 +622,36 @@ class Analyzer(
* clause.
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/11815#discussion_r56784940
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala ---
@@ -435,6 +435,11 @@ object SQLConf {
defaultValue = Some(true),
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/11815#discussion_r56784850
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -618,13 +622,36 @@ class Analyzer(
* clause. T
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/11815#discussion_r56784481
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/CatalystConf.scala ---
@@ -22,6 +22,8 @@ import org.apache.spark.sql.catalyst.analysis._
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/11815#discussion_r56784377
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/CatalystConf.scala ---
@@ -22,6 +22,8 @@ import org.apache.spark.sql.catalyst.analysis.
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/11815#discussion_r56784332
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/CatalystConf.scala ---
@@ -22,6 +22,8 @@ import org.apache.spark.sql.catalyst.analysis._
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/11815#discussion_r56783497
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/CatalystConf.scala ---
@@ -22,6 +22,8 @@ import org.apache.spark.sql.catalyst.analysis.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11815#issuecomment-199131347
**[Test build #53656 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/53656/consoleFull)**
for PR 11815 at commit
[`d52e1c7`](https://gi
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/11815#discussion_r56783037
--- Diff: sql/core/src/test/scala/org/apache/spark/sql/SQLQuerySuite.scala
---
@@ -2156,6 +2158,47 @@ class SQLQuerySuite extends QueryTest with
SharedSQ
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/11815#discussion_r56779430
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/CatalystConf.scala ---
@@ -22,6 +22,8 @@ import org.apache.spark.sql.catalyst.analysis._
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/11815#discussion_r56779275
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/CatalystConf.scala ---
@@ -22,6 +22,8 @@ import org.apache.spark.sql.catalyst.analysis.
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/11815#discussion_r56779251
--- Diff: sql/core/src/test/scala/org/apache/spark/sql/SQLQuerySuite.scala
---
@@ -2156,6 +2158,47 @@ class SQLQuerySuite extends QueryTest with
SharedSQL
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11815#issuecomment-198463940
**[Test build #53542 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/53542/consoleFull)**
for PR 11815 at commit
[`256814b`](https://g
Github user gatorsmile commented on the pull request:
https://github.com/apache/spark/pull/11815#issuecomment-198428356
Will submit a separate PR for cleaning/eliminating no-op `SortOrder` in
Optimizer. Thanks!
---
If your project is set up for it, you can reply to this email and hav
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/11815#discussion_r56618287
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -618,9 +622,33 @@ class Analyzer(
* clause. This ru
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/11815#discussion_r56620898
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/planning/patterns.scala
---
@@ -202,3 +203,14 @@ object Unions {
}
}
}
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11815#issuecomment-198245857
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/11815#issuecomment-198230304
Thanks - the description is great!
If the order by list is empty (all or constant foldable), then I'd say we
should get rid of the order by. That's what postgres d
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/11815#discussion_r56619429
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -618,9 +622,33 @@ class Analyzer(
* clause. T
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11815#issuecomment-198245859
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/11815#discussion_r56752455
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala ---
@@ -435,6 +435,11 @@ object SQLConf {
defaultValue = Some(true)
GitHub user gatorsmile opened a pull request:
https://github.com/apache/spark/pull/11815
[SPARK-12789] [SQL] Support Order By Ordinal in SQL
What changes were proposed in this pull request?
This PR is to support order by position in SQL, e.g.
```SQL
select c1, c2, c3
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11815#issuecomment-198245677
**[Test build #53516 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/53516/consoleFull)**
for PR 11815 at commit
[`e0dce39`](https://g
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/11815#discussion_r56668722
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/planning/patterns.scala
---
@@ -202,3 +203,14 @@ object Unions {
}
}
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11815#issuecomment-198464279
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/11815#discussion_r56618261
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/planning/patterns.scala
---
@@ -202,3 +203,14 @@ object Unions {
}
}
}
Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/11815#issuecomment-198487974
cc @cloud-fan for review
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/11815#discussion_r56619383
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/planning/patterns.scala
---
@@ -202,3 +203,14 @@ object Unions {
}
}
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/11815#discussion_r56619717
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/planning/patterns.scala
---
@@ -202,3 +203,14 @@ object Unions {
}
}
}
Github user adrian-wang commented on a diff in the pull request:
https://github.com/apache/spark/pull/11815#discussion_r56745951
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala ---
@@ -435,6 +435,11 @@ object SQLConf {
defaultValue = Some(true
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11815#issuecomment-198230978
**[Test build #53516 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/53516/consoleFull)**
for PR 11815 at commit
[`e0dce39`](https://gi
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11815#issuecomment-198652024
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/11815#discussion_r56745774
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala ---
@@ -435,6 +435,11 @@ object SQLConf {
defaultValue = Some(true),
Github user adrian-wang commented on a diff in the pull request:
https://github.com/apache/spark/pull/11815#discussion_r56745738
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala ---
@@ -435,6 +435,11 @@ object SQLConf {
defaultValue = Some(true
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11815#issuecomment-198652029
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11815#issuecomment-198651595
**[Test build #53604 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/53604/consoleFull)**
for PR 11815 at commit
[`b04529b`](https://g
Github user cloud-fan commented on the pull request:
https://github.com/apache/spark/pull/11815#issuecomment-198634566
LGTM except 2 minor comments
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/11815#discussion_r56618306
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -618,9 +622,33 @@ class Analyzer(
* clause. This ru
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11815#issuecomment-198639998
**[Test build #53604 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/53604/consoleFull)**
for PR 11815 at commit
[`b04529b`](https://gi
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11815#issuecomment-198464284
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/11815#discussion_r56744398
--- Diff: sql/core/src/test/scala/org/apache/spark/sql/SQLQuerySuite.scala
---
@@ -2156,6 +2158,47 @@ class SQLQuerySuite extends QueryTest with
SharedSQ
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/11815#discussion_r56744391
--- Diff: sql/core/src/test/scala/org/apache/spark/sql/SQLQuerySuite.scala
---
@@ -2156,6 +2158,47 @@ class SQLQuerySuite extends QueryTest with
SharedSQL
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/11815#discussion_r56744357
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -618,9 +622,32 @@ class Analyzer(
* clause. T
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/11815#discussion_r56744337
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -618,9 +622,32 @@ class Analyzer(
* clause. Th
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/11815#discussion_r56620457
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/planning/patterns.scala
---
@@ -202,3 +203,14 @@ object Unions {
}
}
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11815#issuecomment-198425224
**[Test build #53542 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/53542/consoleFull)**
for PR 11815 at commit
[`256814b`](https://gi
56 matches
Mail list logo
