Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/10860#discussion_r51472337
--- Diff:
core/src/test/resources/spark-events/local-1425081759268/EVENT_LOG_1 ---
@@ -0,0 +1,88 @@
+{"Event":"SparkListenerBlockManagerAdded","Block
Github user felixcheung commented on the pull request:
https://github.com/apache/spark/pull/10860#issuecomment-178166829
sure - that was just to make sure it doesn't get picked up, as a negative
test. I can purge all of that since it seems both you and @vanzin have the same
feedback?
Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/10860#issuecomment-178169396
I see, that seems unnecessary. We deleted all the code path that would
parse the format so it's pretty much impossible for it to be picked up right?
---
If your
Github user felixcheung commented on the pull request:
https://github.com/apache/spark/pull/10860#issuecomment-178159771
Could we merge this please?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/10860#discussion_r51472679
--- Diff: .rat-excludes ---
@@ -63,14 +63,15 @@ logs
.*dependency-reduced-pom.xml
known_translations
json_expectation
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10860#issuecomment-178220256
**[Test build #50503 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50503/consoleFull)**
for PR 10860 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10860#issuecomment-178273402
**[Test build #50503 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50503/consoleFull)**
for PR 10860 at commit
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/10860
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/10860#issuecomment-178285540
Merged into master.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/10860#issuecomment-178269135
LGTM, I can't wait to merge this!!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10860#issuecomment-178273616
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10860#issuecomment-178273615
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/10860#issuecomment-178166468
@felixcheung this looks great! I'm excited about how many lines of code
we're deleting in this patch. I had one question about the tests but this is
good to go
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10860#issuecomment-177046250
**[Test build #50427 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50427/consoleFull)**
for PR 10860 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10860#issuecomment-177062624
**[Test build #50427 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50427/consoleFull)**
for PR 10860 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10860#issuecomment-177062675
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10860#issuecomment-177062676
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/10860#discussion_r51304370
--- Diff:
core/src/main/scala/org/apache/spark/deploy/history/FsHistoryProvider.scala ---
@@ -261,8 +259,8 @@ private[history] class FsHistoryProvider(conf:
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10860#issuecomment-176930477
**[Test build #50398 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50398/consoleFull)**
for PR 10860 at commit
Github user vanzin commented on the pull request:
https://github.com/apache/spark/pull/10860#issuecomment-176925381
retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user vanzin commented on the pull request:
https://github.com/apache/spark/pull/10860#issuecomment-176927504
LGTM.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10860#issuecomment-176968992
**[Test build #50398 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50398/consoleFull)**
for PR 10860 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10860#issuecomment-176969146
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10860#issuecomment-176969148
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10860#issuecomment-176619085
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10860#issuecomment-176619087
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10860#issuecomment-176618998
**[Test build #50349 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50349/consoleFull)**
for PR 10860 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10860#issuecomment-176591953
**[Test build #50349 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50349/consoleFull)**
for PR 10860 at commit
Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/10860#discussion_r51229062
--- Diff:
core/src/main/scala/org/apache/spark/deploy/history/FsHistoryProvider.scala ---
@@ -248,9 +248,7 @@ private[history] class
Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/10860#discussion_r51214677
--- Diff:
core/src/test/scala/org/apache/spark/deploy/history/FsHistoryProviderSuite.scala
---
@@ -406,10 +380,9 @@ class FsHistoryProviderSuite
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/10860#discussion_r51215482
--- Diff:
core/src/main/scala/org/apache/spark/deploy/history/FsHistoryProvider.scala ---
@@ -248,9 +248,7 @@ private[history] class FsHistoryProvider(conf:
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10860#issuecomment-176511358
**[Test build #50324 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50324/consoleFull)**
for PR 10860 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10860#issuecomment-176545154
**[Test build #50324 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50324/consoleFull)**
for PR 10860 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10860#issuecomment-176545237
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10860#issuecomment-176545233
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/10860#discussion_r50738479
--- Diff:
core/src/main/scala/org/apache/spark/deploy/history/FsHistoryProvider.scala ---
@@ -562,90 +544,18 @@ private[history] class
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/10860#discussion_r50738942
--- Diff:
core/src/test/scala/org/apache/spark/deploy/history/FsHistoryProviderSuite.scala
---
@@ -57,6 +57,15 @@ class FsHistoryProviderSuite extends
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/10860#discussion_r50738693
--- Diff: .rat-excludes ---
@@ -63,14 +63,15 @@ logs
.*dependency-reduced-pom.xml
known_translations
json_expectation
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/10860#discussion_r50739205
--- Diff:
core/src/test/scala/org/apache/spark/deploy/history/FsHistoryProviderSuite.scala
---
@@ -406,10 +380,9 @@ class FsHistoryProviderSuite extends
Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/10860#discussion_r50772500
--- Diff: .rat-excludes ---
@@ -63,14 +63,15 @@ logs
.*dependency-reduced-pom.xml
known_translations
json_expectation
Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/10860#discussion_r50772556
--- Diff:
core/src/test/scala/org/apache/spark/deploy/history/FsHistoryProviderSuite.scala
---
@@ -57,6 +57,15 @@ class FsHistoryProviderSuite extends
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10860#issuecomment-174271820
**[Test build #49949 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/49949/consoleFull)**
for PR 10860 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10860#issuecomment-174271823
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10860#issuecomment-174271821
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10860#issuecomment-174271800
**[Test build #49949 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/49949/consoleFull)**
for PR 10860 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10860#issuecomment-174273829
**[Test build #49950 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/49950/consoleFull)**
for PR 10860 at commit
Github user felixcheung commented on the pull request:
https://github.com/apache/spark/pull/10860#issuecomment-174266111
Thanks for checking - looked into it and it was because of the removal of
the legacy log format.
It looks like HistoryServerSuite has more tests on the legacy
Github user JoshRosen commented on the pull request:
https://github.com/apache/spark/pull/10860#issuecomment-174386559
I'd also ping @vanzin for this, since I believe that he was involved in a
lot of the original refactoring of this HistoryServer code.
---
If your project is set up
Github user felixcheung commented on the pull request:
https://github.com/apache/spark/pull/10860#issuecomment-174386459
@andrewor14 @JoshRosen ready for review. thx
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10860#issuecomment-174288131
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10860#issuecomment-174288089
**[Test build #49950 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/49950/consoleFull)**
for PR 10860 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10860#issuecomment-174288129
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user JoshRosen commented on the pull request:
https://github.com/apache/spark/pull/10860#issuecomment-174244196
These look like legitimate test failures.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
GitHub user felixcheung opened a pull request:
https://github.com/apache/spark/pull/10860
[SPARK-12790][CORE] Remove HistoryServer old multiple files format
Removed isLegacyLogDirectory code path and updated tests
@andrewor14
You can merge this pull request into a Git
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10860#issuecomment-173466952
**[Test build #49852 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/49852/consoleFull)**
for PR 10860 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10860#issuecomment-173467237
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10860#issuecomment-173467240
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10860#issuecomment-173450200
**[Test build #49852 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/49852/consoleFull)**
for PR 10860 at commit
58 matches
Mail list logo
