Github user davies commented on the pull request:
https://github.com/apache/spark/pull/11055#issuecomment-181727263
LGTM, merging this into master, thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11055#issuecomment-181667202
**[Test build #50951 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50951/consoleFull)**
for PR 11055 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11055#issuecomment-181695332
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11055#issuecomment-181695338
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11055#issuecomment-181660379
**[Test build #50948 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50948/consoleFull)**
for PR 11055 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11055#issuecomment-181660464
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11055#issuecomment-181660462
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/11055
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11055#issuecomment-181694918
**[Test build #50951 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50951/consoleFull)**
for PR 11055 at commit
Github user davies commented on the pull request:
https://github.com/apache/spark/pull/11055#issuecomment-181565008
I tried this patch with ss_max query, it failed with:
```
java.lang.NullPointerException
at
Github user nongli commented on the pull request:
https://github.com/apache/spark/pull/11055#issuecomment-181639460
@davies Thanks for testing it out. I fixed the bug (reading multiple row
groups)
---
If your project is set up for it, you can reply to this email and have your
reply
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11055#issuecomment-181642792
**[Test build #50948 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50948/consoleFull)**
for PR 11055 at commit
Github user davies commented on a diff in the pull request:
https://github.com/apache/spark/pull/11055#discussion_r52081720
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/SQLConf.scala ---
@@ -345,6 +345,14 @@ private[spark] object SQLConf {
defaultValue =
Github user davies commented on a diff in the pull request:
https://github.com/apache/spark/pull/11055#discussion_r52084570
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/parquet/CatalystSchemaConverter.scala
---
@@ -65,7 +65,7 @@ private[parquet]
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11055#issuecomment-180047876
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11055#issuecomment-180047872
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user davies commented on a diff in the pull request:
https://github.com/apache/spark/pull/11055#discussion_r51952950
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/SQLConf.scala ---
@@ -345,6 +345,14 @@ private[spark] object SQLConf {
defaultValue =
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11055#issuecomment-180047567
**[Test build #50761 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50761/consoleFull)**
for PR 11055 at commit
Github user davies commented on a diff in the pull request:
https://github.com/apache/spark/pull/11055#discussion_r51950606
--- Diff:
sql/core/src/main/java/org/apache/spark/sql/execution/vectorized/ColumnVectorUtils.java
---
@@ -100,6 +101,9 @@ private static void
Github user davies commented on a diff in the pull request:
https://github.com/apache/spark/pull/11055#discussion_r51949138
--- Diff:
sql/core/src/main/java/org/apache/spark/sql/execution/vectorized/ColumnarBatch.java
---
@@ -18,19 +18,22 @@
import
Github user nongli commented on a diff in the pull request:
https://github.com/apache/spark/pull/11055#discussion_r51959711
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/SQLConf.scala ---
@@ -345,6 +345,14 @@ private[spark] object SQLConf {
defaultValue =
Github user nongli commented on a diff in the pull request:
https://github.com/apache/spark/pull/11055#discussion_r51922204
--- Diff:
sql/core/src/main/java/org/apache/spark/sql/execution/datasources/parquet/UnsafeRowParquetRecordReader.java
---
@@ -645,7 +676,15 @@ private void
Github user nongli commented on a diff in the pull request:
https://github.com/apache/spark/pull/11055#discussion_r51922394
--- Diff:
sql/core/src/main/java/org/apache/spark/sql/execution/datasources/parquet/UnsafeRowParquetRecordReader.java
---
@@ -716,6 +788,28 @@ private void
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11055#issuecomment-180016936
**[Test build #50761 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50761/consoleFull)**
for PR 11055 at commit
Github user davies commented on a diff in the pull request:
https://github.com/apache/spark/pull/11055#discussion_r51909478
--- Diff:
sql/core/src/main/java/org/apache/spark/sql/execution/datasources/parquet/UnsafeRowParquetRecordReader.java
---
@@ -645,7 +676,15 @@ private void
Github user davies commented on a diff in the pull request:
https://github.com/apache/spark/pull/11055#discussion_r51909811
--- Diff:
sql/core/src/main/java/org/apache/spark/sql/execution/datasources/parquet/UnsafeRowParquetRecordReader.java
---
@@ -716,6 +788,28 @@ private void
Github user davies commented on a diff in the pull request:
https://github.com/apache/spark/pull/11055#discussion_r51909743
--- Diff:
sql/core/src/main/java/org/apache/spark/sql/execution/datasources/parquet/UnsafeRowParquetRecordReader.java
---
@@ -716,6 +788,28 @@ private void
Github user davies commented on a diff in the pull request:
https://github.com/apache/spark/pull/11055#discussion_r51909239
--- Diff:
sql/core/src/main/java/org/apache/spark/sql/execution/datasources/parquet/UnsafeRowParquetRecordReader.java
---
@@ -166,15 +170,23 @@ public void
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11055#issuecomment-179456926
**[Test build #50670 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50670/consoleFull)**
for PR 11055 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11055#issuecomment-179457193
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11055#issuecomment-179457198
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11055#issuecomment-179525711
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11055#issuecomment-179525707
**[Test build #50696 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50696/consoleFull)**
for PR 11055 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11055#issuecomment-179556622
**[Test build #50700 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50700/consoleFull)**
for PR 11055 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11055#issuecomment-179531536
**[Test build #50700 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50700/consoleFull)**
for PR 11055 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11055#issuecomment-179524080
**[Test build #50696 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50696/consoleFull)**
for PR 11055 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11055#issuecomment-179556823
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11055#issuecomment-179556820
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11055#issuecomment-179525717
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/11055#issuecomment-179669580
cc @davies for review
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11055#issuecomment-179421846
**[Test build #50670 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50670/consoleFull)**
for PR 11055 at commit
GitHub user nongli opened a pull request:
https://github.com/apache/spark/pull/11055
[SPARK-12992][SQL] Support vectorized decoding in
UnsafeRowParquetRecordReader.
WIP: running tests. Code needs a bit of clean up.
This patch completes the vectorized decoding with the goal
42 matches
Mail list logo
