Github user liancheng commented on the pull request:
https://github.com/apache/spark/pull/10954#issuecomment-176620214
I'm merging this. Thanks for fixing this!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/10954
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user liancheng commented on the pull request:
https://github.com/apache/spark/pull/10954#issuecomment-176619493
@vanzin I see, thanks for the explanation! Then this LGTM.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user ajbozarth commented on the pull request:
https://github.com/apache/spark/pull/10954#issuecomment-176439956
Also looping in @rxin and @JoshRosen since they were in on #10851 which
caused this
---
If your project is set up for it, you can reply to this email and have your
Github user holdenk commented on the pull request:
https://github.com/apache/spark/pull/10954#issuecomment-176440938
Would it maybe be a good idea to add a test for this to the jenkins scripts?
---
If your project is set up for it, you can reply to this email and have your
reply
Github user liancheng commented on the pull request:
https://github.com/apache/spark/pull/10954#issuecomment-176477123
Hm, but I do find that spark-test-tags is listed as default compile
dependency in other modules. Is that necessary? @JoshRosen
---
If your project is set up for
Github user liancheng commented on the pull request:
https://github.com/apache/spark/pull/10954#issuecomment-176475976
One of the requirements of the spark-sketch module is to have zero external
runtime dependencies. Is it possible to make it a test dependency? It seems
quite
Github user vanzin commented on the pull request:
https://github.com/apache/spark/pull/10954#issuecomment-176528787
spark-test-tags is declared with a test dependency in the root pom, and the
scope is inherited. You can check these things with `mvn dependency:tree`.
---
If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10954#issuecomment-175894464
**[Test build #50221 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50221/consoleFull)**
for PR 10954 at commit
Github user holdenk commented on the pull request:
https://github.com/apache/spark/pull/10954#issuecomment-175994566
This looks reasonable to me, maybe @liancheng who added the sketch build
file can take a look as well?
---
If your project is set up for it, you can reply to this
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10954#issuecomment-175894920
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10954#issuecomment-175894925
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
GitHub user ajbozarth opened a pull request:
https://github.com/apache/spark/pull/10954
[SPARK-13050] [Build] Scalatest tags fail build with the addition of the
sketch module
A dependency on the spark test tags was left out of the sketch module pom
file causing builds to fail when
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10954#issuecomment-175849366
**[Test build #50221 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50221/consoleFull)**
for PR 10954 at commit
14 matches
Mail list logo
