[GitHub] spark pull request: [SPARK-13064] Make sure attemptId not none for...

2016-05-09 Thread zhuoliu
Github user zhuoliu commented on the pull request: https://github.com/apache/spark/pull/12075#issuecomment-217971974 sure, thanks @srowen! Closing. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-13064] Make sure attemptId not none for...

2016-05-09 Thread zhuoliu
Github user zhuoliu closed the pull request at: https://github.com/apache/spark/pull/12075 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: [SPARK-13064] Make sure attemptId not none for...

2016-05-09 Thread srowen
Github user srowen commented on the pull request: https://github.com/apache/spark/pull/12075#issuecomment-217800070 OK let's close this PR @zhuoliu --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] spark pull request: [SPARK-13064] Make sure attemptId not none for...

2016-05-08 Thread jerryshao
Github user jerryshao commented on the pull request: https://github.com/apache/spark/pull/12075#issuecomment-217768123 @srowen , currently we assume attempt id is `None` when spark application is running on yarn client mode. This assumption is used not only in REST api, but also in

[GitHub] spark pull request: [SPARK-13064] Make sure attemptId not none for...

2016-05-06 Thread srowen
Github user srowen commented on the pull request: https://github.com/apache/spark/pull/12075#issuecomment-217511458 OK, so @jerryshao you're fairly sure we shouldn't make this change? --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] spark pull request: [SPARK-13064] Make sure attemptId not none for...

2016-03-30 Thread jerryshao
Github user jerryshao commented on the pull request: https://github.com/apache/spark/pull/12075#issuecomment-203714098 IIUC for all the application running on yarn client mode, the attempt id is None, this assumption are not only existed in REST API, but also in event log, yarn

[GitHub] spark pull request: [SPARK-13064] Make sure attemptId not none for...

2016-03-30 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12075#issuecomment-203662693 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-13064] Make sure attemptId not none for...

2016-03-30 Thread zhuoliu
GitHub user zhuoliu opened a pull request: https://github.com/apache/spark/pull/12075 [SPARK-13064] Make sure attemptId not none for Rest API ## What changes were proposed in this pull request? For some application that does not set attemptId for their attempts, e.g.,