Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/11134
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is ena
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/11134#issuecomment-182314667
@tedyu just have some patience. Sometimes we're just giving others a chance
to look before merging. Merged to master
---
If your project is set up for it, you can reply
Github user tedyu commented on the pull request:
https://github.com/apache/spark/pull/11134#issuecomment-18226
@andrewor14
Is there anything I need to do for this ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well.
Github user holdenk commented on the pull request:
https://github.com/apache/spark/pull/11134#issuecomment-182019134
LGTM :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabl
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/11134#issuecomment-182011762
Yes that's fine if it passes tests and it does
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your pr
Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/11134#issuecomment-181999375
@srowen
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
en
Github user ted-yu closed the pull request at:
https://github.com/apache/spark/pull/11082
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is ena
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11134#issuecomment-181937745
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11134#issuecomment-181937746
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11134#issuecomment-181937419
**[Test build #50973 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50973/consoleFull)**
for PR 11134 at commit
[`1c80127`](https://g
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11134#issuecomment-181928745
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11134#issuecomment-181928741
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11134#issuecomment-181928154
**[Test build #50972 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50972/consoleFull)**
for PR 11134 at commit
[`1c80127`](https://g
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11134#issuecomment-181882205
**[Test build #50973 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50973/consoleFull)**
for PR 11134 at commit
[`1c80127`](https://gi
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11134#issuecomment-181874824
**[Test build #50972 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50972/consoleFull)**
for PR 11134 at commit
[`1c80127`](https://gi
Github user tedyu commented on the pull request:
https://github.com/apache/spark/pull/11134#issuecomment-181874005
Jenkins, test this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have th
GitHub user tedyu opened a pull request:
https://github.com/apache/spark/pull/11134
[SPARK-13203] Add scalastyle rule banning use of mutable.SynchronizedBuffer
@andrewor14
Please take a look
You can merge this pull request into a Git repository by running:
$ git pull https
Github user ted-yu commented on the pull request:
https://github.com/apache/spark/pull/11082#issuecomment-181051841
bq. If an existing PR means to catch all occurrences of the issue the rule
would flag, then it needs to cover this case too
In this case, looks like SPARK-13151
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/11082#issuecomment-181041504
Of course, this depends on the new rule passing for the whole project. If
an existing PR means to catch all occurrences of the issue the rule would flag,
then it needs t
Github user ted-yu commented on the pull request:
https://github.com/apache/spark/pull/11082#issuecomment-181036649
DirectKafkaStreamSuite.scala is not covered by #11067
Addition of scalastyle rule would not pass even after #11067 goes in.
Should I open a seperate PR for Di
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/11082#issuecomment-181016035
@ted-yu please close this PR, or go ahead and make it only about the issue
you filed: a scalastyle rule.
---
If your project is set up for it, you can reply to this ema
Github user ted-yu commented on the pull request:
https://github.com/apache/spark/pull/11082#issuecomment-180616613
There is no error in DirectKafkaStreamSuite.scala
Once [~holdenk]'s PR goes in, I will rebase.
---
If your project is set up for it, you can reply to this email
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11082#issuecomment-180595657
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11082#issuecomment-180595440
**[Test build #50841 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50841/consoleFull)**
for PR 11082 at commit
[`5e770b0`](https://g
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11082#issuecomment-180595648
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11082#issuecomment-180551644
**[Test build #50841 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50841/consoleFull)**
for PR 11082 at commit
[`5e770b0`](https://gi
Github user ted-yu commented on the pull request:
https://github.com/apache/spark/pull/11082#issuecomment-180546842
Jenkins, test this please.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11082#issuecomment-180538476
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11082#issuecomment-180538479
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11082#issuecomment-180538470
**[Test build #50839 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50839/consoleFull)**
for PR 11082 at commit
[`b84c8c7`](https://g
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11082#issuecomment-180538123
**[Test build #50839 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50839/consoleFull)**
for PR 11082 at commit
[`b84c8c7`](https://gi
Github user ted-yu commented on the pull request:
https://github.com/apache/spark/pull/11082#issuecomment-180536530
Jenkins, test this please.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user holdenk commented on the pull request:
https://github.com/apache/spark/pull/11082#issuecomment-180535047
@ted-yu you can use Arrays.asList with the splat syntax along with the
ConcurrentLinkedQueues add all method:
`collectedData.addAll(Arrays.asList(rdd.collect():
Github user ted-yu commented on the pull request:
https://github.com/apache/spark/pull/11082#issuecomment-180498087
I am trying to add an Array to ConcurrentLinkedQueue (collectedData) in
Scala 2.11:
```
stream.foreachRDD { rdd => Collections.addAll(collectedData, rdd.collect()
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11082#issuecomment-180353775
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11082#issuecomment-180353779
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11082#issuecomment-180353432
**[Test build #50814 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50814/consoleFull)**
for PR 11082 at commit
[`7faca67`](https://g
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11082#issuecomment-180321270
**[Test build #50814 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50814/consoleFull)**
for PR 11082 at commit
[`7faca67`](https://gi
Github user ted-yu commented on the pull request:
https://github.com/apache/spark/pull/11082#issuecomment-180318313
Jenkins, test this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have t
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11082#issuecomment-180232633
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11082#issuecomment-180232634
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11082#issuecomment-180232564
**[Test build #50801 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50801/consoleFull)**
for PR 11082 at commit
[`879eebe`](https://g
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11082#issuecomment-180215670
**[Test build #50801 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50801/consoleFull)**
for PR 11082 at commit
[`879eebe`](https://gi
Github user ted-yu commented on the pull request:
https://github.com/apache/spark/pull/11082#issuecomment-180208925
Jenkins, test this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have t
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11082#issuecomment-180206885
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11082#issuecomment-180206889
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11082#issuecomment-180206653
**[Test build #50800 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50800/consoleFull)**
for PR 11082 at commit
[`74a4c70`](https://g
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11082#issuecomment-180183717
**[Test build #50800 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50800/consoleFull)**
for PR 11082 at commit
[`74a4c70`](https://gi
Github user ted-yu commented on the pull request:
https://github.com/apache/spark/pull/11082#issuecomment-180181416
Jenkins, test this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have t
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11082#issuecomment-180173777
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11082#issuecomment-180173779
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11082#issuecomment-180173772
**[Test build #50796 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50796/consoleFull)**
for PR 11082 at commit
[`ebf3509`](https://g
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11082#issuecomment-180173593
**[Test build #50796 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50796/consoleFull)**
for PR 11082 at commit
[`ebf3509`](https://gi
Github user ted-yu commented on the pull request:
https://github.com/apache/spark/pull/11082#issuecomment-180172718
Jenkins, test this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have t
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11082#issuecomment-180166322
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11082#issuecomment-180166319
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11082#issuecomment-180165727
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11082#issuecomment-180165728
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user holdenk commented on the pull request:
https://github.com/apache/spark/pull/11082#issuecomment-180163623
I'd probably just wait for the streaming PR to also get merged in - makes
it simpler.
---
If your project is set up for it, you can reply to this email and have your
r
Github user ted-yu commented on the pull request:
https://github.com/apache/spark/pull/11082#issuecomment-180163281
Jenkins, test this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have t
Github user ted-yu commented on the pull request:
https://github.com/apache/spark/pull/11082#issuecomment-180162600
Some files in this PR are not covered by #11067
@holdenk
I can base my PR on yours.
Let me know what you think.
---
If your project is set up for it, y
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11082#issuecomment-180133381
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11082#issuecomment-180133377
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11082#issuecomment-180133239
**[Test build #50785 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50785/consoleFull)**
for PR 11082 at commit
[`b63c136`](https://g
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11082#issuecomment-180109461
**[Test build #50785 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50785/consoleFull)**
for PR 11082 at commit
[`b63c136`](https://gi
Github user ted-yu commented on the pull request:
https://github.com/apache/spark/pull/11082#issuecomment-180104115
Jenkins, test this please.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11082#issuecomment-180102650
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11082#issuecomment-180102645
**[Test build #50781 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50781/consoleFull)**
for PR 11082 at commit
[`a566d91`](https://g
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11082#issuecomment-180102653
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/11082#issuecomment-180101869
I think there's some overlap between this patch and #11067
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11082#issuecomment-180100978
**[Test build #50781 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50781/consoleFull)**
for PR 11082 at commit
[`a566d91`](https://gi
Github user ted-yu commented on the pull request:
https://github.com/apache/spark/pull/11082#issuecomment-180095881
Jenkins, test this please.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11082#issuecomment-180091791
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11082#issuecomment-180091753
**[Test build #50778 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50778/consoleFull)**
for PR 11082 at commit
[`f5666a8`](https://g
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11082#issuecomment-180091783
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11082#issuecomment-180087833
**[Test build #50778 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50778/consoleFull)**
for PR 11082 at commit
[`f5666a8`](https://gi
Github user ted-yu commented on the pull request:
https://github.com/apache/spark/pull/11082#issuecomment-180084459
Jenkins, test this please.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11082#issuecomment-180075200
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11082#issuecomment-180075187
**[Test build #50776 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50776/consoleFull)**
for PR 11082 at commit
[`a40711c`](https://g
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11082#issuecomment-180075198
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11082#issuecomment-180074860
**[Test build #50776 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50776/consoleFull)**
for PR 11082 at commit
[`a40711c`](https://gi
Github user ted-yu commented on the pull request:
https://github.com/apache/spark/pull/11082#issuecomment-180074493
Logged SPARK-13204 for replacing mutable.SynchronizedMap
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well.
Github user ted-yu commented on the pull request:
https://github.com/apache/spark/pull/11082#issuecomment-180072504
Jenkins, test this please.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11082#issuecomment-180066626
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11082#issuecomment-180066623
**[Test build #50773 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50773/consoleFull)**
for PR 11082 at commit
[`4375f65`](https://g
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11082#issuecomment-180066628
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11082#issuecomment-180066287
**[Test build #50773 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50773/consoleFull)**
for PR 11082 at commit
[`4375f65`](https://gi
Github user ted-yu commented on the pull request:
https://github.com/apache/spark/pull/11082#issuecomment-180064615
```
external/kafka/src/test/scala/org/apache/spark/streaming/kafka/DirectKafkaStreamSuite.scala:
new ArrayBuffer[(String, String)] with
mutable.SynchronizedBuf
Github user ted-yu commented on the pull request:
https://github.com/apache/spark/pull/11082#issuecomment-180063800
```
external/kafka/src/test/scala/org/apache/spark/streaming/kafka/KafkaStreamSuite.scala:
val result = new mutable.HashMap[String, Long]() with
mutable.Synchron
Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/11082#issuecomment-180063316
can you add one for `SynchronizedMap` as well
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user ted-yu commented on the pull request:
https://github.com/apache/spark/pull/11082#issuecomment-180062533
Jenkins, test this please.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
91 matches
Mail list logo
