Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/11106#issuecomment-182603275
I haven't actually looked at your pull request, but I'm fairly sure the
implementation is wrong given the number of lines involved. The actual change
is probably much
Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/11106#issuecomment-182631745
In terms of API, I think we should just add intersectAll and exceptAll
functions to it.
For union, we should keep the existing behavior, and if users want to do
Github user gatorsmile commented on the pull request:
https://github.com/apache/spark/pull/11106#issuecomment-182633769
Thank you! Will do it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/11106#issuecomment-182634587
And can we close this pr and only open it when you have a new version?
Thanks.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user gatorsmile closed the pull request at:
https://github.com/apache/spark/pull/11106
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user gatorsmile commented on the pull request:
https://github.com/apache/spark/pull/11106#issuecomment-182631369
Uh, you are right. : ) Will follow your suggestions. Thank you!
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user gatorsmile commented on the pull request:
https://github.com/apache/spark/pull/11106#issuecomment-182650276
Sure, let me close it first. Will continue to work on it. Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/11106#discussion_r52316778
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/HiveTypeCoercion.scala
---
@@ -223,16 +222,22 @@ object HiveTypeCoercion {
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/11106#discussion_r52316817
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
---
@@ -1059,19 +1059,24 @@ object
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11106#issuecomment-181908431
**[Test build #50977 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50977/consoleFull)**
for PR 11106 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11106#issuecomment-181945076
**[Test build #50977 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50977/consoleFull)**
for PR 11106 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11106#issuecomment-181945469
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11106#issuecomment-181945468
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11106#issuecomment-181443249
**[Test build #50924 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50924/consoleFull)**
for PR 11106 at commit
Github user gatorsmile commented on the pull request:
https://github.com/apache/spark/pull/11106#issuecomment-181436898
retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/11106#discussion_r52272979
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/HiveTypeCoercion.scala
---
@@ -223,16 +222,22 @@ object HiveTypeCoercion {
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/11106#discussion_r52272371
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
---
@@ -1059,19 +1059,24 @@ object
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11106#issuecomment-181489828
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11106#issuecomment-181489822
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11106#issuecomment-181489271
**[Test build #50924 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50924/consoleFull)**
for PR 11106 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11106#issuecomment-181512242
**[Test build #50930 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50930/consoleFull)**
for PR 11106 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11106#issuecomment-181540969
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11106#issuecomment-181540966
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11106#issuecomment-181540611
**[Test build #50930 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50930/consoleFull)**
for PR 11106 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11106#issuecomment-180982794
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11106#issuecomment-180982798
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11106#issuecomment-180982584
**[Test build #50891 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50891/consoleFull)**
for PR 11106 at commit
Github user gatorsmile commented on the pull request:
https://github.com/apache/spark/pull/11106#issuecomment-180972560
retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/11106#discussion_r52114742
--- Diff:
sql/catalyst/src/main/antlr3/org/apache/spark/sql/catalyst/parser/SparkSqlParser.g
---
@@ -,7 +2223,9 @@ setOperator
: KW_UNION
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/11106#discussion_r52114881
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
---
@@ -1059,19 +1059,24 @@ object
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11106#issuecomment-180983890
**[Test build #50896 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50896/consoleFull)**
for PR 11106 at commit
Github user hvanhovell commented on the pull request:
https://github.com/apache/spark/pull/11106#issuecomment-180982746
retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/11106#discussion_r52114891
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala ---
@@ -594,8 +594,9 @@ class Dataset[T] private[sql](
* and thus is not
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11106#issuecomment-180974351
**[Test build #50891 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50891/consoleFull)**
for PR 11106 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11106#issuecomment-180994216
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11106#issuecomment-180994189
**[Test build #50896 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50896/consoleFull)**
for PR 11106 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11106#issuecomment-180994217
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/11106#discussion_r52121131
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
---
@@ -1059,19 +1059,24 @@ object
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/11106#discussion_r52121128
--- Diff:
sql/catalyst/src/main/antlr3/org/apache/spark/sql/catalyst/parser/SparkSqlParser.g
---
@@ -,7 +2223,9 @@ setOperator
: KW_UNION
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11106#issuecomment-181150749
**[Test build #50906 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50906/consoleFull)**
for PR 11106 at commit
Github user gatorsmile commented on the pull request:
https://github.com/apache/spark/pull/11106#issuecomment-181150882
@marmbrus @rxin I want to get your opinions first before adding the
corresponding Dataframe and Dataset APIs.
Now, `unionall` is changed to `union`, whose
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11106#issuecomment-181164076
**[Test build #50906 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50906/consoleFull)**
for PR 11106 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11106#issuecomment-181164212
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11106#issuecomment-181164211
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user gatorsmile commented on the pull request:
https://github.com/apache/spark/pull/11106#issuecomment-181199189
retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11106#issuecomment-181227734
**[Test build #50911 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50911/consoleFull)**
for PR 11106 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11106#issuecomment-181227828
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11106#issuecomment-181227825
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11106#issuecomment-181204620
**[Test build #50911 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50911/consoleFull)**
for PR 11106 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11106#issuecomment-180928249
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11106#issuecomment-180928248
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11106#issuecomment-180928225
**[Test build #50885 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50885/consoleFull)**
for PR 11106 at commit
GitHub user gatorsmile opened a pull request:
https://github.com/apache/spark/pull/11106
[SPARK-13225] [SQL] Support Intersect All/Distinct [WIP]
In the SQL2003 Syntax, INTERSECT supports both ALL and DISTINCT
```
INTERSECT [ALL | DISTINCT]
```
This PR
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11106#issuecomment-180913304
**[Test build #50885 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50885/consoleFull)**
for PR 11106 at commit
54 matches
Mail list logo
