[GitHub] spark pull request: [SPARK-13363][SQL] support Aggregator in Relat...

2016-04-17 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/12451 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is ena

[GitHub] spark pull request: [SPARK-13363][SQL] support Aggregator in Relat...

2016-04-17 Thread cloud-fan
Github user cloud-fan commented on the pull request: https://github.com/apache/spark/pull/12451#issuecomment-211224593 merging to master! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request: [SPARK-13363][SQL] support Aggregator in Relat...

2016-04-17 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/12451#issuecomment-211213074 Merging this failed on my laptop. Can you try merge this yourself? I think we are good to go since the failed tests are unrelated. --- If your project is set up for it,

[GitHub] spark pull request: [SPARK-13363][SQL] support Aggregator in Relat...

2016-04-17 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/12451#issuecomment-211212763 Merging in master. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feat

[GitHub] spark pull request: [SPARK-13363][SQL] support Aggregator in Relat...

2016-04-17 Thread cloud-fan
Github user cloud-fan commented on the pull request: https://github.com/apache/spark/pull/12451#issuecomment-211148786 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request: [SPARK-13363][SQL] support Aggregator in Relat...

2016-04-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12451#issuecomment-210993666 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] spark pull request: [SPARK-13363][SQL] support Aggregator in Relat...

2016-04-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12451#issuecomment-210993670 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/

[GitHub] spark pull request: [SPARK-13363][SQL] support Aggregator in Relat...

2016-04-17 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12451#issuecomment-210993233 **[Test build #56045 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/56045/consoleFull)** for PR 12451 at commit [`c06fbeb`](https://g

[GitHub] spark pull request: [SPARK-13363][SQL] support Aggregator in Relat...

2016-04-17 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12451#issuecomment-210983323 **[Test build #56045 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/56045/consoleFull)** for PR 12451 at commit [`c06fbeb`](https://gi

[GitHub] spark pull request: [SPARK-13363][SQL] support Aggregator in Relat...

2016-04-17 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/12451#issuecomment-210971239 Can you remove "race condition" in the description? It sounds like we actually have a race condition in the code base :) --- If your project is set up for it, you can re

[GitHub] spark pull request: [SPARK-13363][SQL] support Aggregator in Relat...

2016-04-17 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/12451#issuecomment-210971248 LGTM pending Jenkins. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this f

[GitHub] spark pull request: [SPARK-13363][SQL] support Aggregator in Relat...

2016-04-17 Thread cloud-fan
Github user cloud-fan commented on the pull request: https://github.com/apache/spark/pull/12451#issuecomment-210971179 cc @rxin --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] spark pull request: [SPARK-13363][SQL] support Aggregator in Relat...

2016-04-17 Thread cloud-fan
GitHub user cloud-fan opened a pull request: https://github.com/apache/spark/pull/12451 [SPARK-13363][SQL] support Aggregator in RelationalGroupedDataset ## What changes were proposed in this pull request? set the input encoder for `TypedColumn` in `RelationalGroupedDataset.

[GitHub] spark pull request: [SPARK-13363][SQL] support Aggregator in Relat...

2016-04-16 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/12359#issuecomment-210761087 Actually I had to revert it because it broke the build. Race condition. --- If your project is set up for it, you can reply to this email and have your reply appear on Gi

[GitHub] spark pull request: [SPARK-13363][SQL] support Aggregator in Relat...

2016-04-16 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/12359 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is ena

[GitHub] spark pull request: [SPARK-13363][SQL] support Aggregator in Relat...

2016-04-16 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/12359#issuecomment-210757262 Merging in master --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this featur

[GitHub] spark pull request: [SPARK-13363][SQL] support Aggregator in Relat...

2016-04-13 Thread yhuai
Github user yhuai commented on the pull request: https://github.com/apache/spark/pull/12359#issuecomment-209736578 LGTM. @liancheng want to do the final sign off? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your pr

[GitHub] spark pull request: [SPARK-13363][SQL] support Aggregator in Relat...

2016-04-13 Thread koertkuipers
Github user koertkuipers commented on the pull request: https://github.com/apache/spark/pull/12359#issuecomment-209535957 great, thanks for this --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not hav

[GitHub] spark pull request: [SPARK-13363][SQL] support Aggregator in Relat...

2016-04-13 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12359#issuecomment-209466067 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/

[GitHub] spark pull request: [SPARK-13363][SQL] support Aggregator in Relat...

2016-04-13 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12359#issuecomment-209466064 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] spark pull request: [SPARK-13363][SQL] support Aggregator in Relat...

2016-04-13 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12359#issuecomment-209465356 **[Test build #55711 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55711/consoleFull)** for PR 12359 at commit [`f4ec1ef`](https://g

[GitHub] spark pull request: [SPARK-13363][SQL] support Aggregator in Relat...

2016-04-13 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12359#issuecomment-209418978 **[Test build #55711 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55711/consoleFull)** for PR 12359 at commit [`f4ec1ef`](https://gi

[GitHub] spark pull request: [SPARK-13363][SQL] support Aggregator in Relat...

2016-04-13 Thread cloud-fan
Github user cloud-fan commented on the pull request: https://github.com/apache/spark/pull/12359#issuecomment-209417307 cc @yhuai @liancheng --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have th