Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/11278
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user vanzin commented on the pull request:
https://github.com/apache/spark/pull/11278#issuecomment-218230752
Merging to master / 2.0.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user markgrover commented on the pull request:
https://github.com/apache/spark/pull/11278#issuecomment-218229224
Would love to help, but I am not a committer:-)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user holdenk commented on the pull request:
https://github.com/apache/spark/pull/11278#issuecomment-218228742
If no one objects maybe @markgrover could just go ahead and merge this?
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user holdenk commented on the pull request:
https://github.com/apache/spark/pull/11278#issuecomment-217755544
ping @JoshRosen ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user holdenk commented on the pull request:
https://github.com/apache/spark/pull/11278#issuecomment-216657271
ping @jkbradley
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user holdenk commented on the pull request:
https://github.com/apache/spark/pull/11278#issuecomment-216304232
Since we've branched for 2.0 would this maybe be a good time to merge this?
---
If your project is set up for it, you can reply to this email and have your
reply
Github user markgrover commented on the pull request:
https://github.com/apache/spark/pull/11278#issuecomment-212146915
LGTM. +1 (non-binding)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user holdenk commented on the pull request:
https://github.com/apache/spark/pull/11278#issuecomment-212135544
Rad, wanted to make sure people were still up for adding a note about the
hive requirement even though we got rid of the assembly requirement. I've
changed it to just
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11278#issuecomment-212134688
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11278#issuecomment-212134685
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11278#issuecomment-212134560
**[Test build #56268 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/56268/consoleFull)**
for PR 11278 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11278#issuecomment-212132208
**[Test build #56268 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/56268/consoleFull)**
for PR 11278 at commit
Github user markgrover commented on the pull request:
https://github.com/apache/spark/pull/11278#issuecomment-212069360
Left some comments, overall, it's a change in the right direction. Thanks
for working on this, @holdenk!
---
If your project is set up for it, you can reply to
Github user markgrover commented on a diff in the pull request:
https://github.com/apache/spark/pull/11278#discussion_r60290371
--- Diff: docs/building-spark.md ---
@@ -123,6 +123,21 @@ To produce a Spark package compiled with Scala 2.10,
use the `-Dscala-2.10` prop
Github user markgrover commented on a diff in the pull request:
https://github.com/apache/spark/pull/11278#discussion_r60290250
--- Diff: docs/building-spark.md ---
@@ -123,6 +123,21 @@ To produce a Spark package compiled with Scala 2.10,
use the `-Dscala-2.10` prop
Github user holdenk commented on the pull request:
https://github.com/apache/spark/pull/11278#issuecomment-211697500
cc @markgrover who updated the building docs most recently, what are your
thoughts?
---
If your project is set up for it, you can reply to this email and have your
Github user holdenk commented on the pull request:
https://github.com/apache/spark/pull/11278#issuecomment-211162111
re-ping @JoshRosen thoughts?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11278#issuecomment-209661869
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11278#issuecomment-209661750
**[Test build #55746 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55746/consoleFull)**
for PR 11278 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11278#issuecomment-209661865
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11278#issuecomment-209657822
**[Test build #55746 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55746/consoleFull)**
for PR 11278 at commit
Github user holdenk commented on the pull request:
https://github.com/apache/spark/pull/11278#issuecomment-206493054
So looking at the PR which went in - it seems we don't need the assembly
jar but we do need to explicitly build with package & hive support for the
PySpark tests which
Github user holdenk commented on the pull request:
https://github.com/apache/spark/pull/11278#issuecomment-202976430
Ok - I can close this if we think thats going to be fixed soon (e.g. before
the next release).
---
If your project is set up for it, you can reply to this email and
Github user JoshRosen commented on the pull request:
https://github.com/apache/spark/pull/11278#issuecomment-201545515
This is going to be outdated soon, since there's ongoing effort to remove
the need to build assemblies before running tests.
---
If your project is set up for it,
Github user holdenk commented on the pull request:
https://github.com/apache/spark/pull/11278#issuecomment-200984687
Maybe @jkbradley could merge this? Super simple update.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11278#issuecomment-193431235
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11278#issuecomment-193431241
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11278#issuecomment-193431046
**[Test build #52586 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/52586/consoleFull)**
for PR 11278 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11278#issuecomment-193425529
**[Test build #52586 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/52586/consoleFull)**
for PR 11278 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11278#issuecomment-186432567
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11278#issuecomment-186432566
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11278#issuecomment-186432422
**[Test build #51577 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/51577/consoleFull)**
for PR 11278 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11278#issuecomment-186429602
**[Test build #51577 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/51577/consoleFull)**
for PR 11278 at commit
GitHub user holdenk opened a pull request:
https://github.com/apache/spark/pull/11278
[SPARK-13382][DOCS][PYSPARK] Update pyspark testing notes in build docs
## What changes were proposed in this pull request?
The current build documents don't specify that for PySpark tests
35 matches
Mail list logo
