Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/11584
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/11584#issuecomment-194007682
Thanks - merging in master.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user dongjoon-hyun commented on the pull request:
https://github.com/apache/spark/pull/11584#issuecomment-194004205
At last, it passed and there is no `Octal` warning.
Thank you all.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11584#issuecomment-194003516
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11584#issuecomment-194003514
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11584#issuecomment-194002875
**[Test build #52685 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/52685/consoleFull)**
for PR 11584 at commit
Github user dongjoon-hyun commented on the pull request:
https://github.com/apache/spark/pull/11584#issuecomment-193987270
Thank you for confirming that, @holdenk ! :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user holdenk commented on the pull request:
https://github.com/apache/spark/pull/11584#issuecomment-193982208
Looking at the build logs no Octal deprecation warnings - (still waiting on
the tests to finish but build part finished) :)
---
If your project is set up for it, you
Github user dongjoon-hyun commented on the pull request:
https://github.com/apache/spark/pull/11584#issuecomment-193953311
Yes. We should do double check Jenkins log although I've seen those two
lines in my local machine, too.
Thank you, @rxin and @holdenk .
---
If your project
Github user holdenk commented on the pull request:
https://github.com/apache/spark/pull/11584#issuecomment-193942199
LGTM pending tests, we should of course do a quick search in the resulting
build log and make sure no octal warnings show up but these are the two I had
seen when
Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/11584#issuecomment-193941994
LGTM pending tests.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/11584#discussion_r55417544
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/HiveQlSuite.scala ---
@@ -71,7 +71,7 @@ class HiveQlSuite extends SparkFunSuite with
Github user holdenk commented on a diff in the pull request:
https://github.com/apache/spark/pull/11584#discussion_r55417136
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/HiveQlSuite.scala ---
@@ -71,7 +71,7 @@ class HiveQlSuite extends SparkFunSuite with
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11584#issuecomment-193940888
**[Test build #52685 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/52685/consoleFull)**
for PR 11584 at commit
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/11584#discussion_r55416809
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/HiveQlSuite.scala ---
@@ -71,7 +71,7 @@ class HiveQlSuite extends SparkFunSuite with
GitHub user dongjoon-hyun opened a pull request:
https://github.com/apache/spark/pull/11584
[SPARK-13400] Stop using deprecated Octal escape literals
## What changes were proposed in this pull request?
This removes the remaining deprecated Octal escape literals. The
16 matches
Mail list logo
