[GitHub] spark pull request: [SPARK-13808][test-maven] Don't build assembly...

2016-03-22 Thread JoshRosen
Github user JoshRosen closed the pull request at: https://github.com/apache/spark/pull/11701 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: [SPARK-13808][test-maven] Don't build assembly...

2016-03-22 Thread JoshRosen
Github user JoshRosen commented on the pull request: https://github.com/apache/spark/pull/11701#issuecomment-200085578 I'm going to close this in favor of @vanzin's #11796 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.

[GitHub] spark pull request: [SPARK-13808][test-maven] Don't build assembly...

2016-03-20 Thread vanzin
Github user vanzin commented on the pull request: https://github.com/apache/spark/pull/11701#issuecomment-197529534 Hmmm. I think this is because this code in `load-spark-env.sh`: ``` if [ -z "$SPARK_SCALA_VERSION" ]; then USER_SCALA_VERSION_SET=0

[GitHub] spark pull request: [SPARK-13808][test-maven] Don't build assembly...

2016-03-19 Thread JoshRosen
Github user JoshRosen commented on the pull request: https://github.com/apache/spark/pull/11701#issuecomment-197535055 Since all of this code is going to be changed heavily / removed after your final patch, I'm going to go ahead and just leave the Maven test path unchanged so that we

[GitHub] spark pull request: [SPARK-13808][test-maven] Don't build assembly...

2016-03-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11701#issuecomment-197467017 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-13808][test-maven] Don't build assembly...

2016-03-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11701#issuecomment-197513303 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-13808][test-maven] Don't build assembly...

2016-03-19 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11701#issuecomment-197473498 **[Test build #5 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/5/consoleFull)** for PR 11701 at commit

[GitHub] spark pull request: [SPARK-13808][test-maven] Don't build assembly...

2016-03-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11701#issuecomment-198050192 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-13808][test-maven] Don't build assembly...

2016-03-19 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11701#issuecomment-197497522 **[Test build #53336 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/53336/consoleFull)** for PR 11701 at commit

[GitHub] spark pull request: [SPARK-13808][test-maven] Don't build assembly...

2016-03-19 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11701#issuecomment-197466993 **[Test build #53332 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/53332/consoleFull)** for PR 11701 at commit

[GitHub] spark pull request: [SPARK-13808][test-maven] Don't build assembly...

2016-03-19 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11701#issuecomment-198050158 **[Test build #53453 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/53453/consoleFull)** for PR 11701 at commit

[GitHub] spark pull request: [SPARK-13808][test-maven] Don't build assembly...

2016-03-19 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/11701#discussion_r56403772 --- Diff: bin/spark-class --- @@ -43,14 +43,14 @@ else SPARK_JARS_DIR="${SPARK_HOME}/assembly/target/scala-$SPARK_SCALA_VERSION" fi -if

[GitHub] spark pull request: [SPARK-13808][test-maven] Don't build assembly...

2016-03-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11701#issuecomment-197513296 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-13808][test-maven] Don't build assembly...

2016-03-19 Thread JoshRosen
Github user JoshRosen commented on a diff in the pull request: https://github.com/apache/spark/pull/11701#discussion_r56409246 --- Diff: python/run-tests.py --- @@ -54,10 +54,27 @@ def print_red(text): LOGGER = logging.getLogger() -def

[GitHub] spark pull request: [SPARK-13808][test-maven] Don't build assembly...

2016-03-19 Thread JoshRosen
Github user JoshRosen commented on the pull request: https://github.com/apache/spark/pull/11701#issuecomment-197459429 (Going to quickly make sure this also works with Maven tests, just to sanity-check) --- If your project is set up for it, you can reply to this email and have your

[GitHub] spark pull request: [SPARK-13808][test-maven] Don't build assembly...

2016-03-19 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11701#issuecomment-197513267 **[Test build #53336 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/53336/consoleFull)** for PR 11701 at commit

[GitHub] spark pull request: [SPARK-13808][test-maven] Don't build assembly...

2016-03-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11701#issuecomment-198010170 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-13808][test-maven] Don't build assembly...

2016-03-19 Thread vanzin
Github user vanzin commented on the pull request: https://github.com/apache/spark/pull/11701#issuecomment-197531138 BTW, I'm just waiting for this patch before working on SPARK-13579; so it's probably ok to keep building the assembly in the maven build, because it will become a lot

[GitHub] spark pull request: [SPARK-13808][test-maven] Don't build assembly...

2016-03-19 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11701#issuecomment-197480713 **[Test build #5 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/5/consoleFull)** for PR 11701 at commit

[GitHub] spark pull request: [SPARK-13808][test-maven] Don't build assembly...

2016-03-19 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/11701#discussion_r56409783 --- Diff: python/run-tests.py --- @@ -54,10 +54,27 @@ def print_red(text): LOGGER = logging.getLogger() -def

[GitHub] spark pull request: [SPARK-13808][test-maven] Don't build assembly...

2016-03-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11701#issuecomment-198010175 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-13808][test-maven] Don't build assembly...

2016-03-19 Thread JoshRosen
Github user JoshRosen commented on the pull request: https://github.com/apache/spark/pull/11701#issuecomment-198030480 Jenkins, retest this please. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-13808][test-maven] Don't build assembly...

2016-03-19 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11701#issuecomment-197460245 **[Test build #53332 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/53332/consoleFull)** for PR 11701 at commit

[GitHub] spark pull request: [SPARK-13808][test-maven] Don't build assembly...

2016-03-19 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11701#issuecomment-198010155 **[Test build #53443 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/53443/consoleFull)** for PR 11701 at commit

[GitHub] spark pull request: [SPARK-13808][test-maven] Don't build assembly...

2016-03-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11701#issuecomment-197467023 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-13808][test-maven] Don't build assembly...

2016-03-19 Thread JoshRosen
Github user JoshRosen commented on the pull request: https://github.com/apache/spark/pull/11701#issuecomment-197532812 Yeah, I literally _just_ found the same issue with the defaults in `load-spark-env.sh`. I wonder whether it would make sense to just have Maven set that variable

[GitHub] spark pull request: [SPARK-13808][test-maven] Don't build assembly...

2016-03-19 Thread vanzin
Github user vanzin commented on the pull request: https://github.com/apache/spark/pull/11701#issuecomment-197469805 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request: [SPARK-13808][test-maven] Don't build assembly...

2016-03-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11701#issuecomment-197480732 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-13808][test-maven] Don't build assembly...

2016-03-19 Thread JoshRosen
Github user JoshRosen commented on the pull request: https://github.com/apache/spark/pull/11701#issuecomment-197459367 Jenkins, retest this please. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-13808][test-maven] Don't build assembly...

2016-03-18 Thread JoshRosen
Github user JoshRosen commented on the pull request: https://github.com/apache/spark/pull/11701#issuecomment-198002898 Jenkins, retest this please. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-13808][test-maven] Don't build assembly...

2016-03-18 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11701#issuecomment-198004371 **[Test build #53443 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/53443/consoleFull)** for PR 11701 at commit

[GitHub] spark pull request: [SPARK-13808][test-maven] Don't build assembly...

2016-03-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11701#issuecomment-198050196 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-13808][test-maven] Don't build assembly...

2016-03-18 Thread vanzin
Github user vanzin commented on the pull request: https://github.com/apache/spark/pull/11701#issuecomment-197482988 Perhaps changing this in `bin/spark-class`: ``` if [ ! -d "$SPARK_JARS_DIR" ] && [ -z "$SPARK_TESTING" ] ; then echo "Failed to find Spark jars

[GitHub] spark pull request: [SPARK-13808][test-maven] Don't build assembly...

2016-03-18 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11701#issuecomment-198032504 **[Test build #53453 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/53453/consoleFull)** for PR 11701 at commit

[GitHub] spark pull request: [SPARK-13808][test-maven] Don't build assembly...

2016-03-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11701#issuecomment-197480734 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-13808][test-maven] Don't build assembly...

2016-03-18 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11701#issuecomment-197535911 **[Test build #53345 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/53345/consoleFull)** for PR 11701 at commit

[GitHub] spark pull request: [SPARK-13808][test-maven] Don't build assembly...

2016-03-18 Thread vanzin
Github user vanzin commented on the pull request: https://github.com/apache/spark/pull/11701#issuecomment-197482003 ``` 16/03/16 11:43:23.870 SparkLauncherSuite-2 INFO OutputRedirector: Failed to find Spark jars directory