[GitHub] spark pull request: [SPARK-13840] [SQL] Disable Project Pushdown T...

2016-03-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11682#issuecomment-196569575 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/

[GitHub] spark pull request: [SPARK-13840] [SQL] Disable Project Pushdown T...

2016-03-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11682#issuecomment-196569574 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] spark pull request: [SPARK-13840] [SQL] Disable Project Pushdown T...

2016-03-14 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11682#issuecomment-196569211 **[Test build #53116 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/53116/consoleFull)** for PR 11682 at commit [`608b901`](https://g

[GitHub] spark pull request: [SPARK-13840] [SQL] Disable Project Pushdown T...

2016-03-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11682#issuecomment-196566777 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/

[GitHub] spark pull request: [SPARK-13840] [SQL] Disable Project Pushdown T...

2016-03-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11682#issuecomment-196566772 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] spark pull request: [SPARK-13840] [SQL] Disable Project Pushdown T...

2016-03-14 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11682#issuecomment-196565770 **[Test build #53119 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/53119/consoleFull)** for PR 11682 at commit [`f1eee03`](https://g

[GitHub] spark pull request: [SPARK-13840] [SQL] Disable Project Pushdown T...

2016-03-14 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11682#issuecomment-196560475 **[Test build #53121 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/53121/consoleFull)** for PR 11682 at commit [`adf64da`](https://g

[GitHub] spark pull request: [SPARK-13840] [SQL] Disable Project Pushdown T...

2016-03-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11682#issuecomment-196560839 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] spark pull request: [SPARK-13840] [SQL] Disable Project Pushdown T...

2016-03-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11682#issuecomment-196560843 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/

[GitHub] spark pull request: [SPARK-13840] [SQL] Disable Project Pushdown T...

2016-03-14 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11682#issuecomment-196537010 **[Test build #53121 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/53121/consoleFull)** for PR 11682 at commit [`adf64da`](https://gi

[GitHub] spark pull request: [SPARK-13840] [SQL] Disable Project Pushdown T...

2016-03-14 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11682#issuecomment-196535654 **[Test build #53119 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/53119/consoleFull)** for PR 11682 at commit [`f1eee03`](https://gi

[GitHub] spark pull request: [SPARK-13840] [SQL] Disable Project Pushdown T...

2016-03-14 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11682#issuecomment-196531576 **[Test build #53116 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/53116/consoleFull)** for PR 11682 at commit [`608b901`](https://gi

[GitHub] spark pull request: [SPARK-13840] [SQL] Disable Project Pushdown T...

2016-03-14 Thread gatorsmile
Github user gatorsmile commented on the pull request: https://github.com/apache/spark/pull/11682#issuecomment-196442838 Yeah, that is a good idea. Let me try it. Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] spark pull request: [SPARK-13840] [SQL] Disable Project Pushdown T...

2016-03-14 Thread davies
Github user davies commented on the pull request: https://github.com/apache/spark/pull/11682#issuecomment-196433895 After some offline discussions with @marmbrus , we realized that these two rules may still conflict with each other if the Filter can'be pushed throughout the child (for

[GitHub] spark pull request: [SPARK-13840] [SQL] Disable Project Pushdown T...

2016-03-14 Thread gatorsmile
Github user gatorsmile commented on the pull request: https://github.com/apache/spark/pull/11682#issuecomment-196431220 @davies Will try to find a way to keep both. Will submit a separate PR for handling non-determisitic Filter. @marmbrus Yeah, your concern is valid. Will sub

[GitHub] spark pull request: [SPARK-13840] [SQL] Disable Project Pushdown T...

2016-03-14 Thread marmbrus
Github user marmbrus commented on the pull request: https://github.com/apache/spark/pull/11682#issuecomment-196425642 I'm worried that we are adding rules that aren't stable. Perhaps we should make the rule executor throw an error when the testing flag is set if we ever hit the maxim

[GitHub] spark pull request: [SPARK-13840] [SQL] Disable Project Pushdown T...

2016-03-14 Thread davies
Github user davies commented on the pull request: https://github.com/apache/spark/pull/11682#issuecomment-196423960 @gatorsmile Thanks for finding this. In general, both PushPredicateThroughProject and ColumnPruning are useful, we should keep both and fix the conflict (make them stabl

[GitHub] spark pull request: [SPARK-13840] [SQL] Disable Project Pushdown T...

2016-03-14 Thread gatorsmile
Github user gatorsmile commented on the pull request: https://github.com/apache/spark/pull/11682#issuecomment-196388382 @yhuai This was added in the recent change in `ColumnPruning`. 1.6 does not have such an issue. Thanks! --- If your project is set up for it, you can reply to this

[GitHub] spark pull request: [SPARK-13840] [SQL] Disable Project Pushdown T...

2016-03-14 Thread yhuai
Github user yhuai commented on the pull request: https://github.com/apache/spark/pull/11682#issuecomment-196380248 @gatorsmile Is this behavior new (introduced by a recent change) or previous versions of the optimizer also have the same behavior? --- If your project is set up for it,

[GitHub] spark pull request: [SPARK-13840] [SQL] Disable Project Pushdown T...

2016-03-13 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11682#issuecomment-196131490 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/

[GitHub] spark pull request: [SPARK-13840] [SQL] Disable Project Pushdown T...

2016-03-13 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11682#issuecomment-196131489 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] spark pull request: [SPARK-13840] [SQL] Disable Project Pushdown T...

2016-03-13 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11682#issuecomment-196131389 **[Test build #53046 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/53046/consoleFull)** for PR 11682 at commit [`e5e00ae`](https://g

[GitHub] spark pull request: [SPARK-13840] [SQL] Disable Project Pushdown T...

2016-03-13 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11682#issuecomment-196110718 **[Test build #53046 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/53046/consoleFull)** for PR 11682 at commit [`e5e00ae`](https://gi

[GitHub] spark pull request: [SPARK-13840] [SQL] Disable Project Pushdown T...

2016-03-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11682#issuecomment-195862035 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] spark pull request: [SPARK-13840] [SQL] Disable Project Pushdown T...

2016-03-12 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11682#issuecomment-195862015 **[Test build #53016 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/53016/consoleFull)** for PR 11682 at commit [`e128a0a`](https://g

[GitHub] spark pull request: [SPARK-13840] [SQL] Disable Project Pushdown T...

2016-03-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11682#issuecomment-195862036 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/

[GitHub] spark pull request: [SPARK-13840] [SQL] Disable Project Pushdown T...

2016-03-12 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11682#issuecomment-195850299 **[Test build #53016 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/53016/consoleFull)** for PR 11682 at commit [`e128a0a`](https://gi

[GitHub] spark pull request: [SPARK-13840] [SQL] Disable Project Pushdown T...

2016-03-12 Thread gatorsmile
GitHub user gatorsmile opened a pull request: https://github.com/apache/spark/pull/11682 [SPARK-13840] [SQL] Disable Project Pushdown Through Filter What changes were proposed in this pull request? Before this PR, two Optimizer rules `ColumnPruning` and `PushPredicateT