[GitHub] spark pull request: [SPARK-13885][YARN] Fix attempt id regression ...

2016-03-19 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/11721 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: [SPARK-13885][YARN] Fix attempt id regression ...

2016-03-19 Thread jerryshao
Github user jerryshao commented on the pull request: https://github.com/apache/spark/pull/11721#issuecomment-198152244 Ping @vazin, what about the current fix, would you please review again, thanks a lot. --- If your project is set up for it, you can reply to this email and have

[GitHub] spark pull request: [SPARK-13885][YARN] Fix attempt id regression ...

2016-03-19 Thread vanzin
Github user vanzin commented on the pull request: https://github.com/apache/spark/pull/11721#issuecomment-198463862 That vazin guy must be wondering why he was pinged. :-) Sorry, I've been busy with other things, I'll try to take a look today. --- If your project is set up for it,

[GitHub] spark pull request: [SPARK-13885][YARN] Fix attempt id regression ...

2016-03-19 Thread vanzin
Github user vanzin commented on the pull request: https://github.com/apache/spark/pull/11721#issuecomment-198513672 LGTM, merging to master. Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] spark pull request: [SPARK-13885][YARN] Fix attempt id regression ...

2016-03-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11721#issuecomment-197209163 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-13885][YARN] Fix attempt id regression ...

2016-03-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11721#issuecomment-197209169 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-13885][YARN] Fix attempt id regression ...

2016-03-16 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11721#issuecomment-197208742 **[Test build #53282 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/53282/consoleFull)** for PR 11721 at commit

[GitHub] spark pull request: [SPARK-13885][YARN] Fix attempt id regression ...

2016-03-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11721#issuecomment-197207834 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-13885][YARN] Fix attempt id regression ...

2016-03-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11721#issuecomment-197207836 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-13885][YARN] Fix attempt id regression ...

2016-03-16 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11721#issuecomment-197207642 **[Test build #53281 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/53281/consoleFull)** for PR 11721 at commit

[GitHub] spark pull request: [SPARK-13885][YARN] Fix attempt id regression ...

2016-03-16 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11721#issuecomment-197168676 **[Test build #53282 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/53282/consoleFull)** for PR 11721 at commit

[GitHub] spark pull request: [SPARK-13885][YARN] Fix attempt id regression ...

2016-03-16 Thread jerryshao
Github user jerryshao commented on a diff in the pull request: https://github.com/apache/spark/pull/11721#discussion_r56285494 --- Diff: yarn/src/main/scala/org/apache/spark/deploy/yarn/ApplicationMaster.scala --- @@ -133,12 +133,9 @@ private[spark] class ApplicationMaster(

[GitHub] spark pull request: [SPARK-13885][YARN] Fix attempt id regression ...

2016-03-16 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11721#issuecomment-197167540 **[Test build #53281 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/53281/consoleFull)** for PR 11721 at commit

[GitHub] spark pull request: [SPARK-13885][YARN] Fix attempt id regression ...

2016-03-15 Thread jerryshao
Github user jerryshao commented on a diff in the pull request: https://github.com/apache/spark/pull/11721#discussion_r56284175 --- Diff: core/src/main/scala/org/apache/spark/SparkContext.scala --- @@ -374,12 +374,6 @@ class SparkContext(config: SparkConf) extends Logging with

[GitHub] spark pull request: [SPARK-13885][YARN] Fix attempt id regression ...

2016-03-15 Thread jerryshao
Github user jerryshao commented on the pull request: https://github.com/apache/spark/pull/11721#issuecomment-197156547 I think `SchedulerExtensionService` can still be worked, since I still maintain the full attempt id in `YarnScheduler`, only change to the simple counter for Spark

[GitHub] spark pull request: [SPARK-13885][YARN] Fix attempt id regression ...

2016-03-15 Thread vanzin
Github user vanzin commented on the pull request: https://github.com/apache/spark/pull/11721#issuecomment-197074328 LGTM aside from small comment. @steveloughran should take a look since IIRC he wanted the full attempt id for something. --- If your project is set up for it,

[GitHub] spark pull request: [SPARK-13885][YARN] Fix attempt id regression ...

2016-03-15 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/11721#discussion_r56263000 --- Diff: core/src/main/scala/org/apache/spark/SparkContext.scala --- @@ -374,12 +374,6 @@ class SparkContext(config: SparkConf) extends Logging with

[GitHub] spark pull request: [SPARK-13885][YARN] Fix attempt id regression ...

2016-03-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11721#issuecomment-196780449 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-13885][YARN] Fix attempt id regression ...

2016-03-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11721#issuecomment-196780452 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-13885][YARN] Fix attempt id regression ...

2016-03-15 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11721#issuecomment-196780179 **[Test build #53183 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/53183/consoleFull)** for PR 11721 at commit

[GitHub] spark pull request: [SPARK-13885][YARN] Fix attempt id regression ...

2016-03-15 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11721#issuecomment-196731895 **[Test build #53183 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/53183/consoleFull)** for PR 11721 at commit

[GitHub] spark pull request: [SPARK-13885][YARN] Fix attempt id regression ...

2016-03-15 Thread jerryshao
GitHub user jerryshao opened a pull request: https://github.com/apache/spark/pull/11721 [SPARK-13885][YARN] Fix attempt id regression for Spark running on Yarn ## What changes were proposed in this pull request? This regression is introduced in #9182, previously attempt id