[GitHub] spark pull request: [SPARK-13922][SQL] Filter rows with null attri...

2016-03-20 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11749#issuecomment-197595389 **[Test build #53354 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/53354/consoleFull)** for PR 11749 at commit

[GitHub] spark pull request: [SPARK-13922][SQL] Filter rows with null attri...

2016-03-20 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/11749 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: [SPARK-13922][SQL] Filter rows with null attri...

2016-03-19 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11749#issuecomment-197556324 **[Test build #53354 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/53354/consoleFull)** for PR 11749 at commit

[GitHub] spark pull request: [SPARK-13922][SQL] Filter rows with null attri...

2016-03-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11749#issuecomment-197595610 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-13922][SQL] Filter rows with null attri...

2016-03-19 Thread nongli
Github user nongli commented on a diff in the pull request: https://github.com/apache/spark/pull/11749#discussion_r56416653 --- Diff: sql/core/src/main/java/org/apache/spark/sql/execution/vectorized/ColumnarBatch.java --- @@ -345,15 +358,25 @@ public void setColumn(int ordinal,

[GitHub] spark pull request: [SPARK-13922][SQL] Filter rows with null attri...

2016-03-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11749#issuecomment-197550621 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-13922][SQL] Filter rows with null attri...

2016-03-19 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11749#issuecomment-197505322 **[Test build #53338 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/53338/consoleFull)** for PR 11749 at commit

[GitHub] spark pull request: [SPARK-13922][SQL] Filter rows with null attri...

2016-03-19 Thread nongli
Github user nongli commented on the pull request: https://github.com/apache/spark/pull/11749#issuecomment-197553112 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] spark pull request: [SPARK-13922][SQL] Filter rows with null attri...

2016-03-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11749#issuecomment-197595608 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-13922][SQL] Filter rows with null attri...

2016-03-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11749#issuecomment-197550624 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-13922][SQL] Filter rows with null attri...

2016-03-19 Thread sameeragarwal
Github user sameeragarwal commented on the pull request: https://github.com/apache/spark/pull/11749#issuecomment-197504528 thanks, all comments addressed! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-13922][SQL] Filter rows with null attri...

2016-03-19 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11749#issuecomment-197550184 **[Test build #53338 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/53338/consoleFull)** for PR 11749 at commit

[GitHub] spark pull request: [SPARK-13922][SQL] Filter rows with null attri...

2016-03-19 Thread sameeragarwal
Github user sameeragarwal commented on a diff in the pull request: https://github.com/apache/spark/pull/11749#discussion_r56417640 --- Diff: sql/core/src/main/java/org/apache/spark/sql/execution/vectorized/ColumnarBatch.java --- @@ -345,15 +358,25 @@ public void setColumn(int

[GitHub] spark pull request: [SPARK-13922][SQL] Filter rows with null attri...

2016-03-15 Thread nongli
Github user nongli commented on the pull request: https://github.com/apache/spark/pull/11749#issuecomment-197135193 Can you add some test cases to columnarbatchsuite that exercises this? --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] spark pull request: [SPARK-13922][SQL] Filter rows with null attri...

2016-03-15 Thread nongli
Github user nongli commented on a diff in the pull request: https://github.com/apache/spark/pull/11749#discussion_r56277661 --- Diff: sql/core/src/main/java/org/apache/spark/sql/execution/vectorized/ColumnarBatch.java --- @@ -58,6 +58,9 @@ // True if the row is filtered.

[GitHub] spark pull request: [SPARK-13922][SQL] Filter rows with null attri...

2016-03-15 Thread nongli
Github user nongli commented on a diff in the pull request: https://github.com/apache/spark/pull/11749#discussion_r56277607 --- Diff: sql/core/src/main/java/org/apache/spark/sql/execution/vectorized/ColumnarBatch.java --- @@ -284,11 +287,23 @@ public void reset() { }

[GitHub] spark pull request: [SPARK-13922][SQL] Filter rows with null attri...

2016-03-15 Thread nongli
Github user nongli commented on a diff in the pull request: https://github.com/apache/spark/pull/11749#discussion_r56277494 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetReadBenchmark.scala --- @@ -299,10 +299,112 @@ object

[GitHub] spark pull request: [SPARK-13922][SQL] Filter rows with null attri...

2016-03-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11749#issuecomment-197123489 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-13922][SQL] Filter rows with null attri...

2016-03-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11749#issuecomment-197123483 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-13922][SQL] Filter rows with null attri...

2016-03-15 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11749#issuecomment-197122998 **[Test build #53253 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/53253/consoleFull)** for PR 11749 at commit

[GitHub] spark pull request: [SPARK-13922][SQL] Filter rows with null attri...

2016-03-15 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11749#issuecomment-197093877 **[Test build #53253 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/53253/consoleFull)** for PR 11749 at commit

[GitHub] spark pull request: [SPARK-13922][SQL] Filter rows with null attri...

2016-03-15 Thread sameeragarwal
Github user sameeragarwal commented on the pull request: https://github.com/apache/spark/pull/11749#issuecomment-197093496 cc @nongli --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request: [SPARK-13922][SQL] Filter rows with null attri...

2016-03-15 Thread sameeragarwal
GitHub user sameeragarwal opened a pull request: https://github.com/apache/spark/pull/11749 [SPARK-13922][SQL] Filter rows with null attributes in parquet vectorized reader ## What changes were proposed in this pull request? It's common for many SQL operators to not care