[GitHub] spark pull request: [SPARK-13949] PySpark ml DecisionTreeClassifie...

2016-03-23 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11892#issuecomment-200660088 **[Test build #2675 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2675/consoleFull)** for PR 11892 at commit [`bad5c3e`](https://

[GitHub] spark pull request: [SPARK-13949] PySpark ml DecisionTreeClassifie...

2016-03-23 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11892#issuecomment-200657826 **[Test build #2675 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2675/consoleFull)** for PR 11892 at commit [`bad5c3e`](https://g

[GitHub] spark pull request: [SPARK-13949] PySpark ml DecisionTreeClassifie...

2016-03-23 Thread jkbradley
Github user jkbradley commented on the pull request: https://github.com/apache/spark/pull/11892#issuecomment-200657678 add to whitelist --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this fe

[GitHub] spark pull request: [SPARK-13949] PySpark ml DecisionTreeClassifie...

2016-03-23 Thread GayathriMurali
Github user GayathriMurali commented on the pull request: https://github.com/apache/spark/pull/11892#issuecomment-200612255 @jkbradley This test is not starting automatically. Can you please issue the ok to test again? --- If your project is set up for it, you can reply to this email

[GitHub] spark pull request: [SPARK-13949] PySpark ml DecisionTreeClassifie...

2016-03-23 Thread jkbradley
Github user jkbradley commented on the pull request: https://github.com/apache/spark/pull/11892#issuecomment-200507784 OH! I think another issue is a PR which was merged yesterday which conflicts (silently) with this PR. Can you please merge with master? --- If your project is set u

[GitHub] spark pull request: [SPARK-13949] PySpark ml DecisionTreeClassifie...

2016-03-23 Thread jkbradley
Github user jkbradley commented on a diff in the pull request: https://github.com/apache/spark/pull/11892#discussion_r57221391 --- Diff: python/pyspark/ml/regression.py --- @@ -454,7 +466,7 @@ def _create_model(self, java_model): @inherit_doc -class DecisionTree

[GitHub] spark pull request: [SPARK-13949] PySpark ml DecisionTreeClassifie...

2016-03-23 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11892#issuecomment-200502059 **[Test build #2670 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2670/consoleFull)** for PR 11892 at commit [`015`](https://

[GitHub] spark pull request: [SPARK-13949] PySpark ml DecisionTreeClassifie...

2016-03-23 Thread jkbradley
Github user jkbradley commented on the pull request: https://github.com/apache/spark/pull/11892#issuecomment-200498681 LGTM pending tests Could you please fix the PR title to include the ML and Python tags: "[SPARK-13949][ML][PYTHON] ..."? Thanks! --- If your project is set

[GitHub] spark pull request: [SPARK-13949] PySpark ml DecisionTreeClassifie...

2016-03-23 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11892#issuecomment-200498412 **[Test build #2670 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2670/consoleFull)** for PR 11892 at commit [`015`](https://g

[GitHub] spark pull request: [SPARK-13949] PySpark ml DecisionTreeClassifie...

2016-03-23 Thread jkbradley
Github user jkbradley commented on the pull request: https://github.com/apache/spark/pull/11892#issuecomment-200495710 ok to test --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark pull request: [SPARK-13949] PySpark ml DecisionTreeClassifie...

2016-03-23 Thread jkbradley
Github user jkbradley commented on the pull request: https://github.com/apache/spark/pull/11892#issuecomment-200495533 Yes, I'll take a look now --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not hav

[GitHub] spark pull request: [SPARK-13949] PySpark ml DecisionTreeClassifie...

2016-03-23 Thread GayathriMurali
Github user GayathriMurali commented on the pull request: https://github.com/apache/spark/pull/11892#issuecomment-200462544 @jkbradley Can you please review this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If y

[GitHub] spark pull request: [SPARK-13949] PySpark ml DecisionTreeClassifie...

2016-03-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11892#issuecomment-199912143 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your p

[GitHub] spark pull request: [SPARK-13949] PySpark ml DecisionTreeClassifie...

2016-03-22 Thread GayathriMurali
GitHub user GayathriMurali opened a pull request: https://github.com/apache/spark/pull/11892 [SPARK-13949] PySpark ml DecisionTreeClassifier, Regressor support export/import ## What changes were proposed in this pull request? Added MLReadable and MLWritable to Decision Tree