Github user cloud-fan commented on the pull request:
https://github.com/apache/spark/pull/11846#issuecomment-201135401
Thanks, merging to master!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/11846
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11846#issuecomment-201131457
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11846#issuecomment-201131458
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11846#issuecomment-201131137
**[Test build #54138 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54138/consoleFull)**
for PR 11846 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11846#issuecomment-201113364
**[Test build #54138 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54138/consoleFull)**
for PR 11846 at commit
Github user gatorsmile commented on the pull request:
https://github.com/apache/spark/pull/11846#issuecomment-201113217
retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11846#issuecomment-201110821
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11846#issuecomment-201110824
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user gatorsmile commented on the pull request:
https://github.com/apache/spark/pull/11846#issuecomment-201107895
Thank you for your detailed review! :-)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/11846#discussion_r57412708
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -634,24 +641,26 @@ class Analyzer(
}
Github user cloud-fan commented on the pull request:
https://github.com/apache/spark/pull/11846#issuecomment-201091224
LGTM except one minor comment, thanks for working on it!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/11846#discussion_r57409753
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -634,24 +641,26 @@ class Analyzer(
}
}
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11846#issuecomment-201077359
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11846#issuecomment-201077355
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11846#issuecomment-201077040
**[Test build #54098 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54098/consoleFull)**
for PR 11846 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11846#issuecomment-201043064
**[Test build #54098 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54098/consoleFull)**
for PR 11846 at commit
Github user gatorsmile commented on the pull request:
https://github.com/apache/spark/pull/11846#issuecomment-201042074
retest this please.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11846#issuecomment-201036311
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11846#issuecomment-201036317
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11846#issuecomment-201035841
**[Test build #54059 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54059/consoleFull)**
for PR 11846 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11846#issuecomment-200937657
**[Test build #54059 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54059/consoleFull)**
for PR 11846 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11846#issuecomment-200170223
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11846#issuecomment-200170222
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11846#issuecomment-200170083
**[Test build #53876 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/53876/consoleFull)**
for PR 11846 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11846#issuecomment-200144900
**[Test build #53876 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/53876/consoleFull)**
for PR 11846 at commit
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/11846#discussion_r57099786
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -659,6 +669,40 @@ class Analyzer(
}
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/11846#discussion_r57091012
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -659,6 +669,40 @@ class Analyzer(
}
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/11846#discussion_r57028933
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -395,12 +396,19 @@ class Analyzer(
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/11846#discussion_r57022244
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -395,12 +396,19 @@ class Analyzer(
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/11846#discussion_r57021217
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -659,6 +669,40 @@ class Analyzer(
}
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/11846#discussion_r57004228
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -395,12 +396,19 @@ class Analyzer(
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/11846#discussion_r57004027
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -659,6 +669,40 @@ class Analyzer(
}
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/11846#discussion_r56993678
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -659,6 +669,40 @@ class Analyzer(
}
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/11846#discussion_r56991987
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -395,12 +396,19 @@ class Analyzer(
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/11846#discussion_r56991866
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -659,6 +669,40 @@ class Analyzer(
}
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/11846#discussion_r56991806
--- Diff: sql/core/src/test/scala/org/apache/spark/sql/SQLQuerySuite.scala
---
@@ -459,25 +460,103 @@ class SQLQuerySuite extends QueryTest with
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/11846#discussion_r56945948
--- Diff: sql/core/src/test/scala/org/apache/spark/sql/SQLQuerySuite.scala
---
@@ -459,25 +460,103 @@ class SQLQuerySuite extends QueryTest with
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/11846#discussion_r56945839
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -659,6 +669,40 @@ class Analyzer(
}
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/11846#discussion_r56945825
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -659,6 +669,40 @@ class Analyzer(
}
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/11846#discussion_r56945669
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -395,12 +396,19 @@ class Analyzer(
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11846#issuecomment-199667989
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11846#issuecomment-199667988
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11846#issuecomment-199667726
**[Test build #53746 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/53746/consoleFull)**
for PR 11846 at commit
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/11846#discussion_r56938713
--- Diff: sql/core/src/test/scala/org/apache/spark/sql/SQLQuerySuite.scala
---
@@ -459,25 +460,96 @@ class SQLQuerySuite extends QueryTest with
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11846#issuecomment-199642784
**[Test build #53746 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/53746/consoleFull)**
for PR 11846 at commit
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/11846#discussion_r56935150
--- Diff: sql/core/src/test/scala/org/apache/spark/sql/SQLQuerySuite.scala
---
@@ -459,25 +460,96 @@ class SQLQuerySuite extends QueryTest with
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11846#issuecomment-199628298
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11846#issuecomment-199628296
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11846#issuecomment-199628197
**[Test build #53737 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/53737/consoleFull)**
for PR 11846 at commit
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/11846#discussion_r56933487
--- Diff: sql/core/src/test/scala/org/apache/spark/sql/SQLQuerySuite.scala
---
@@ -459,25 +460,96 @@ class SQLQuerySuite extends QueryTest with
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/11846#discussion_r56933418
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -659,6 +662,40 @@ class Analyzer(
}
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/11846#discussion_r56930471
--- Diff: sql/core/src/test/scala/org/apache/spark/sql/SQLQuerySuite.scala
---
@@ -459,25 +460,96 @@ class SQLQuerySuite extends QueryTest with
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/11846#discussion_r56930227
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -659,6 +662,40 @@ class Analyzer(
}
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/11846#discussion_r56930101
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -659,6 +662,40 @@ class Analyzer(
}
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11846#issuecomment-199594034
**[Test build #53737 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/53737/consoleFull)**
for PR 11846 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11846#issuecomment-199559365
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11846#issuecomment-199559372
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11846#issuecomment-199558525
**[Test build #53723 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/53723/consoleFull)**
for PR 11846 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11846#issuecomment-199524853
**[Test build #53723 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/53723/consoleFull)**
for PR 11846 at commit
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/11846#discussion_r56909402
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -620,24 +627,26 @@ class Analyzer(
}
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/11846#discussion_r56909057
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -620,24 +627,26 @@ class Analyzer(
}
}
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11846#issuecomment-199514923
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11846#issuecomment-199514924
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11846#issuecomment-199514646
**[Test build #53710 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/53710/consoleFull)**
for PR 11846 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11846#issuecomment-199474981
**[Test build #53710 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/53710/consoleFull)**
for PR 11846 at commit
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/11846#discussion_r56788601
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -490,9 +495,15 @@ class Analyzer(
// If
Github user gatorsmile commented on the pull request:
https://github.com/apache/spark/pull/11846#issuecomment-199157290
BTW, I will submit a PR for eliminate useless group by columns in Optimizer
when they are foldable expressions/constants. Let me know if this is not
desirable.
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/11846#discussion_r56787965
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -490,9 +495,15 @@ class Analyzer(
//
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/11846#discussion_r56787412
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -490,9 +495,15 @@ class Analyzer(
// If
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11846#issuecomment-199151220
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11846#issuecomment-199151222
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11846#issuecomment-199151119
**[Test build #53657 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/53657/consoleFull)**
for PR 11846 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11846#issuecomment-199132631
**[Test build #53657 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/53657/consoleFull)**
for PR 11846 at commit
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/11846#discussion_r56778767
--- Diff: sql/core/src/test/scala/org/apache/spark/sql/SQLQuerySuite.scala
---
@@ -457,25 +459,96 @@ class SQLQuerySuite extends QueryTest with
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/11846#discussion_r56778755
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -490,9 +495,15 @@ class Analyzer(
//
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/11846#discussion_r56777991
--- Diff: sql/core/src/test/scala/org/apache/spark/sql/SQLQuerySuite.scala
---
@@ -457,25 +459,96 @@ class SQLQuerySuite extends QueryTest with
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/11846#discussion_r56777929
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -490,9 +495,15 @@ class Analyzer(
//
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11846#issuecomment-198858054
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11846#issuecomment-198858055
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11846#issuecomment-198858010
**[Test build #53624 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/53624/consoleFull)**
for PR 11846 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11846#issuecomment-198855031
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11846#issuecomment-198855030
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11846#issuecomment-198855002
**[Test build #53623 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/53623/consoleFull)**
for PR 11846 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11846#issuecomment-198846521
**[Test build #53624 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/53624/consoleFull)**
for PR 11846 at commit
Github user gatorsmile closed the pull request at:
https://github.com/apache/spark/pull/11846
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
GitHub user gatorsmile reopened a pull request:
https://github.com/apache/spark/pull/11846
[SPARK-13957] [SQL] Support Group By Ordinal in SQL
What changes were proposed in this pull request?
This PR is to support group by position in SQL. For example, when users
input the
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11846#issuecomment-198845243
**[Test build #53623 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/53623/consoleFull)**
for PR 11846 at commit
GitHub user gatorsmile opened a pull request:
https://github.com/apache/spark/pull/11846
[SPARK-13957] [SQL] Support Group By Ordinal in SQL
What changes were proposed in this pull request?
This PR is to support group by position in SQL. For example, when users
input the
89 matches
Mail list logo
