[GitHub] spark pull request: [SPARK-14000][SQL] case class with a tuple fie...

2016-03-21 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/11816 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is ena

[GitHub] spark pull request: [SPARK-14000][SQL] case class with a tuple fie...

2016-03-21 Thread liancheng
Github user liancheng commented on the pull request: https://github.com/apache/spark/pull/11816#issuecomment-199306929 LGTM, merging to master. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-14000][SQL] case class with a tuple fie...

2016-03-20 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/11816#discussion_r56622304 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/complexTypeExtractors.scala --- @@ -110,7 +110,12 @@ case class GetStructF

[GitHub] spark pull request: [SPARK-14000][SQL] case class with a tuple fie...

2016-03-20 Thread cloud-fan
Github user cloud-fan commented on the pull request: https://github.com/apache/spark/pull/11816#issuecomment-198242655 cc @rxin, this should fixes the failure in your https://github.com/apache/spark/pull/11737 --- If your project is set up for it, you can reply to this email and have

[GitHub] spark pull request: [SPARK-14000][SQL] case class with a tuple fie...

2016-03-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11816#issuecomment-198283547 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] spark pull request: [SPARK-14000][SQL] case class with a tuple fie...

2016-03-19 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/11816#issuecomment-198243335 thanks - looks good to me (but i don't know this code well enough). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] spark pull request: [SPARK-14000][SQL] case class with a tuple fie...

2016-03-19 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11816#issuecomment-198282574 **[Test build #53522 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/53522/consoleFull)** for PR 11816 at commit [`a40a130`](https://g

[GitHub] spark pull request: [SPARK-14000][SQL] case class with a tuple fie...

2016-03-19 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11816#issuecomment-198243100 **[Test build #53519 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/53519/consoleFull)** for PR 11816 at commit [`9dc7a7e`](https://g

[GitHub] spark pull request: [SPARK-14000][SQL] case class with a tuple fie...

2016-03-19 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11816#issuecomment-198245670 **[Test build #53522 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/53522/consoleFull)** for PR 11816 at commit [`a40a130`](https://gi

[GitHub] spark pull request: [SPARK-14000][SQL] case class with a tuple fie...

2016-03-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11816#issuecomment-198283549 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/

[GitHub] spark pull request: [SPARK-14000][SQL] case class with a tuple fie...

2016-03-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11816#issuecomment-198243101 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] spark pull request: [SPARK-14000][SQL] case class with a tuple fie...

2016-03-19 Thread cloud-fan
Github user cloud-fan commented on the pull request: https://github.com/apache/spark/pull/11816#issuecomment-198244900 cc @marmbrus --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this featur

[GitHub] spark pull request: [SPARK-14000][SQL] case class with a tuple fie...

2016-03-19 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11816#issuecomment-198242888 **[Test build #53519 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/53519/consoleFull)** for PR 11816 at commit [`9dc7a7e`](https://gi

[GitHub] spark pull request: [SPARK-14000][SQL] case class with a tuple fie...

2016-03-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11816#issuecomment-198243102 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/

[GitHub] spark pull request: [SPARK-14000][SQL] case class with a tuple fie...

2016-03-19 Thread cloud-fan
GitHub user cloud-fan opened a pull request: https://github.com/apache/spark/pull/11816 [SPARK-14000][SQL] case class with a tuple field can't work in Dataset ## What changes were proposed in this pull request? When we validate an encoder, we may call `dataType` on unresolve