Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/11822
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is ena
Github user yhuai commented on the pull request:
https://github.com/apache/spark/pull/11822#issuecomment-199403527
Thanks! Merging to master.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have t
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11822#issuecomment-199403129
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11822#issuecomment-199403126
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11822#issuecomment-199402756
**[Test build #53681 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/53681/consoleFull)**
for PR 11822 at commit
[`9d7b1db`](https://g
Github user marmbrus commented on the pull request:
https://github.com/apache/spark/pull/11822#issuecomment-199395784
LGTM pending tests. The original signature is from very early on when I
thought you could refer to a table both by name and alias.
---
If your project is set up for
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11822#issuecomment-199358936
**[Test build #53681 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/53681/consoleFull)**
for PR 11822 at commit
[`9d7b1db`](https://gi
Github user cloud-fan commented on the pull request:
https://github.com/apache/spark/pull/11822#issuecomment-199238363
Overall LGTM, I think it's more clear to have `qualifier` as a `Option`
instead of `Seq`.
---
If your project is set up for it, you can reply to this email and have
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/11822#discussion_r56810312
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/namedExpressions.scala
---
@@ -264,18 +264,18 @@ case class AttributeRefer
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/11822#discussion_r56810267
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/namedExpressions.scala
---
@@ -197,9 +197,9 @@ case class Alias(child: Exp
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/11822#discussion_r56810191
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/namedExpressions.scala
---
@@ -122,17 +122,17 @@ abstract class Attribute
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/11822#discussion_r56810209
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/namedExpressions.scala
---
@@ -122,17 +122,17 @@ abstract class Attribute
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/11822#discussion_r56810093
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -1438,7 +1438,7 @@ object CleanupAliases extends Rule[L
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11822#issuecomment-198403531
**[Test build #53540 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/53540/consoleFull)**
for PR 11822 at commit
[`59241ec`](https://gi
GitHub user liancheng opened a pull request:
https://github.com/apache/spark/pull/11822
[SPARK-14004][SQL] NamedExpressions should have at most one qualifier
## What changes were proposed in this pull request?
This is a more aggressive version of PR #11820, which not only fi
Github user liancheng commented on the pull request:
https://github.com/apache/spark/pull/11822#issuecomment-198318534
Personally, I had once been quite confused by the fact that
`NamedExpression.qualifiers` is a `Seq[String]` and thought that attributes can
be qualified with multiple
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11822#issuecomment-198321275
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11822#issuecomment-198316006
**[Test build #53534 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/53534/consoleFull)**
for PR 11822 at commit
[`c1f08b0`](https://gi
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11822#issuecomment-198454313
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11822#issuecomment-198321256
**[Test build #53534 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/53534/consoleFull)**
for PR 11822 at commit
[`c1f08b0`](https://g
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11822#issuecomment-198453885
**[Test build #53540 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/53540/consoleFull)**
for PR 11822 at commit
[`59241ec`](https://g
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11822#issuecomment-198663184
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11822#issuecomment-198663185
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11822#issuecomment-198663137
**[Test build #53601 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/53601/consoleFull)**
for PR 11822 at commit
[`cbef382`](https://g
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11822#issuecomment-198634038
**[Test build #53601 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/53601/consoleFull)**
for PR 11822 at commit
[`cbef382`](https://gi
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11822#issuecomment-198454319
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11822#issuecomment-198321277
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
27 matches
Mail list logo
