[GitHub] spark pull request: [SPARK-14011][CORE][SQL] Enable `LineLength` J...

2016-03-21 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the pull request: https://github.com/apache/spark/pull/11831#issuecomment-199165962 Thank you, @srowen ! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-14011][CORE][SQL] Enable `LineLength` J...

2016-03-21 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/11831 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: [SPARK-14011][CORE][SQL] Enable `LineLength` J...

2016-03-21 Thread srowen
Github user srowen commented on the pull request: https://github.com/apache/spark/pull/11831#issuecomment-199163647 Merged to master --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request: [SPARK-14011][CORE][SQL] Enable `LineLength` J...

2016-03-20 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11831#issuecomment-198549581 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-14011][CORE][SQL] Enable `LineLength` J...

2016-03-20 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the pull request: https://github.com/apache/spark/pull/11831#issuecomment-198547361 Thank you, @srowen . The change looks a bit verbose here. But, as you said, I'm sure that the direction is right and is needed. The code will remain

[GitHub] spark pull request: [SPARK-14011][CORE][SQL] Enable `LineLength` J...

2016-03-20 Thread dongjoon-hyun
Github user dongjoon-hyun commented on a diff in the pull request: https://github.com/apache/spark/pull/11831#discussion_r56762305 --- Diff: core/src/main/java/org/apache/spark/api/java/function/DoubleFunction.java --- @@ -23,5 +23,5 @@ * A function that returns Doubles,

[GitHub] spark pull request: [SPARK-14011][CORE][SQL] Enable `LineLength` J...

2016-03-20 Thread dongjoon-hyun
Github user dongjoon-hyun commented on a diff in the pull request: https://github.com/apache/spark/pull/11831#discussion_r56762251 --- Diff: core/src/main/java/org/apache/spark/api/java/function/DoubleFunction.java --- @@ -23,5 +23,5 @@ * A function that returns Doubles,

[GitHub] spark pull request: [SPARK-14011][CORE][SQL] Enable `LineLength` J...

2016-03-20 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/11831#discussion_r56761160 --- Diff: core/src/main/java/org/apache/spark/api/java/function/DoubleFunction.java --- @@ -23,5 +23,5 @@ * A function that returns Doubles, and can

[GitHub] spark pull request: [SPARK-14011][CORE][SQL] Enable `LineLength` J...

2016-03-20 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/11831#discussion_r56761167 --- Diff: core/src/test/java/org/apache/spark/JavaAPISuite.java --- @@ -54,7 +54,7 @@ import org.apache.hadoop.mapred.SequenceFileOutputFormat;

[GitHub] spark pull request: [SPARK-14011][CORE][SQL] Enable `LineLength` J...

2016-03-19 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11831#issuecomment-198549526 **[Test build #53566 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/53566/consoleFull)** for PR 11831 at commit

[GitHub] spark pull request: [SPARK-14011][CORE][SQL] Enable `LineLength` J...

2016-03-19 Thread srowen
Github user srowen commented on the pull request: https://github.com/apache/spark/pull/11831#issuecomment-198546490 All of the changes are OK, and a step in the right direction. I hesitate a bit just because it's a big change just for style, but, probably a good idea to go ahead and

[GitHub] spark pull request: [SPARK-14011][CORE][SQL] Enable `LineLength` J...

2016-03-19 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11831#issuecomment-198547025 **[Test build #53569 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/53569/consoleFull)** for PR 11831 at commit

[GitHub] spark pull request: [SPARK-14011][CORE][SQL] Enable `LineLength` J...

2016-03-19 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11831#issuecomment-198543400 **[Test build #53563 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/53563/consoleFull)** for PR 11831 at commit

[GitHub] spark pull request: [SPARK-14011][CORE][SQL] Enable `LineLength` J...

2016-03-19 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11831#issuecomment-198543525 **[Test build #53566 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/53566/consoleFull)** for PR 11831 at commit

[GitHub] spark pull request: [SPARK-14011][CORE][SQL] Enable `LineLength` J...

2016-03-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11831#issuecomment-198543431 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-14011][CORE][SQL] Enable `LineLength` J...

2016-03-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11831#issuecomment-198549576 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-14011][CORE][SQL] Enable `LineLength` J...

2016-03-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11831#issuecomment-198673005 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-14011][CORE][SQL] Enable `LineLength` J...

2016-03-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11831#issuecomment-198673009 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-14011][CORE][SQL] Enable `LineLength` J...

2016-03-19 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11831#issuecomment-198672685 **[Test build #53609 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/53609/consoleFull)** for PR 11831 at commit

[GitHub] spark pull request: [SPARK-14011][CORE][SQL] Enable `LineLength` J...

2016-03-19 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11831#issuecomment-198648881 **[Test build #53609 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/53609/consoleFull)** for PR 11831 at commit

[GitHub] spark pull request: [SPARK-14011][CORE][SQL] Enable `LineLength` J...

2016-03-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11831#issuecomment-198543430 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-14011][CORE][SQL] Enable `LineLength` J...

2016-03-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11831#issuecomment-198592965 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-14011][CORE][SQL] Enable `LineLength` J...

2016-03-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11831#issuecomment-198592964 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-14011][CORE][SQL] Enable `LineLength` J...

2016-03-18 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11831#issuecomment-198592647 **[Test build #53569 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/53569/consoleFull)** for PR 11831 at commit