[GitHub] spark pull request: [SPARK-14167][MINOR] Remove redundant `returns...

2016-03-25 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the pull request: https://github.com/apache/spark/pull/11968#issuecomment-201523593 Thank you for quick review. I closed that Jira issue a minute ago. --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] spark pull request: [SPARK-14167][MINOR] Remove redundant `returns...

2016-03-25 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the pull request: https://github.com/apache/spark/pull/11968#issuecomment-201522515 Oh, I see. I will close the JIRA. By the way, may I fix that minor Java lint error here with changed title? --- If your project is set up for it, you can

[GitHub] spark pull request: [SPARK-14167][MINOR] Remove redundant `returns...

2016-03-25 Thread JoshRosen
Github user JoshRosen commented on the pull request: https://github.com/apache/spark/pull/11968#issuecomment-201520626 I'm actually wary of this change. There's a number of times where I've found redundant returns but have chosen not to remove them because I was afraid of future code

[GitHub] spark pull request: [SPARK-14167][MINOR] Remove redundant `returns...

2016-03-25 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11968#issuecomment-201516673 **[Test build #54217 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54217/consoleFull)** for PR 11968 at commit

[GitHub] spark pull request: [SPARK-14167][MINOR] Remove redundant `returns...

2016-03-25 Thread dongjoon-hyun
GitHub user dongjoon-hyun opened a pull request: https://github.com/apache/spark/pull/11968 [SPARK-14167][MINOR] Remove redundant `returns` in Scala code. ## What changes were proposed in this pull request? Spark Scala code takes advantage of `return` statement as a control