Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/11971
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is ena
Github user vanzin commented on the pull request:
https://github.com/apache/spark/pull/11971#issuecomment-202624330
LGTM, merging to master.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have th
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11971#issuecomment-202575599
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11971#issuecomment-202575596
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11971#issuecomment-202575103
**[Test build #54335 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54335/consoleFull)**
for PR 11971 at commit
[`47187d8`](https://g
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11971#issuecomment-202516301
**[Test build #54335 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54335/consoleFull)**
for PR 11971 at commit
[`47187d8`](https://gi
Github user zsxwing commented on a diff in the pull request:
https://github.com/apache/spark/pull/11971#discussion_r57603613
--- Diff:
core/src/main/scala/org/apache/spark/util/UninterruptibleThread.scala ---
@@ -0,0 +1,106 @@
+/*
+ * Licensed to the Apache Software Foundat
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/11971#discussion_r57603003
--- Diff:
core/src/main/scala/org/apache/spark/util/UninterruptibleThread.scala ---
@@ -0,0 +1,106 @@
+/*
+ * Licensed to the Apache Software Foundati
Github user zsxwing commented on a diff in the pull request:
https://github.com/apache/spark/pull/11971#discussion_r57602452
--- Diff:
core/src/main/scala/org/apache/spark/util/UninterruptibleThread.scala ---
@@ -0,0 +1,106 @@
+/*
+ * Licensed to the Apache Software Foundat
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/11971#discussion_r57601601
--- Diff:
core/src/main/scala/org/apache/spark/util/UninterruptibleThread.scala ---
@@ -0,0 +1,106 @@
+/*
+ * Licensed to the Apache Software Foundati
Github user zsxwing commented on a diff in the pull request:
https://github.com/apache/spark/pull/11971#discussion_r57600647
--- Diff:
core/src/main/scala/org/apache/spark/util/UninterruptibleThread.scala ---
@@ -0,0 +1,106 @@
+/*
+ * Licensed to the Apache Software Foundat
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/11971#discussion_r57521413
--- Diff:
core/src/main/scala/org/apache/spark/util/UninterruptibleThread.scala ---
@@ -0,0 +1,106 @@
+/*
+ * Licensed to the Apache Software Foundati
Github user vanzin commented on the pull request:
https://github.com/apache/spark/pull/11971#issuecomment-201960142
Yes, my suggestion would make the whole thread uninterruptible. But from
the only use case, it seems that would be ok - there are no calls I see that
can be interrupted
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11971#issuecomment-201719199
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11971#issuecomment-201719198
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11971#issuecomment-201719152
**[Test build #54250 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54250/consoleFull)**
for PR 11971 at commit
[`8a65a9d`](https://g
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11971#issuecomment-201703542
**[Test build #54250 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54250/consoleFull)**
for PR 11971 at commit
[`8a65a9d`](https://gi
Github user zsxwing commented on the pull request:
https://github.com/apache/spark/pull/11971#issuecomment-201703467
retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this fe
Github user zsxwing commented on the pull request:
https://github.com/apache/spark/pull/11971#issuecomment-201703258
> LGTM but I wonder if just overriding Thread.run and making it final
wouldn't be enough (the task to run would have to be passed as a Runnable). It
would simplify the
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11971#issuecomment-201647819
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11971#issuecomment-201647814
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11971#issuecomment-201647391
**[Test build #54235 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54235/consoleFull)**
for PR 11971 at commit
[`8a65a9d`](https://g
Github user vanzin commented on the pull request:
https://github.com/apache/spark/pull/11971#issuecomment-201604050
LGTM but I wonder if just overriding `Thread.run` and making it final
wouldn't be enough (the task to run would have to be passed as a `Runnable`).
It would simplify the
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11971#issuecomment-201596033
**[Test build #54235 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54235/consoleFull)**
for PR 11971 at commit
[`8a65a9d`](https://gi
GitHub user zsxwing opened a pull request:
https://github.com/apache/spark/pull/11971
[SPARK-14169][Core]Add UninterruptibleThread
## What changes were proposed in this pull request?
Extract the workaround for HADOOP-10622 introduced by #11940 into
UninterruptibleThread so
25 matches
Mail list logo
