Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/12079
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user MLnick commented on the pull request:
https://github.com/apache/spark/pull/12079#issuecomment-210121149
LGTM. Merged to master.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12079#issuecomment-210117010
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12079#issuecomment-210116690
**[Test build #55839 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55839/consoleFull)**
for PR 12079 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12079#issuecomment-210117012
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12079#issuecomment-210111381
**[Test build #55839 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55839/consoleFull)**
for PR 12079 at commit
Github user MLnick commented on the pull request:
https://github.com/apache/spark/pull/12079#issuecomment-210110142
jenkins retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user MLnick commented on the pull request:
https://github.com/apache/spark/pull/12079#issuecomment-209049583
As per @jkbradley's
https://github.com/apache/spark/pull/12308#issuecomment-209039855, let's keep
them separate params.
---
If your project is set up for it, you can
Github user holdenk commented on the pull request:
https://github.com/apache/spark/pull/12079#issuecomment-208974760
@BryanCutler / @yongtang That sounds reasonable :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user BryanCutler commented on the pull request:
https://github.com/apache/spark/pull/12079#issuecomment-208970035
> @holdenk @BryanCutler we could merge this and #12308, and then update the
param to be shared (if we can do the different doc thing?).
I think that will
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12079#issuecomment-208919727
**[Test build #55608 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55608/consoleFull)**
for PR 12079 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12079#issuecomment-208919990
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12079#issuecomment-208919995
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user yongtang commented on the pull request:
https://github.com/apache/spark/pull/12079#issuecomment-208917286
Thanks @MLnick I just updated the pull request to address several minor
issues. With respect to `. Default False` vs `. (default: False)`, I changed it
to `. Default
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12079#issuecomment-208914227
**[Test build #55608 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55608/consoleFull)**
for PR 12079 at commit
Github user MLnick commented on the pull request:
https://github.com/apache/spark/pull/12079#issuecomment-208797154
A few minor comments, otherwise LGTM.
@holdenk @BryanCutler we could merge this and #12308, and then update the
param to be shared (if we can do the different
Github user MLnick commented on a diff in the pull request:
https://github.com/apache/spark/pull/12079#discussion_r59341296
--- Diff: python/pyspark/ml/feature.py ---
@@ -512,14 +512,19 @@ class HashingTF(JavaTransformer, HasInputCol,
HasOutputCol, HasNumFeatures, Java
..
Github user MLnick commented on a diff in the pull request:
https://github.com/apache/spark/pull/12079#discussion_r59341354
--- Diff: python/pyspark/mllib/feature.py ---
@@ -379,6 +379,17 @@ class HashingTF(object):
"""
def __init__(self, numFeatures=1 << 20):
Github user MLnick commented on a diff in the pull request:
https://github.com/apache/spark/pull/12079#discussion_r59339176
--- Diff: python/pyspark/ml/tests.py ---
@@ -831,6 +831,25 @@ def test_logistic_regression_summary(self):
Github user MLnick commented on a diff in the pull request:
https://github.com/apache/spark/pull/12079#discussion_r59338971
--- Diff: python/pyspark/ml/feature.py ---
@@ -512,14 +512,19 @@ class HashingTF(JavaTransformer, HasInputCol,
HasOutputCol, HasNumFeatures, Java
..
Github user MLnick commented on a diff in the pull request:
https://github.com/apache/spark/pull/12079#discussion_r59338620
--- Diff: python/pyspark/ml/feature.py ---
@@ -512,14 +512,19 @@ class HashingTF(JavaTransformer, HasInputCol,
HasOutputCol, HasNumFeatures, Java
..
Github user holdenk commented on a diff in the pull request:
https://github.com/apache/spark/pull/12079#discussion_r59334159
--- Diff: python/pyspark/ml/feature.py ---
@@ -512,14 +512,19 @@ class HashingTF(JavaTransformer, HasInputCol,
HasOutputCol, HasNumFeatures, Java
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12079#issuecomment-208700359
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12079#issuecomment-208700356
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12079#issuecomment-208700160
**[Test build #55587 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55587/consoleFull)**
for PR 12079 at commit
Github user yongtang commented on the pull request:
https://github.com/apache/spark/pull/12079#issuecomment-208697614
@holdenk The Scala implementation has ben completed in SPARK-13963. I
updated the description of this pull request to show the linkage between this
issue
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12079#issuecomment-208696634
**[Test build #55587 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55587/consoleFull)**
for PR 12079 at commit
Github user yongtang commented on a diff in the pull request:
https://github.com/apache/spark/pull/12079#discussion_r59319063
--- Diff: python/pyspark/mllib/feature.py ---
@@ -379,6 +379,17 @@ class HashingTF(object):
"""
def __init__(self, numFeatures=1 << 20):
Github user yongtang commented on a diff in the pull request:
https://github.com/apache/spark/pull/12079#discussion_r59318934
--- Diff: python/pyspark/ml/feature.py ---
@@ -512,14 +512,19 @@ class HashingTF(JavaTransformer, HasInputCol,
HasOutputCol, HasNumFeatures, Java
Github user BryanCutler commented on a diff in the pull request:
https://github.com/apache/spark/pull/12079#discussion_r59299261
--- Diff: python/pyspark/mllib/feature.py ---
@@ -379,6 +379,17 @@ class HashingTF(object):
"""
def __init__(self, numFeatures=1 <<
Github user holdenk commented on a diff in the pull request:
https://github.com/apache/spark/pull/12079#discussion_r59273122
--- Diff: python/pyspark/ml/feature.py ---
@@ -512,14 +512,19 @@ class HashingTF(JavaTransformer, HasInputCol,
HasOutputCol, HasNumFeatures, Java
Github user holdenk commented on the pull request:
https://github.com/apache/spark/pull/12079#issuecomment-208538911
One minor note:Often we want to go with Scala first then Python, but in
either direction if we are only doing one at a time it can be good practice to
create either a
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12079#issuecomment-208384386
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12079#issuecomment-208384380
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12079#issuecomment-208384272
**[Test build #55524 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55524/consoleFull)**
for PR 12079 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12079#issuecomment-208380065
**[Test build #55524 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55524/consoleFull)**
for PR 12079 at commit
Github user yongtang commented on the pull request:
https://github.com/apache/spark/pull/12079#issuecomment-208378950
Rebased to fix conflicts.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12079#issuecomment-204013573
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12079#issuecomment-204013576
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12079#issuecomment-204013346
**[Test build #54642 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54642/consoleFull)**
for PR 12079 at commit
Github user yongtang commented on a diff in the pull request:
https://github.com/apache/spark/pull/12079#discussion_r58083774
--- Diff: python/pyspark/ml/feature.py ---
@@ -512,6 +512,16 @@ class HashingTF(JavaTransformer, HasInputCol,
HasOutputCol, HasNumFeatures, Java
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12079#issuecomment-204007123
**[Test build #54642 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54642/consoleFull)**
for PR 12079 at commit
Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/12079#discussion_r58073256
--- Diff: python/pyspark/ml/feature.py ---
@@ -512,6 +512,16 @@ class HashingTF(JavaTransformer, HasInputCol,
HasOutputCol, HasNumFeatures, Java
Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/12079#discussion_r58073185
--- Diff: python/pyspark/ml/feature.py ---
@@ -520,6 +530,7 @@ def __init__(self, numFeatures=1 << 18, inputCol=None,
outputCol=None):
Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/12079#discussion_r58072895
--- Diff: python/pyspark/ml/feature.py ---
@@ -512,6 +512,16 @@ class HashingTF(JavaTransformer, HasInputCol,
HasOutputCol, HasNumFeatures, Java
Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/12079#discussion_r58072522
--- Diff: python/pyspark/ml/feature.py ---
@@ -512,6 +512,16 @@ class HashingTF(JavaTransformer, HasInputCol,
HasOutputCol, HasNumFeatures, Java
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12079#issuecomment-203973486
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12079#issuecomment-203973488
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12079#issuecomment-203973259
**[Test build #54631 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54631/consoleFull)**
for PR 12079 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12079#issuecomment-203968139
**[Test build #54631 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54631/consoleFull)**
for PR 12079 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12079#issuecomment-203944274
**[Test build #54623 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54623/consoleFull)**
for PR 12079 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12079#issuecomment-203944299
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12079#issuecomment-203944303
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12079#issuecomment-203943491
**[Test build #54623 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54623/consoleFull)**
for PR 12079 at commit
Github user MLnick commented on the pull request:
https://github.com/apache/spark/pull/12079#issuecomment-203941636
ok to test
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12079#issuecomment-203741023
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
GitHub user yongtang opened a pull request:
https://github.com/apache/spark/pull/12079
[SPARK-14238][ML][MLLIB][PYSPARK] Add binary toggle Param to PySpark
HashingTF in ML & MLlib
## What changes were proposed in this pull request?
This fix tries to add binary toggle Param
57 matches
Mail list logo
