Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12099#issuecomment-204654670
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12099#issuecomment-204654669
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12099#issuecomment-204654619
**[Test build #54759 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54759/consoleFull)**
for PR 12099 at commit
[`9334fa9`](https://g
Github user dongjoon-hyun commented on the pull request:
https://github.com/apache/spark/pull/12099#issuecomment-204652575
Thank you, @rxin , @hvanhovell , @andrewor14 , and @DeepSparkBot . :)
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/12099
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is ena
Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/12099#issuecomment-204650933
Thanks - going to merge this in master.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project do
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12099#issuecomment-204649298
**[Test build #2728 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2728/consoleFull)**
for PR 12099 at commit
[`7b10a51`](https://
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12099#issuecomment-204642011
**[Test build #54759 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54759/consoleFull)**
for PR 12099 at commit
[`9334fa9`](https://gi
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/12099#discussion_r58288294
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveExplainSuite.scala
---
@@ -101,4 +101,19 @@ class HiveExplainSuite extends Q
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/12099#discussion_r58288094
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveExplainSuite.scala
---
@@ -101,4 +101,19 @@ class HiveExplainSuite extends QueryTest
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12099#issuecomment-204640856
**[Test build #2728 has
started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2728/consoleFull)**
for PR 12099 at commit
[`7b10a51`](https://g
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12099#issuecomment-204618176
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12099#issuecomment-204618175
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12099#issuecomment-204618122
**[Test build #54736 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54736/consoleFull)**
for PR 12099 at commit
[`7b10a51`](https://g
Github user dongjoon-hyun commented on the pull request:
https://github.com/apache/spark/pull/12099#issuecomment-204603217
I updated the code according to @DeepSparkBot 's comments, and also rebased
to the master since master branch is now Scala 2.11.8.
It took sometime to test loc
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12099#issuecomment-204603119
**[Test build #54736 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54736/consoleFull)**
for PR 12099 at commit
[`7b10a51`](https://gi
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12099#issuecomment-204601255
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12099#issuecomment-204601258
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12099#issuecomment-204600076
**[Test build #54717 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54717/consoleFull)**
for PR 12099 at commit
[`497a93e`](https://g
Github user dongjoon-hyun commented on the pull request:
https://github.com/apache/spark/pull/12099#issuecomment-204591610
Oh, I see. Thank you, @andrewor14 !
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your proje
Github user DeepSparkBot commented on the pull request:
https://github.com/apache/spark/pull/12099#issuecomment-204589471
@andrewor14 Review complete. No major issues found.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well.
Github user DeepSparkBot commented on a diff in the pull request:
https://github.com/apache/spark/pull/12099#discussion_r58275215
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/debug/package.scala ---
@@ -48,6 +48,25 @@ package object debug {
// scalastyl
Github user DeepSparkBot commented on a diff in the pull request:
https://github.com/apache/spark/pull/12099#discussion_r58275150
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/commands.scala
---
@@ -237,15 +237,18 @@ case class ExplainCommand(
l
Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/12099#issuecomment-204587861
You need to say: deep-review this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your proj
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12099#issuecomment-204585811
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12099#issuecomment-204585808
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12099#issuecomment-204585214
**[Test build #54713 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54713/consoleFull)**
for PR 12099 at commit
[`11efbbb`](https://g
Github user dongjoon-hyun commented on the pull request:
https://github.com/apache/spark/pull/12099#issuecomment-204567123
One minor thing, why @DeepSparkBot does not visit this PR?
Today, @DeepSparkBot came to my other PR. :)
---
If your project is set up for it, you can reply
Github user dongjoon-hyun commented on the pull request:
https://github.com/apache/spark/pull/12099#issuecomment-204565788
Now, `EXPLAIN CODEGEN` is the logically same with `debugCodegen`. I updated
the description of this PR, too.
---
If your project is set up for it, you can reply
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12099#issuecomment-204564887
**[Test build #54717 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54717/consoleFull)**
for PR 12099 at commit
[`497a93e`](https://gi
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/12099#discussion_r58265346
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/commands.scala
---
@@ -237,15 +237,18 @@ case class ExplainCommand(
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/12099#discussion_r58265199
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/commands.scala
---
@@ -237,15 +237,18 @@ case class ExplainCommand(
logicalPl
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/12099#discussion_r58264981
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/commands.scala
---
@@ -237,15 +237,18 @@ case class ExplainCommand(
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/12099#discussion_r58264352
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/commands.scala
---
@@ -237,15 +237,18 @@ case class ExplainCommand(
logicalPl
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/12099#discussion_r58264076
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/commands.scala
---
@@ -237,15 +237,18 @@ case class ExplainCommand(
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/12099#discussion_r58260060
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/commands.scala
---
@@ -237,15 +237,18 @@ case class ExplainCommand(
logicalPl
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12099#issuecomment-204549678
**[Test build #54713 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54713/consoleFull)**
for PR 12099 at commit
[`11efbbb`](https://gi
Github user dongjoon-hyun commented on the pull request:
https://github.com/apache/spark/pull/12099#issuecomment-204547543
Hi, @rxin . `debugCodegenString` is removed and `DebuggingSuite` is
modified accordingly.
---
If your project is set up for it, you can reply to this email and
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/12099#discussion_r58257745
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/debug/package.scala ---
@@ -81,29 +100,11 @@ package object debug {
* WholeS
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/12099#discussion_r58254140
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/debug/package.scala ---
@@ -81,29 +100,11 @@ package object debug {
* WholeStageCodeg
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/12099#discussion_r58243529
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/commands.scala
---
@@ -237,15 +237,18 @@ case class ExplainCommand(
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/12099#discussion_r58243106
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/debug/package.scala ---
@@ -81,29 +100,11 @@ package object debug {
* WholeS
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/12099#discussion_r58166528
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveExplainSuite.scala
---
@@ -101,4 +101,19 @@ class HiveExplainSuite extends Quer
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/12099#discussion_r58166375
--- Diff:
sql/catalyst/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBase.g4 ---
@@ -576,7 +576,7 @@ frameBound
explainOption
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/12099#discussion_r58165643
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/commands.scala
---
@@ -237,15 +237,18 @@ case class ExplainCommand(
logicalPl
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/12099#discussion_r58165608
--- Diff:
sql/catalyst/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBase.g4 ---
@@ -576,7 +576,7 @@ frameBound
explainOption
-
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/12099#discussion_r58165593
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveExplainSuite.scala
---
@@ -101,4 +101,19 @@ class HiveExplainSuite extends QueryTest
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/12099#discussion_r58165570
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/debug/package.scala ---
@@ -81,29 +100,11 @@ package object debug {
* WholeStageCodeg
Github user dongjoon-hyun commented on the pull request:
https://github.com/apache/spark/pull/12099#issuecomment-204193533
Hi, @rxin .
Could you review this PR?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12099#issuecomment-204191621
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12099#issuecomment-204191619
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12099#issuecomment-204191093
**[Test build #54673 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54673/consoleFull)**
for PR 12099 at commit
[`83c3c01`](https://g
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12099#issuecomment-204181437
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12099#issuecomment-204181436
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12099#issuecomment-204181205
**[Test build #54669 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54669/consoleFull)**
for PR 12099 at commit
[`4e750e5`](https://g
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12099#issuecomment-204160580
**[Test build #54673 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54673/consoleFull)**
for PR 12099 at commit
[`83c3c01`](https://gi
Github user dongjoon-hyun commented on the pull request:
https://github.com/apache/spark/pull/12099#issuecomment-204160591
Hi, @hvanhovell .
I updated the PR according to your comments. For the real generated code, I
think it's safe to maintain the first three lines since that will
Github user dongjoon-hyun commented on the pull request:
https://github.com/apache/spark/pull/12099#issuecomment-204154576
Thank you, @hvanhovell .
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user hvanhovell commented on the pull request:
https://github.com/apache/spark/pull/12099#issuecomment-204154130
@dongjoon-hyun I left a few small comments. Looks pretty solid overall.
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/12099#discussion_r58136850
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveExplainSuite.scala
---
@@ -101,4 +101,19 @@ class HiveExplainSuite extends Quer
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/12099#discussion_r58136464
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/SparkSqlParser.scala ---
@@ -122,9 +122,10 @@ class SparkSqlAstBuilder extends AstBuilder
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/12099#discussion_r58136340
--- Diff:
sql/catalyst/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBase.g4 ---
@@ -576,7 +576,7 @@ frameBound
explainOption
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12099#issuecomment-204151657
**[Test build #54669 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54669/consoleFull)**
for PR 12099 at commit
[`4e750e5`](https://gi
GitHub user dongjoon-hyun opened a pull request:
https://github.com/apache/spark/pull/12099
[SPARK-14251][SQL] Add SQL command for printing out generated code for
debugging
## What changes were proposed in this pull request?
This PR implements `EXPLAIN CODEGEN` SQL command.
64 matches
Mail list logo
