Github user jkbradley commented on the pull request:
https://github.com/apache/spark/pull/12089#issuecomment-208612860
Weird the merge_spark_pr script merged the wrong PR. Reverting...
---
If your project is set up for it, you can reply to this email and have your
reply appear on Git
Github user jkbradley commented on the pull request:
https://github.com/apache/spark/pull/12089#issuecomment-208611907
Backported to 1.6 and 1.5 as well now
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user yanboliang commented on the pull request:
https://github.com/apache/spark/pull/12089#issuecomment-207947315
@jkbradley Sent #12286 for unit test, please help to review. Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/12089
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is ena
Github user jkbradley commented on the pull request:
https://github.com/apache/spark/pull/12089#issuecomment-207553189
Thanks for updating it!
LGTM
Merging with master
Since this was a bug from before, let's add a unit test. It should be easy
to write a unit test now
Github user yanboliang commented on the pull request:
https://github.com/apache/spark/pull/12089#issuecomment-207203933
@jkbradley It's ready for review now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12089#issuecomment-207203369
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12089#issuecomment-207203368
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12089#issuecomment-207203292
**[Test build #55310 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55310/consoleFull)**
for PR 12089 at commit
[`4af96d8`](https://g
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12089#issuecomment-207197076
**[Test build #55310 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55310/consoleFull)**
for PR 12089 at commit
[`4af96d8`](https://gi
Github user yanboliang commented on the pull request:
https://github.com/apache/spark/pull/12089#issuecomment-207196623
Jenkins, test this please.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not h
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12089#issuecomment-206798460
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12089#issuecomment-206798462
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12089#issuecomment-206798429
**[Test build #55214 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55214/consoleFull)**
for PR 12089 at commit
[`4af96d8`](https://g
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12089#issuecomment-206795517
**[Test build #55214 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55214/consoleFull)**
for PR 12089 at commit
[`4af96d8`](https://gi
Github user yanboliang commented on the pull request:
https://github.com/apache/spark/pull/12089#issuecomment-206795002
Jenkins, test this please.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not h
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12089#issuecomment-206794626
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12089#issuecomment-206794598
**[Test build #55213 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55213/consoleFull)**
for PR 12089 at commit
[`4af96d8`](https://g
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12089#issuecomment-206794625
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user yanboliang commented on the pull request:
https://github.com/apache/spark/pull/12089#issuecomment-205843565
@jkbradley Agree, I will update the PR soon.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user jkbradley commented on the pull request:
https://github.com/apache/spark/pull/12089#issuecomment-205635716
Thanks for catching this. I'd prefer we make the change in
PeriodicCheckpointer. That way, LDA with EM will still call
PeriodicCheckpointer, which can handle persis
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12089#issuecomment-203990639
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12089#issuecomment-203990368
**[Test build #54636 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54636/consoleFull)**
for PR 12089 at commit
[`a5c0343`](https://g
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12089#issuecomment-203990645
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12089#issuecomment-203977504
**[Test build #54636 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54636/consoleFull)**
for PR 12089 at commit
[`a5c0343`](https://gi
GitHub user yanboliang opened a pull request:
https://github.com/apache/spark/pull/12089
[SPARK-14298] [ML] [MLlib] LDA should support disable checkpoint
## What changes were proposed in this pull request?
LDA should support disable checkpoint by setting checkpointInterval = -1
26 matches
Mail list logo
