Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/12683
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is ena
Github user GayathriMurali commented on a diff in the pull request:
https://github.com/apache/spark/pull/12683#discussion_r61481184
--- Diff: R/pkg/inst/tests/testthat/test_mllib.R ---
@@ -71,7 +71,25 @@ test_that("glm and predict", {
data = iris, family = poisson(li
Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/12683#discussion_r61437879
--- Diff: R/pkg/inst/tests/testthat/test_mllib.R ---
@@ -71,7 +71,25 @@ test_that("glm and predict", {
data = iris, family = poisson(link =
Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/12683#discussion_r61437435
--- Diff: R/pkg/inst/tests/testthat/test_mllib.R ---
@@ -71,7 +71,25 @@ test_that("glm and predict", {
data = iris, family = poisson(link =
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12683#issuecomment-215315114
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12683#issuecomment-215315097
**[Test build #57218 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/57218/consoleFull)**
for PR 12683 at commit
[`6650890`](https://g
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12683#issuecomment-215315113
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12683#issuecomment-215310647
**[Test build #57218 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/57218/consoleFull)**
for PR 12683 at commit
[`6650890`](https://gi
Github user yanboliang commented on the pull request:
https://github.com/apache/spark/pull/12683#issuecomment-215308071
@GayathriMurali You should modify
[```RWrappers.load```](https://github.com/apache/spark/blob/master/mllib/src/main/scala/org/apache/spark/ml/r/RWrappers.scala#L44)
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12683#issuecomment-215307044
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12683#issuecomment-215307026
**[Test build #57211 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/57211/consoleFull)**
for PR 12683 at commit
[`55523f7`](https://g
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12683#issuecomment-215307046
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12683#issuecomment-215302215
**[Test build #57211 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/57211/consoleFull)**
for PR 12683 at commit
[`55523f7`](https://gi
Github user GayathriMurali commented on a diff in the pull request:
https://github.com/apache/spark/pull/12683#discussion_r61370053
--- Diff: R/pkg/R/mllib.R ---
@@ -406,6 +432,8 @@ ml.load <- function(path) {
jobj <- callJStatic("org.apache.spark.ml.r.RWrappers", "load", pat
Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/12683#discussion_r61369473
--- Diff: R/pkg/R/mllib.R ---
@@ -406,6 +432,8 @@ ml.load <- function(path) {
jobj <- callJStatic("org.apache.spark.ml.r.RWrappers", "load", path)
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12683#issuecomment-215297705
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12683#issuecomment-215297703
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12683#issuecomment-215297686
**[Test build #57204 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/57204/consoleFull)**
for PR 12683 at commit
[`be0e52f`](https://g
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12683#issuecomment-215289906
**[Test build #57204 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/57204/consoleFull)**
for PR 12683 at commit
[`be0e52f`](https://gi
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12683#issuecomment-215272520
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12683#issuecomment-215272519
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12683#issuecomment-215272500
**[Test build #57194 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/57194/consoleFull)**
for PR 12683 at commit
[`c044552`](https://g
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12683#issuecomment-215266976
**[Test build #57194 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/57194/consoleFull)**
for PR 12683 at commit
[`c044552`](https://gi
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12683#issuecomment-215260818
**[Test build #57189 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/57189/consoleFull)**
for PR 12683 at commit
[`d2e5968`](https://g
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12683#issuecomment-215260853
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12683#issuecomment-215260854
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12683#issuecomment-215253529
**[Test build #57189 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/57189/consoleFull)**
for PR 12683 at commit
[`d2e5968`](https://gi
Github user mengxr commented on the pull request:
https://github.com/apache/spark/pull/12683#issuecomment-215234428
@yanboliang Please `LGTM` if the changes look good to you:)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as wel
Github user mengxr commented on the pull request:
https://github.com/apache/spark/pull/12683#issuecomment-215233578
@GayathriMurali Please run `dev/lint-r` locally to check R style.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12683#issuecomment-215231822
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12683#issuecomment-215231824
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12683#issuecomment-215231813
**[Test build #57175 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/57175/consoleFull)**
for PR 12683 at commit
[`dbacbe6`](https://g
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12683#issuecomment-215230891
**[Test build #57175 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/57175/consoleFull)**
for PR 12683 at commit
[`dbacbe6`](https://gi
Github user mengxr commented on the pull request:
https://github.com/apache/spark/pull/12683#issuecomment-215230608
ok to test
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
ena
Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/12683#discussion_r61067079
--- Diff: R/pkg/inst/tests/testthat/test_mllib.R ---
@@ -126,6 +126,18 @@ test_that("glm summary", {
expect_true(abs(baseSummary$deviance - 12.19313
Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/12683#discussion_r61066822
--- Diff: R/pkg/R/mllib.R ---
@@ -83,6 +83,54 @@ setMethod("glm", signature(formula = "formula", family =
"ANY", data = "SparkDat
return(
Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/12683#discussion_r61066737
--- Diff: R/pkg/R/mllib.R ---
@@ -83,6 +83,54 @@ setMethod("glm", signature(formula = "formula", family =
"ANY", data = "SparkDat
return(
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12683#issuecomment-214607333
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your p
GitHub user GayathriMurali opened a pull request:
https://github.com/apache/spark/pull/12683
[SPARK-14315][SparkR]Add model persistence to GLMs
## What changes were proposed in this pull request?
Add model persistence to GLMs in SparkR
Unit tests added
Y
39 matches
Mail list logo
