[GitHub] spark pull request: [SPARK-14322] [MLlib] Use treeAggregate instea...

2016-04-06 Thread jkbradley
Github user jkbradley commented on the pull request: https://github.com/apache/spark/pull/12106#issuecomment-206507031 LGTM Merging with master, and backporting to 1.6, 1.5, 1.4 if possible Thanks! --- If your project is set up for it, you can reply to this email and have

[GitHub] spark pull request: [SPARK-14322] [MLlib] Use treeAggregate instea...

2016-04-06 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/12106 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: [SPARK-14322] [MLlib] Use treeAggregate instea...

2016-04-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12106#issuecomment-206098700 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-14322] [MLlib] Use treeAggregate instea...

2016-04-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12106#issuecomment-206098699 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-14322] [MLlib] Use treeAggregate instea...

2016-04-05 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12106#issuecomment-206098633 **[Test build #55081 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55081/consoleFull)** for PR 12106 at commit

[GitHub] spark pull request: [SPARK-14322] [MLlib] Use treeAggregate instea...

2016-04-05 Thread hhbyyh
Github user hhbyyh commented on a diff in the pull request: https://github.com/apache/spark/pull/12106#discussion_r58645358 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/clustering/LDAOptimizer.scala --- @@ -451,10 +451,10 @@ final class OnlineLDAOptimizer extends

[GitHub] spark pull request: [SPARK-14322] [MLlib] Use treeAggregate instea...

2016-04-05 Thread hhbyyh
Github user hhbyyh commented on the pull request: https://github.com/apache/spark/pull/12106#issuecomment-206094396 @jkbradley Updated. I used flatMap to replace the second reduce. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] spark pull request: [SPARK-14322] [MLlib] Use treeAggregate instea...

2016-04-05 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12106#issuecomment-206089752 **[Test build #55081 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55081/consoleFull)** for PR 12106 at commit

[GitHub] spark pull request: [SPARK-14322] [MLlib] Use treeAggregate instea...

2016-04-05 Thread jkbradley
Github user jkbradley commented on a diff in the pull request: https://github.com/apache/spark/pull/12106#discussion_r58586792 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/clustering/LDAOptimizer.scala --- @@ -451,10 +451,10 @@ final class OnlineLDAOptimizer extends

[GitHub] spark pull request: [SPARK-14322] [MLlib] Use treeAggregate instea...

2016-04-04 Thread hhbyyh
Github user hhbyyh commented on a diff in the pull request: https://github.com/apache/spark/pull/12106#discussion_r58478599 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/clustering/LDAOptimizer.scala --- @@ -451,10 +451,10 @@ final class OnlineLDAOptimizer extends