Github user dongjoon-hyun commented on the pull request:
https://github.com/apache/spark/pull/12185#issuecomment-208045636
Thank you, @yhuai and @rxin .
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/12185
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user yhuai commented on the pull request:
https://github.com/apache/spark/pull/12185#issuecomment-208042408
Thanks. Merging to master.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12185#issuecomment-207970827
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12185#issuecomment-207970828
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12185#issuecomment-207970780
**[Test build #55477 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55477/consoleFull)**
for PR 12185 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12185#issuecomment-207954158
**[Test build #55477 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55477/consoleFull)**
for PR 12185 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12185#issuecomment-207945571
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12185#issuecomment-207945569
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12185#issuecomment-207945178
**[Test build #55468 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55468/consoleFull)**
for PR 12185 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12185#issuecomment-207944504
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12185#issuecomment-207944164
**[Test build #55467 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55467/consoleFull)**
for PR 12185 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12185#issuecomment-207944508
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12185#issuecomment-207934550
**[Test build #55467 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55467/consoleFull)**
for PR 12185 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12185#issuecomment-207934524
**[Test build #55468 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55468/consoleFull)**
for PR 12185 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12185#issuecomment-207892977
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12185#issuecomment-207892976
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12185#issuecomment-207892952
**[Test build #55455 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55455/consoleFull)**
for PR 12185 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12185#issuecomment-207886559
**[Test build #55455 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55455/consoleFull)**
for PR 12185 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12185#issuecomment-207885835
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12185#issuecomment-207885838
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12185#issuecomment-207885821
**[Test build #55454 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55454/consoleFull)**
for PR 12185 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12185#issuecomment-207885734
**[Test build #55454 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55454/consoleFull)**
for PR 12185 at commit
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/12185#discussion_r59123665
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/conditionalExpressions.scala
---
@@ -23,7 +23,10 @@ import
Github user dongjoon-hyun commented on the pull request:
https://github.com/apache/spark/pull/12185#issuecomment-207879147
Thank you. I agree. I will apply them all related descriptions.
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user yhuai commented on the pull request:
https://github.com/apache/spark/pull/12185#issuecomment-207878267
Yea. I feel that `calculated from values of a group` is a little bit
better.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user dongjoon-hyun commented on the pull request:
https://github.com/apache/spark/pull/12185#issuecomment-207875330
Since I just borrowed from the Hive, it seems to be weird. I think we can
improve them in this PR as much as possible.
---
If your project is set up for it, you
Github user dongjoon-hyun commented on the pull request:
https://github.com/apache/spark/pull/12185#issuecomment-207874641
Sure. You mean
'Returns the XXX of a set of numbers' -> 'Returns the XXX calculated from
values of a group'
Right?
---
If your project is set up for it,
Github user yhuai commented on the pull request:
https://github.com/apache/spark/pull/12185#issuecomment-207870340
For those aggregate functions, I feel it is better to mention that they are
calculated from values of a group instead of just saying from a set of values?
---
If your
Github user dongjoon-hyun commented on the pull request:
https://github.com/apache/spark/pull/12185#issuecomment-207867755
Oh, @yhuai . Thank you for deep and detail review!
I'll fix all of them and improve as possible as I can.
---
If your project is set up for it, you can reply
Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/12185#discussion_r59122611
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala
---
@@ -445,6 +483,11 @@ case class
Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/12185#discussion_r59122487
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala
---
@@ -396,6 +422,9 @@ case class
Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/12185#discussion_r59122479
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala
---
@@ -325,6 +337,11 @@ case class
Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/12185#discussion_r59122443
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala
---
@@ -270,6 +277,11 @@ object StringTranslate {
Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/12185#discussion_r59122416
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/nullExpressions.scala
---
@@ -34,6 +34,9 @@ import
Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/12185#discussion_r59122336
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/conditionalExpressions.scala
---
@@ -23,7 +23,10 @@ import
Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/12185#discussion_r59122307
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala
---
@@ -26,6 +26,8 @@ import
Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/12185#discussion_r59122271
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/Last.scala
---
@@ -28,6 +28,8 @@ import
Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/12185#discussion_r59122269
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/HyperLogLogPlusPlus.scala
---
@@ -48,6 +46,8 @@ import
Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/12185#discussion_r59122255
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/First.scala
---
@@ -28,6 +28,8 @@ import
Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/12185#discussion_r59122216
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/CentralMomentAgg.scala
---
@@ -157,6 +161,8 @@ case class
Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/12185#discussion_r59122207
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/CentralMomentAgg.scala
---
@@ -130,6 +130,8 @@ abstract class
Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/12185#discussion_r59122188
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/Average.scala
---
@@ -23,6 +23,8 @@ import
Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/12185#discussion_r59122172
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/Average.scala
---
@@ -23,6 +23,8 @@ import
Github user dongjoon-hyun commented on the pull request:
https://github.com/apache/spark/pull/12185#issuecomment-207847958
Thank you so much! @rxin :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/12185#issuecomment-207741410
This is super useful.
@yhuai can you review this?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user dongjoon-hyun commented on the pull request:
https://github.com/apache/spark/pull/12185#issuecomment-207552180
Hi, @rxin .
Could you give me some directional advice to improve this PR?
---
If your project is set up for it, you can reply to this email and have your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12185#issuecomment-207232368
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12185#issuecomment-207232378
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12185#issuecomment-207231858
**[Test build #55313 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55313/consoleFull)**
for PR 12185 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12185#issuecomment-207208700
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12185#issuecomment-207208694
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12185#issuecomment-207207725
**[Test build #55304 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55304/consoleFull)**
for PR 12185 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12185#issuecomment-207205808
**[Test build #55313 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55313/consoleFull)**
for PR 12185 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12185#issuecomment-207191187
**[Test build #55304 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55304/consoleFull)**
for PR 12185 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12185#issuecomment-207176086
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12185#issuecomment-207176082
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12185#issuecomment-207175533
**[Test build #55283 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55283/consoleFull)**
for PR 12185 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12185#issuecomment-207147484
**[Test build #55283 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55283/consoleFull)**
for PR 12185 at commit
59 matches
Mail list logo
