Github user bomeng closed the pull request at:
https://github.com/apache/spark/pull/12347
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is ena
Github user bomeng commented on the pull request:
https://github.com/apache/spark/pull/12347#issuecomment-214518666
closing this PR. thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have th
Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/12347#issuecomment-213683729
Yea the current tests are pretty scattered and they are way too big to
merge into a single one. Can you just close this pull request? Thanks.
---
If your project is set
Github user bomeng commented on the pull request:
https://github.com/apache/spark/pull/12347#issuecomment-209622770
Ok, not a problem. Thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/12347#issuecomment-209600458
@gatorsmile that's a good point. I think a better goal of the issue is to
make the tests consistent and make sure the functionality of the test suites
are clearly is
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12347#issuecomment-209217404
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12347#issuecomment-209217405
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12347#issuecomment-209217278
**[Test build #55680 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55680/consoleFull)**
for PR 12347 at commit
[`06c8948`](https://g
Github user gatorsmile commented on the pull request:
https://github.com/apache/spark/pull/12347#issuecomment-209200845
To be honest, I do not know why we need to merge these test case files.
Their purposes are different. One is to verify the functionalities of parsers;
another is to
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12347#issuecomment-209200120
**[Test build #55680 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55680/consoleFull)**
for PR 12347 at commit
[`06c8948`](https://gi
Github user gatorsmile commented on the pull request:
https://github.com/apache/spark/pull/12347#issuecomment-209200210
```Use .contains(...) instead == Some(...) for Options, this method is
introduced in Scala 2.11 and it is recommended method to use for this
purpose;```
This sho
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/12347#discussion_r59485621
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/HiveDDLCommandSuite.scala ---
@@ -113,10 +244,10 @@ class HiveDDLCommandSuite extends PlanTest
GitHub user bomeng opened a pull request:
https://github.com/apache/spark/pull/12347
[SPARK-14441] [SQL] Consolidate DDL tests
## What changes were proposed in this pull request?
Today we have `DDLSuite`, `DDLCommandSuite`, `HiveDDLCommandSuite` and
`HiveDDLSuite`. In this
13 matches
Mail list logo
