Github user jfchen commented on the pull request:
https://github.com/apache/spark/pull/12598#issuecomment-217296388
@davies @yzhou2001 thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user yzhou2001 commented on the pull request:
https://github.com/apache/spark/pull/12598#issuecomment-217294960
As mentioned in the description, the NPE is due to
https://issues.apache.org/jira/browse/SPARK-14752.
---
If your project is set up for it, you can reply to this
Github user davies commented on the pull request:
https://github.com/apache/spark/pull/12598#issuecomment-217294793
@jfchen I think you are hitting a different thing
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user jfchen commented on the pull request:
https://github.com/apache/spark/pull/12598#issuecomment-217293423
Not able to validate this in the past two builds. I am using --master yarn.
Still getting
{noformat}
Exception while getting task result:
Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/12598#issuecomment-216662846
Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user davies commented on the pull request:
https://github.com/apache/spark/pull/12598#issuecomment-216662322
Yes, updated the comment
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/12598#issuecomment-216659105
And branch-2.0 right?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/12598
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user davies commented on the pull request:
https://github.com/apache/spark/pull/12598#issuecomment-216657833
Merging this into master, thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12598#issuecomment-216644150
**[Test build #2966 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2966/consoleFull)**
for PR 12598 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12598#issuecomment-216620696
**[Test build #2966 has
started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2966/consoleFull)**
for PR 12598 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12598#issuecomment-216607550
**[Test build #2964 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2964/consoleFull)**
for PR 12598 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12598#issuecomment-216604565
**[Test build #2964 has
started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2964/consoleFull)**
for PR 12598 at commit
Github user davies commented on the pull request:
https://github.com/apache/spark/pull/12598#issuecomment-216592103
LGTM, two minor comments
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user davies commented on a diff in the pull request:
https://github.com/apache/spark/pull/12598#discussion_r61914539
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/joins/HashedRelation.scala
---
@@ -324,8 +348,10 @@ private[joins] object
Github user davies commented on a diff in the pull request:
https://github.com/apache/spark/pull/12598#discussion_r61914359
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/joins/HashedRelation.scala
---
@@ -171,36 +174,53 @@ private[joins] class
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12598#issuecomment-216454340
**[Test build #2963 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2963/consoleFull)**
for PR 12598 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12598#issuecomment-216443482
**[Test build #2963 has
started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2963/consoleFull)**
for PR 12598 at commit
Github user yzhou2001 commented on the pull request:
https://github.com/apache/spark/pull/12598#issuecomment-216442977
Jenkins failed on LogisticRegressionSuite. I run that suite standalone and
all test cases pass.
---
If your project is set up for it, you can reply to this email
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12598#issuecomment-216423957
**[Test build #2962 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2962/consoleFull)**
for PR 12598 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12598#issuecomment-216416868
**[Test build #2962 has
started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2962/consoleFull)**
for PR 12598 at commit
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/12598#discussion_r61831933
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/joins/HashedRelationSuite.scala
---
@@ -77,6 +78,16 @@ class HashedRelationSuite extends
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/12598#discussion_r61831928
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/joins/HashedRelationSuite.scala
---
@@ -149,6 +160,19 @@ class HashedRelationSuite extends
Github user davies commented on a diff in the pull request:
https://github.com/apache/spark/pull/12598#discussion_r61670922
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/joins/HashedRelation.scala
---
@@ -248,6 +251,85 @@ private[joins] class
Github user davies commented on a diff in the pull request:
https://github.com/apache/spark/pull/12598#discussion_r61670862
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/joins/HashedRelation.scala
---
@@ -677,6 +761,60 @@ private[execution] final class
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12598#issuecomment-215950566
**[Test build #2950 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2950/consoleFull)**
for PR 12598 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12598#issuecomment-215947005
**[Test build #2950 has
started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2950/consoleFull)**
for PR 12598 at commit
Github user yzhou2001 commented on the pull request:
https://github.com/apache/spark/pull/12598#issuecomment-215946058
Tests run: hive/test, sql/test, catalyst/test, dev/lint-scala,
org.apache.spark.sql.hive.execution.HiveCompatibilitySuite, dev/scalastyle
hive/test sees 3
Github user yzhou2001 commented on the pull request:
https://github.com/apache/spark/pull/12598#issuecomment-215916414
ok. Will post a PR today or tomorrow.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user davies commented on the pull request:
https://github.com/apache/spark/pull/12598#issuecomment-215890719
@yzhou2001 I think the better fix could be implement KryoSerializer for
LongToUnsafeRowMap and two HashedRelations ?
---
If your project is set up for it, you can
Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/12598#issuecomment-215890354
Actually was talking with Davies offline. We should just implement Kryo
serialization for these.
---
If your project is set up for it, you can reply to this email and
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12598#issuecomment-215399829
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12598#issuecomment-215399831
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12598#issuecomment-215399590
**[Test build #57242 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/57242/consoleFull)**
for PR 12598 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12598#issuecomment-215372240
**[Test build #57242 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/57242/consoleFull)**
for PR 12598 at commit
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/12598#issuecomment-215371295
Jenkins retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user yzhou2001 commented on a diff in the pull request:
https://github.com/apache/spark/pull/12598#discussion_r61317429
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/joins/HashedRelation.scala
---
@@ -324,7 +324,9 @@ private[joins] object
Github user yzhou2001 commented on the pull request:
https://github.com/apache/spark/pull/12598#issuecomment-215193028
Don't know why it fails again. It fails on MapWithStateSuite of Streaming.
I run the test suite on my local box and it's ok:
[info] MapWithStateSuite:
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12598#issuecomment-215030159
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12598#issuecomment-215030156
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12598#issuecomment-215029814
**[Test build #57101 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/57101/consoleFull)**
for PR 12598 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12598#issuecomment-21513
**[Test build #57101 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/57101/consoleFull)**
for PR 12598 at commit
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/12598#issuecomment-214998433
Jenkins retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/12598#discussion_r61217298
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/joins/HashedRelation.scala
---
@@ -324,7 +324,9 @@ private[joins] object
Github user yzhou2001 commented on the pull request:
https://github.com/apache/spark/pull/12598#issuecomment-214922110
I can't see why the test failed from a timeout. Can Jenkins retest this
again?
---
If your project is set up for it, you can reply to this email and have your
Github user yzhou2001 commented on a diff in the pull request:
https://github.com/apache/spark/pull/12598#discussion_r61183058
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/joins/HashedRelation.scala
---
@@ -324,7 +324,9 @@ private[joins] object
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12598#issuecomment-214730046
**[Test build #56988 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/56988/consoleFull)**
for PR 12598 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12598#issuecomment-214730386
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12598#issuecomment-214730384
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12598#issuecomment-214670002
**[Test build #56988 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/56988/consoleFull)**
for PR 12598 at commit
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/12598#issuecomment-214669749
Jenkins test this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/12598#discussion_r61048104
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/joins/HashedRelation.scala
---
@@ -324,7 +324,9 @@ private[joins] object
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/12598#discussion_r60693434
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/joins/HashedRelation.scala
---
@@ -324,8 +324,8 @@ private[joins] object
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/12598#discussion_r60693402
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/joins/HashedRelation.scala
---
@@ -325,7 +325,7 @@ private[joins] object
Github user yzhou2001 commented on the pull request:
https://github.com/apache/spark/pull/12598#issuecomment-213257305
cc @rajeshbalamohan
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user yzhou2001 commented on the pull request:
https://github.com/apache/spark/pull/12598#issuecomment-213253503
@HyukjinKwon thanks for comments. will make the change soon
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user HyukjinKwon commented on the pull request:
https://github.com/apache/spark/pull/12598#issuecomment-213233028
(I think `CC: @rajeshbalamohan` should be removed because the PR
description describes the PR itself and the names of reviewers might not be
related with the PR
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/12598#discussion_r60687833
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/joins/HashedRelation.scala
---
@@ -324,8 +324,8 @@ private[joins] object
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12598#issuecomment-213227368
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
GitHub user yzhou2001 opened a pull request:
https://github.com/apache/spark/pull/12598
[SPARK-14521][SQL]StackOverflowError in Kryo when executing TPC-DS
## What changes were proposed in this pull request?
Observed stackOverflowError in Kryo when executing TPC-DS Query27.
60 matches
Mail list logo
