Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/12373
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is ena
Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/12373#issuecomment-218918085
I added https://github.com/apache/spark/pull/13084
I thought about it more -- since it is unclear how often people will
actually use these functions, it's probably
Github user bomeng commented on the pull request:
https://github.com/apache/spark/pull/12373#issuecomment-212169908
@rxin Could you please take a look if you get a chance? Thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12373#issuecomment-210648042
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12373#issuecomment-210648046
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12373#issuecomment-210647710
**[Test build #55948 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55948/consoleFull)**
for PR 12373 at commit
[`4e21e1a`](https://g
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12373#issuecomment-210645451
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12373#issuecomment-210645449
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12373#issuecomment-210645190
**[Test build #55947 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55947/consoleFull)**
for PR 12373 at commit
[`451e5fb`](https://g
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12373#issuecomment-210610769
**[Test build #55948 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55948/consoleFull)**
for PR 12373 at commit
[`4e21e1a`](https://gi
Github user bomeng commented on a diff in the pull request:
https://github.com/apache/spark/pull/12373#discussion_r59928147
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/nullExpressions.scala
---
@@ -128,6 +128,143 @@ case class IsNaN(child: Expre
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12373#issuecomment-210605685
**[Test build #55947 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55947/consoleFull)**
for PR 12373 at commit
[`451e5fb`](https://gi
Github user bomeng commented on the pull request:
https://github.com/apache/spark/pull/12373#issuecomment-210605312
I have revisited the codes and made the codes more robust. Heavily tested
against different data types by using introducing testAllTypes2Values() with 2
different values
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/12373#discussion_r59922485
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/nullExpressions.scala
---
@@ -128,6 +128,143 @@ case class IsNaN(child: Express
Github user bomeng commented on a diff in the pull request:
https://github.com/apache/spark/pull/12373#discussion_r59904696
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/nullExpressions.scala
---
@@ -128,6 +128,143 @@ case class IsNaN(child: Expre
Github user bomeng commented on the pull request:
https://github.com/apache/spark/pull/12373#issuecomment-210300785
I will address these issues tomorrow! Thank you all!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If y
Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/12373#issuecomment-210288398
Also can you remove the "JIRA related" section from the description? It is
redundant with the title when makes into the commit message.
---
If your project is set up for
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/12373#discussion_r59813396
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/NullFunctionsSuite.scala
---
@@ -55,6 +55,28 @@ class NullFunctionsSuite extend
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/12373#discussion_r59813323
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/functions.scala ---
@@ -1015,6 +1015,33 @@ object functions {
def nanvl(col1: Column, col2: Column)
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/12373#discussion_r59813273
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/nullExpressions.scala
---
@@ -128,6 +128,143 @@ case class IsNaN(child: Express
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/12373#discussion_r59813226
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/nullExpressions.scala
---
@@ -128,6 +128,143 @@ case class IsNaN(child: Express
Github user davies commented on a diff in the pull request:
https://github.com/apache/spark/pull/12373#discussion_r59813149
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/functions.scala ---
@@ -1015,6 +1015,33 @@ object functions {
def nanvl(col1: Column, col2: Colum
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12373#issuecomment-210200450
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12373#issuecomment-210200448
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12373#issuecomment-210200281
**[Test build #55850 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55850/consoleFull)**
for PR 12373 at commit
[`04a361a`](https://g
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12373#issuecomment-210173704
**[Test build #55850 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55850/consoleFull)**
for PR 12373 at commit
[`04a361a`](https://gi
26 matches
Mail list logo
